From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albin Subject: Re: [PATCH] services: 'console-keymap-service' takes multiple files. Date: Sat, 16 Apr 2016 04:47:29 +0200 Message-ID: <5711A7C1.3040601@fripost.org> References: <87a8l3eqhc.fsf@gmail.com> <87lh4hcifc.fsf@gnu.org> <878u0eq2dv.fsf@gmail.com> <87vb3ir2pp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52261) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1arGGl-0005Qg-R4 for guix-devel@gnu.org; Fri, 15 Apr 2016 22:47:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1arGGi-0000IC-Kv for guix-devel@gnu.org; Fri, 15 Apr 2016 22:47:35 -0400 In-Reply-To: <87vb3ir2pp.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?UTF-8?Q?Ludovic_Court=c3=a8s?= , Alex Kost Cc: guix-devel@gnu.org Den 2016-04-15 kl. 23:17, skrev Ludovic Court=C3=A8s: > Alex Kost skribis: >=20 >> Ludovic Court=C3=A8s (2016-04-14 00:23 +0300) wrote: >> >>> Alex Kost skribis: >>> >>>> From 8c58974b549479a8e97cf64f21393aa495596e13 Mon Sep 17 00:00:00 20= 01 >>>> From: Alex Kost >>>> Date: Sat, 9 Apr 2016 00:21:15 +0300 >>>> Subject: [PATCH] services: 'console-keymap-service' takes multiple f= iles. >>>> >>>> * gnu/services/base.scm (console-keymap-service-type): Type procedur= e >>>> takes a list of files instead of a single file. >>>> (console-keymap-service): Take 'files' as rest arguments. >>>> * doc/guix.texi (Base Services): Improve documentation of >>>> 'console-keymap-service'. >>> >>> [...] >>> >>>> +Return a service to load console keymaps from @var{files} using >>>> +@command{loadkeys} command. Most likely, you want to load some def= ault >>>> +keymap, which can be done like this: >>>> + >>>> +@example >>>> +(console-keymap-service "dvorak") >>>> +@end example >>> >>> Perhaps you could add the example from the IRC discussion you mention= ed >>> with a short explanation, just below this example? >> >> Would the following be OK? >> >> >> @deffn {Scheme Procedure} console-keymap-service @var{files} ... >> @cindex keyboard layout >> Return a service to load console keymaps from @var{files} using >> @command{loadkeys} command. Most likely, you want to load some defaul= t >> keymap, which can be done like this: >> >> @example >> (console-keymap-service "dvorak") >> @end example >> >> Or, for example, for Swedish keyboards, you may need to combine keymap= s: >> @example >> (console-keymap-service "se-ir209" "se-fi-ir209") >=20 > Ideally with a few words to explain why this is useful on Swedish > keyboards (Albin? :-)), but otherwise LGTM! >=20 > Ludo=E2=80=99. >=20 I don't think it's necessary to explain exactly why it's useful here because it's a simple fact that loading just the first "se-ir209" doesn't enable a Swedish but some kind of US-Danish freak keymap :-), which the user will soon discover. If it doesn't cross your mind that *two* keymaps may be necessary for using *one* keyboard (how obvious is that, really?), then you might start to think that perhaps the Guix folks simply forgot to include the one that you need. IMHO upstream should ditch the whole dual keymap thing if it's technically feasible to do so. The formulation above looks good to me also, except I think it's clearer with the formulation "a Swedish keyboard" in this context. Albin