Re: [PATCH] services: 'console-keymap-service' takes multiple files.

[Albin <albin@fripost.org>]

Den 2016-04-15 kl. 23:17, skrev Ludovic Courtès:
> Alex Kost <alezost@gmail.com> skribis:
> 
>> Ludovic Courtès (2016-04-14 00:23 +0300) wrote:
>>
>>> Alex Kost <alezost@gmail.com> skribis:
>>>
>>>> From 8c58974b549479a8e97cf64f21393aa495596e13 Mon Sep 17 00:00:00 2001
>>>> From: Alex Kost <alezost@gmail.com>
>>>> Date: Sat, 9 Apr 2016 00:21:15 +0300
>>>> Subject: [PATCH] services: 'console-keymap-service' takes multiple files.
>>>>
>>>> * gnu/services/base.scm (console-keymap-service-type): Type procedure
>>>> takes a list of files instead of a single file.
>>>> (console-keymap-service): Take 'files' as rest arguments.
>>>> * doc/guix.texi (Base Services): Improve documentation of
>>>> 'console-keymap-service'.
>>>
>>> [...]
>>>
>>>> +Return a service to load console keymaps from @var{files} using
>>>> +@command{loadkeys} command.  Most likely, you want to load some default
>>>> +keymap, which can be done like this:
>>>> +
>>>> +@example
>>>> +(console-keymap-service "dvorak")
>>>> +@end example
>>>
>>> Perhaps you could add the example from the IRC discussion you mentioned
>>> with a short explanation, just below this example?
>>
>> Would the following be OK?
>>
>>
>> @deffn {Scheme Procedure} console-keymap-service @var{files} ...
>> @cindex keyboard layout
>> Return a service to load console keymaps from @var{files} using
>> @command{loadkeys} command.  Most likely, you want to load some default
>> keymap, which can be done like this:
>>
>> @example
>> (console-keymap-service "dvorak")
>> @end example
>>
>> Or, for example, for Swedish keyboards, you may need to combine keymaps:
>> @example
>> (console-keymap-service "se-ir209" "se-fi-ir209")
> 
> Ideally with a few words to explain why this is useful on Swedish
> keyboards (Albin? :-)), but otherwise LGTM!
> 
> Ludo’.
> 

I don't think it's necessary to explain exactly why it's useful here
because it's a simple fact that loading just the first "se-ir209"
doesn't enable a Swedish but some kind of US-Danish freak keymap :-),
which the user will soon discover.  If it doesn't cross your mind that
*two* keymaps may be necessary for using *one* keyboard (how obvious is
that, really?), then you might start to think that perhaps the Guix
folks simply forgot to include the one that you need.  IMHO upstream
should ditch the whole dual keymap thing if it's technically feasible to
do so.

The formulation above looks good to me also, except I think it's clearer
with the formulation "a Swedish keyboard" in this context.


Albin