From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manolis Ragkousis Subject: Re: [PATCH 1/5] gnu: Add avr-binutils. Date: Thu, 14 Apr 2016 21:32:50 +0300 Message-ID: <570FE252.6040400@gmail.com> References: <1460639824-9976-1-git-send-email-dthompson2@worcester.edu> <1460639824-9976-2-git-send-email-dthompson2@worcester.edu> <87wpo0ktpz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37242) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqm4W-0003rh-LA for guix-devel@gnu.org; Thu, 14 Apr 2016 14:32:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aqm4T-0006jA-Fp for guix-devel@gnu.org; Thu, 14 Apr 2016 14:32:56 -0400 In-Reply-To: <87wpo0ktpz.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?UTF-8?Q?Ludovic_Court=c3=a8s?= Cc: guix-devel@gnu.org Hey Ludo, On 04/14/16 20:04, Ludovic Courtès wrote: > AFAICS --target=avr is redundant: > > --8<---------------cut here---------------start------------->8--- > $ git describe > v0.10.0-204-ga2d0e20 > $ wget -q -O - $(./pre-inst-env guix build --log-file -e '((@ (gnu packages cross-base) cross-binutils) "avr")') |grep -e --target > configure flags: ("CONFIG_SHELL=/gnu/store/b1yqjimbdh5bf9jnizd4h7yf110744j2-bash-4.3.42/bin/bash" "SHELL=/gnu/store/b1yqjimbdh5bf9jnizd4h7yf110744j2-bash-4.3.42/bin/bash" "--prefix=/gnu/store/gqmq8gis9igpg4xy6022mvq8qpvp7kk4-binutils-cross-avr-2.25.1" "--enable-fast-install" "--build=x86_64-unknown-linux-gnu" "--target=avr" "--with-sysroot=/" "LDFLAGS=-static-libgcc" "--with-lib-path=/no-ld-lib-path" "--disable-werror" "--enable-install-libbfd" "--enable-deterministic-archives") > --8<---------------cut here---------------end--------------->8--- > > … and --disable-nls is orthogonal and probably unnecessary. > > Can we skip this patch? :-) We added --disable-nls mostly because it was suggested from the avr-libc manual to be passed to binutils and gcc. David can you build the toolchain without it and see if it works? And I would really prefer if we had a way to explicitly install avr-binutils. This way it will be more clear to someone only wanting to install this specific package. We could keep something like this (define-public avr-binutils (package (inherit (cross-binutils "avr")) (name "avr-binutils"))) Manolis