Re: [PATCH] gnu: Add openttd

[Albin <albin@fripost.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1503 bytes --]

Den 2016-04-12 kl. 10:30, skrev Alex Kost:
> Leo Famulari (2016-04-12 04:09 +0300) wrote:
> 
>> On Tue, Apr 12, 2016 at 12:41:58AM +0200, Albin wrote:
>>> Subject: [PATCH] gnu: Add openttd.
>>
>> Can you add the "changelog" to the commit message? See commit 6dc609985
>> for a recent example of the desired format.
> 
> Leo means the commit message should look like this:
> 
> --8<---------------cut here---------------start------------->8---
> gnu: Add openttd.
> 
> * gnu/packages/games.scm (openttd): New variable.
> --8<---------------cut here---------------end--------------->8---

Thanks!

> 
> 
>>> +    (source
>>> +     (origin (method url-fetch)
>>> +             ;; The official download URL is
>>> +             ;; http://binaries.openttd.org/releases/1.6.0/openttd-1.6.0-source.tar.xz
>>> +             ;; but it doesn't work with `guix download`.  However, it
>>> +             ;; redirects to the one below (and the SHA sums match).
>>
>> Is it a problem with `guix download` or with the remote server? Even if
>> we don't fix the issue, it would be nice to say what the problem is in
>> this comment.
> 
> It is not only 'guix download', the same happens with 'guix build'.
> I've reported it at <http://bugs.gnu.org/23275>.  Thanks for this useful
> comment!.
> 

I see that you've already prepared a patch for this bug so I guess that
I should wait for it to be merged, change to the official URL and then
submit a new openttd patch.

Albin


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]