From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyril Roelandt Subject: Re: [REQ/DISCUSSION] patch managing system Date: Wed, 30 Mar 2016 22:52:15 +0200 Message-ID: <56FC3C7F.5010200@gmail.com> References: <87h9g0eq1c.fsf@grrlz.net> <87d1qogcfw.fsf@grrlz.net> <87wpoval25.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57196) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alN6D-0004j4-6G for guix-devel@gnu.org; Wed, 30 Mar 2016 16:52:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alN6A-00080e-GL for guix-devel@gnu.org; Wed, 30 Mar 2016 16:52:21 -0400 In-Reply-To: <87wpoval25.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Mathieu Lirzin , Nils Gillmann Cc: guix-devel@gnu.org On 03/21/2016 04:48 PM, Mathieu Lirzin wrote: > To automate the repetitive tasks, Cyril Roelandt had started sometimes > ago to work on a bot that was continuously applying and building > incoming patches on top of master and report (by email) if things were > building correctly. I think that is a good idea that could be extended > by providing a way to send commands to the bot like what is done for > Debbugs. Yeah, it was a fun experiment. The main issue is that reading mail is harder than it looks. People attach patches to their mails, they send them using git-send-email, they attach the output of "git format-patch" to a regular mail, they have weird encodings, etc. That means there are lots of cases to tests, and lots of potential bugs. If the "patches" tool from QEMU does that well already, I'd be in favor of not recoding it :) That being said, something we really need is a tool that helps us handle trivial update patches (basically, patches that just update the version and the hash of a given package). It should apply the patch and run a script like this one: $ cat check-update.sh make || exit 1 for pkg in $(./pre-inst-env guix refresh -l $1 | sed 's/.*: //') do echo "[+] Rebuilding $pkg" ./pre-inst-env guix build $pkg if [ "$?" -ne "0" ]; then echo "[+] Rebuilding $pkg: KO" exit 1 else echo "[+] Rebuilding $pkg: OK" fi done I think we could have a mailing-list dedicated to these trivial update patches. I'd also be in favor of splitting the mailing-list into many smaller ones, such as: - core; - packages; - trivial updates. WDYT? Cyril.