From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Baines Subject: Re: [PATCH 3/3] gnu: Add vcsh Date: Thu, 18 Feb 2016 21:32:52 +0000 Message-ID: <56C63884.6060009@cbaines.net> References: <1455379675-27516-1-git-send-email-mail@cbaines.net> <1455379675-27516-4-git-send-email-mail@cbaines.net> <20160213224108.GC1176@jasmine> <56C0E530.9010604@cbaines.net> <20160217181107.GA31074@solar> <56C4C2FC.7070107@cbaines.net> <20160218001144.GA26345@jasmine> <20160218200100.GC3445@solar> <20160218212626.GA1053@jasmine> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="37iVdHCscAPNUmxwhlfXA50UCtROLgaek" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42179) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWWC2-0000Wn-UD for guix-devel@gnu.org; Thu, 18 Feb 2016 16:32:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWWBz-0001D5-Ox for guix-devel@gnu.org; Thu, 18 Feb 2016 16:32:58 -0500 Received: from mira.cbaines.net ([2a01:7e00::f03c:91ff:fe69:8da9]:34280) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWWBz-0001D0-GC for guix-devel@gnu.org; Thu, 18 Feb 2016 16:32:55 -0500 In-Reply-To: <20160218212626.GA1053@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Leo Famulari , Andreas Enge Cc: guix-devel@gnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --37iVdHCscAPNUmxwhlfXA50UCtROLgaek Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 18/02/16 21:26, Leo Famulari wrote: > On Thu, Feb 18, 2016 at 09:01:00PM +0100, Andreas Enge wrote: >> On Wed, Feb 17, 2016 at 07:11:44PM -0500, Leo Famulari wrote: >>> I missed this earlier. We don't usually propagate this sort of "end-u= ser >>> program" dependencies. For example rsync does not propagate ssh; the >>> user must install ssh. [0] >> >> I think the cleanest approach would be to patch all calls to "git" in >> the vcsh shell script by calls to "/gnu/store/xxxx-git-.../bin/git", >> where the base name is taken as "(assoc-ref %build-inputs "git")" or t= he like. >> >> What do you think? >=20 > Indeed, this sounds like a clean solution. In that case, git would be a= > plain input. >=20 >> >> It might be as simple as a call in a phase to "substitute*", replacing= >> "git " by the path+" ". The script is a bit annoying in that it scatte= rs >> calls to git all over the place. It would be cleaner to define "GIT=3D= git" >> at the start of the file, and then always call "$(GIT)". Maybe that is= >> something to suggest to the upstream author? >=20 > Since 'git' is such a short string, the possibility of "mis-patching" > when performing the string substitution seems a little too high. What d= o > you think? A patch could be written as Andreas describes (to use a variable), and then this could be used for Guix. Once written, the patch could also be sent to the upstream maintainer to see if they want to include it. --37iVdHCscAPNUmxwhlfXA50UCtROLgaek Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJWxjiEXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzRTg5RUVFNzQ1OEU3MjBEOTc1NEUwQjI1 RTI4QTMzQjBCODRGNTc3AAoJEF4oozsLhPV3fIIP/A9nQZLGPgDy9w60uaIaE/nn pyh1Nba1exCeJte4aDKmwXuP2D1OH7KBGOcU718CmOLOpBMkrNDSMJ52XhSES+Xk 7kcNbs8KYtnjdOUSdK0nxQWLMXv29HDOFJsx5wJmIBVqX2DB1C0ob/pMEuBZkzFY f6S6iRAVprF0eRrYnGSBmSvuwcAfcl/ShgtXIjJ2oHKb9KbGK2MxxgNiV2fm7aFr /AMy0d57LuO6Ua32aNXCjPP7L79GlrLCCT/GW/KHmKdJPdQFFJKSRtRfdqu9RqG6 2MokfafNYsU9jmB15mSXsgU+pvzQW64H/3nGs6Vv2JwzUEVaZqn/nnKQbQ9k9Z1Q 1qJiAVNEbfWTcnMM+7avwTQUGB3I5iH/ffArP25J7Linbn4j/zDFV+uCl0SBOVfO CkmoYUG5iiUQwmzgMtXT1bC+lH8SWKIdg8BscLgjoFDVBapbMlHXUWQT0WCY4sQI 10Y2AWjBUN8GUttf1/wmFVOjQyhTPWOjQmLgeQtxKGr1jaKTpsQ0GBONa2aSVDeF RguTwN6cgq6ackzYosaeoO4eyFb7Eo0JTiiGMhPf1Y5Xthwt/9AQEnWbbsrND3On QkxOiOtYLoI/UWsfenCBYnFfgqbM+8eki2TSIpOOmgtO3ztghhJP9miLvoijMSJM XWxYUGoVZFBUQRgBeVfn =jSQX -----END PGP SIGNATURE----- --37iVdHCscAPNUmxwhlfXA50UCtROLgaek--