From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Woodcroft <b.woodcroft@uq.edu.au>
Subject: Re: [PATCH] import: Move beautify description from cran to utils.
	(was Re: [PATCH 6/6] gnu: Add emacs-slime.)
Date: Thu, 14 Jan 2016 20:53:59 +1000
Message-ID: <56977E47.50104@uq.edu.au>
References: <CAKrPhPNBb2FoSGNM9cPgQe2i=7RQcKJyx6gzPo+4QW+SFO0KvQ@mail.gmail.com>
	<56847D01.3010702@uq.edu.au> <87y4cb9c7a.fsf@elephly.net>
	<87y4ca18h3.fsf@gmail.com> <87si2haepb.fsf@mdc-berlin.de>
	<56863A6B.90809@uq.edu.au> <87r3i19w8s.fsf@mdc-berlin.de>
	<568BD248.5090309@uq.edu.au> <87h9ilyw1b.fsf@gnu.org>
	<56976F1B.8010405@uq.edu.au> <87k2nc310w.fsf@mdc-berlin.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34604)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <b.woodcroft@uq.edu.au>) id 1aJfXg-0006Hz-Gm
	for guix-devel@gnu.org; Thu, 14 Jan 2016 05:54:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <b.woodcroft@uq.edu.au>) id 1aJfXc-0007Kx-Fu
	for guix-devel@gnu.org; Thu, 14 Jan 2016 05:54:12 -0500
In-Reply-To: <87k2nc310w.fsf@mdc-berlin.de>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: Guix-devel <guix-devel@gnu.org>, Alex Kost <alezost@gmail.com>, Federico Beffa <beffa@ieee.org>



On 14/01/16 20:31, Ricardo Wurmus wrote:
> Ben Woodcroft <b.woodcroft@uq.edu.au> writes:
>
>> On 11/01/16 07:17, Ludovic Court=C3=A8s wrote:
>>> Ben Woodcroft <b.woodcroft@uq.edu.au> skribis:
>>>
>>>>   From e3bad19a07d6a9fdf3045619232a24b77a1a5d12 Mon Sep 17 00:00:00 =
2001
>>>> From: Ben Woodcroft <donttrustben@gmail.com>
>>>> Date: Wed, 6 Jan 2016 00:09:19 +1000
>>>> Subject: [PATCH 1/2] import: cran: Move beautify-description to util=
s module.
>>>>
>>>> * guix/import/cran.scm (beautify-description): Move from here...
>>>> * guix/import/utils.scm: ... to here.
>>> [...]
>>>
>>>>   From eb65d0ef0140ac2828b608c31ae19893861fea3a Mon Sep 17 00:00:00 =
2001
>>>> From: Ben Woodcroft <donttrustben@gmail.com>
>>>> Date: Wed, 6 Jan 2016 00:17:36 +1000
>>>> Subject: [PATCH 2/2] import: gem: Beautify description field.
>>>>
>>>> * guix/import/gem.scm (gem->guix-package): Use 'beautify-description=
'.
>>> LGTM, thanks!
>> Pushed, ta.
> This breaks two of the cran importer tests:
>
> (test-equal "beautify-description: use double spacing"
>    "This is a package.  It is great.  Trust me Mr.  Hendrix."
>    ((@@ (guix import cran) beautify-description)
>     "This is a package. It is great. Trust me Mr. Hendrix."))
>
> (test-equal "beautify-description: transform fragment into sentence"
>    "This package provides a function to establish world peace"
>    ((@@ (guix import cran) beautify-description)
>     "A function to establish world peace"))
>
> How about moving these tests elsewhere?  (Or should they be removed?)
Ah, sorry. Should they be moved to a new file tests/import-utils? Why do=20
you suggest that they should be removed?

ben