From: Ben Woodcroft <b.woodcroft@uq.edu.au>
To: Eric Bavier <ericbavier@openmailbox.org>,
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: Guix-devel <guix-devel@gnu.org>,
guix-devel-bounces+ericbavier=openmailbox.org@gnu.org
Subject: Re: [PATCH] Add Jellyfish.
Date: Sat, 19 Dec 2015 09:25:23 +1000 [thread overview]
Message-ID: <567495E3.5010803@uq.edu.au> (raw)
In-Reply-To: <9507d13e837c22beb6e5a79cce045222@openmailbox.org>
Hi Ricardo,
On 19/12/15 04:19, Eric Bavier wrote:
> On 2015-12-18 17:42, Ricardo Wurmus wrote:
>> * gnu/packages/bioinformatics.scm (jellyfish): New variable.
> [...]
>> + (native-inputs
>> + `(("bc" ,bc)
>> + ("time" ,time)
>> + ("gunzip" ,gzip)))
>
> gzip is an implicit input of gnu-build-system, so could it be left out?
My testing confirms this.
But would it be possible to include the scripting language bindings,
something along these lines?
+ (arguments
+ `(#:configure-flags '("--enable-ruby-binding"
+ "--enable-python-binding"
+ "--enable-perl-binding")
+ #:phases
+ (modify-phases %standard-phases
+ (add-before 'check 'set-SHELL-variable
+ (lambda _
+ ;; generator_manager.hpp either uses /bin/sh or $SHELL
+ ;; to run tests.
+ (setenv "SHELL" (which "bash"))
+ #t)))))
+ (native-inputs
+ `(("bc" ,bc)
+ ("time" ,time)
+ ("ruby" ,ruby)
+ ("python" ,python-2)
+ ("perl" ,perl)))
Currently the perl tests fail for reasons I don't have time to
investigate, and perhaps some search paths need to be exported too.
I did find the time to confirm that the most important part of this
program works though:
sh-4.3# jellyfish jf
.......
.......... .....
.... ....
.. /-+ +---\ ...
. /--| +----\ ...
.. ...
. .
.. +----------------+ .
. |. AAGATGGAGCGC .| ..
. |---. .--/ .
.. \--------/ . .
. . .. .. .
. ... ..... ..... .. ..
. .. . . . .. . .... .
. .. . .. . . .. . . .
. .. . . ... . .. .. .
.... . .. .. ... .. .
.. . ... . .. .. .
. .. . . . ... ..
... . . .. ... .
. .. . .. .....
____ ____ ._ __ _ _ ____ ____ ___ _ _
(_ _)( ___)( ) ( ) ( \/ )( ___)(_ _)/ __)( )_( )
.-_)( )__) )(__ )(__ \ / )__) _)(_ \__ \ ) _ (
\____) (____)(____)(____)(__) (__) (____)(___/(_) (_)
next prev parent reply other threads:[~2015-12-18 23:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 16:42 [PATCH] Add Jellyfish Ricardo Wurmus
2015-12-18 18:19 ` Eric Bavier
2015-12-18 23:25 ` Ben Woodcroft [this message]
2015-12-20 22:43 ` Ludovic Courtès
2015-12-30 15:58 ` Ricardo Wurmus
2016-01-01 22:15 ` Ludovic Courtès
2016-01-06 11:13 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567495E3.5010803@uq.edu.au \
--to=b.woodcroft@uq.edu.au \
--cc=ericbavier@openmailbox.org \
--cc=guix-devel-bounces+ericbavier=openmailbox.org@gnu.org \
--cc=guix-devel@gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.