From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id kPSKJ3vgOWdk3AAAe85BDQ:P1 (envelope-from ) for ; Sun, 17 Nov 2024 12:24:27 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id kPSKJ3vgOWdk3AAAe85BDQ (envelope-from ) for ; Sun, 17 Nov 2024 13:24:27 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=PceXWUc9; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="IbIxGR/z"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1731846267; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=kWAgky0wyJeLG0PCWUUmljlwHUzeYTn+Y2O2P8iM2lY=; b=V0TIu5RIxBtPV9GjUMb9UFVH1RrbWlUfmoTSv6qjFhZwBXjM3yFekJxmoVnTZbzOu2g1W3 huxVtNXr/BeZt6I9fB/FEilqvV7jk/8A5/ZneT5wATTRmRdDmb3ntgoIaBqgFZU3p6WfxB dv8MFxcTYhRBhYb8Mscs4GSLz12X+rYQ9vabybiNmtfQWxYyTTG6NidOjuY88x5Hd2Fmr8 G/OncT8wlL9DM4nriLWTjZ5NdiOogLoUBb0u/N0a/CdnCoes81dyS3X0m+qGxPlFWwwST/ D2Qd5GSYuLlyp0chroCHzrJNoLNJDp9HLA3aA5vd3Ef9kVCnKDdF066le9e18w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1731846267; a=rsa-sha256; cv=none; b=FBjP/Advv5XVmSxNKVxVWgLdK1pY3Ri5GfUC1V5aBbaf0PjyF0nGj7l7+cyYy8Evydb4Wf 4mDx2qRseP5MPzWDuC9lG/K2LRAb+yNTp62ZCsZMgal7muNhKfXjo1dq+t+SLZC/nsJlRj xdvq+DeJA9nTTdurCTSMcNngT3vkLEPacl0FpYXFVRKJfRGzds/vl9UDFMEakjl50Kxuy7 DavFRaBlg/jKVsLC3qesm9btwe+XBD+PIEAO4h+GuHxT4dERsGuEhOzpKgzFSsjcwZwFet Kj1OKQn8SUSut5W/XMQ/woOxklZLgkA0vZdB3doYw/TTKhIPAeaO0Py5dWBQWA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=PceXWUc9; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="IbIxGR/z"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1F483523CD for ; Sun, 17 Nov 2024 13:24:27 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tCeJx-0005O4-JU; Sun, 17 Nov 2024 07:24:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tCeJu-0005Nk-ON for guix-patches@gnu.org; Sun, 17 Nov 2024 07:24:02 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tCeJu-0006Al-Ff for guix-patches@gnu.org; Sun, 17 Nov 2024 07:24:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:Date:From:To:Subject; bh=kWAgky0wyJeLG0PCWUUmljlwHUzeYTn+Y2O2P8iM2lY=; b=PceXWUc95hrKId6jbWQ0WokWzApTHgTdT0La9MlC5ROhPQ/ZLVYl1vBMsTA0c8EzzMj76dUMb8RNXRKU7PyUEkwfT5yj5ekVyLpqnnbWcR5jXlJtwimmcmbTtY0dfSkYZEC8vTH5Ml6Vb4iK3KAHnwh1A78zdxNR+wCB3dbSlXpWMPfh9paNYIsqxc1TU8eykqWCjFEvLUvDIVhT/d5X5HguLWV8t2nsRblJNnCsghsDu8uADWImtT9bywPjpvEwUtf06qxzKqB/Z/3jt3ccH4EvlGtGk4adrKATz/Hshsd1il2D5lp5oLpqy1NfKytJgxHR22f6/v25sc9pv2d+tw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tCeJu-0007EE-AJ; Sun, 17 Nov 2024 07:24:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74394] [PATCH 1/2] build: Exclude expensive tests in check target by default. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: maxim.cournoyer@gmail.com, , guix-patches@gnu.org Resent-Date: Sun, 17 Nov 2024 12:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74394 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 74394@debbugs.gnu.org Cc: Maxim Cournoyer , Maxim Cournoyer , ( , Andrew Tropin , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Tanguy Le Carrour X-Debbugs-Original-Xcc: Maxim Cournoyer , ( , Andrew Tropin , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Tanguy Le Carrour Received: via spool by 74394-submit@debbugs.gnu.org id=B74394.173184619427708 (code B ref 74394); Sun, 17 Nov 2024 12:24:02 +0000 Received: (at 74394) by debbugs.gnu.org; 17 Nov 2024 12:23:14 +0000 Received: from localhost ([127.0.0.1]:56168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tCeJ7-0007Co-Ti for submit@debbugs.gnu.org; Sun, 17 Nov 2024 07:23:14 -0500 Received: from mail-pl1-f169.google.com ([209.85.214.169]:58659) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tCeJ5-0007Cf-EN for 74394@debbugs.gnu.org; Sun, 17 Nov 2024 07:23:12 -0500 Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-20c9978a221so34546055ad.1 for <74394@debbugs.gnu.org>; Sun, 17 Nov 2024 04:23:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731846130; x=1732450930; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kWAgky0wyJeLG0PCWUUmljlwHUzeYTn+Y2O2P8iM2lY=; b=IbIxGR/zph60GrganM/Gq9IloM3btIMBBXQK6J8WT64OYGMr2ioUIr7M3pIdBy4tb0 kcU71YuFAJhhAX/+GCtlOGvbbrajWOKsSK6S5vKxywH0NtFAJt5z7YBQgv5pyMtYlmKJ Tqd0tT4JP4zzOq76KtSEms3cJoTEoMuabou3oRrn3U0QDGd7/rVCm4+zlYxMdUEfSxSF TTAi0to0smm4570ZDbyLBSEqjriyLliBu4WPsijcjq6m/BqImEbwSsStxvy1XDaHaMZQ ZJvzMLUaCb16f+CHfPLqE0cgUCSTIev1VdV9o1EnMeVv8UNgF6brz8GXow3MQR9XTzcN EHAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731846130; x=1732450930; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kWAgky0wyJeLG0PCWUUmljlwHUzeYTn+Y2O2P8iM2lY=; b=lg0/ttUENnf16gr+ACHinGvv66fWl4oGxoIpMFpvysIZPnelana4bpI2gJX/6PyDCu FbI1NXEEEfaBQnf1wDqIxhkbpBHWRlNcDLU3Zpp/NlYh0Qyc9sUnU6DTfRRJuy+jsYcC H+VPaR+kgj/hYIEYhRlWsFBxUc4cMU3MWlCKf9fl3kFpCay3uai81Xvfw4/Kr0i6pPlu tGmeBXjU5jxqTVfQCl1C5yYjCS+7x7uYojol0jZrwpkTbPTy47oT2RQVPkpH+8uB7IjT iKY73Z2W5hiUOMHH5ijy9iCUBrEvogB9c7qqOldESGsEPJHrPMmH4hvgdm1ZuISS5AXx HviQ== X-Gm-Message-State: AOJu0YyVL+fr+lgG2UArLDc21pSYczNL/Y81KhgrTjo2A3UIYEpbCRMn RKNFYY961b85Vy24q3EZIFJFwRYwXAAsA4nPkwcM5De06431siNZP6uJFQ== X-Google-Smtp-Source: AGHT+IF8yjGX2vGRGlgEub/dfPDN839jlt5lCEmoDXuUhX5MGop7QIaItz/uLDO1kQLDUdQvEeBUXA== X-Received: by 2002:a17:903:2451:b0:20c:9d8d:1f65 with SMTP id d9443c01a7336-211d0d77b44mr128726465ad.30.1731846129646; Sun, 17 Nov 2024 04:22:09 -0800 (PST) Received: from localhost.localdomain ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-724771e12f0sm4294387b3a.132.2024.11.17.04.22.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Nov 2024 04:22:09 -0800 (PST) From: Maxim Cournoyer Date: Sun, 17 Nov 2024 21:21:46 +0900 Message-ID: <5664cb3f6c9a888c74dd74a29912578e30697c72.1731844485.git.maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -0.60 X-Spam-Score: -0.60 X-Migadu-Queue-Id: 1F483523CD X-Migadu-Scanner: mx13.migadu.com X-TUID: X5ORguS5yrcJ This reduces the test time of 'make -j check' from ~22 minutes to a bit more than one minute on a fast machine. * Makefile.am [CAN_RUN_TESTS] (check-local): New target. * tests/guix-home.sh: Skip unless WITH_SLOW_TESTS is 1. * tests/guix-package.sh: Likewise. * tests/guix-system.sh: Likewise. * tests/guix-time-machine.sh: Exclude one command. Change-Id: Ieb61bf5d54aedd4bd32f93da792a4ac7dd8b9e7d --- Makefile.am | 9 ++++++++- tests/guix-home.sh | 5 +++++ tests/guix-package.sh | 5 +++++ tests/guix-system.sh | 4 ++++ tests/guix-time-machine.sh | 4 +++- 5 files changed, 25 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index e94ba87797..4bec4d4a06 100644 --- a/Makefile.am +++ b/Makefile.am @@ -14,7 +14,7 @@ # Copyright © 2018 Oleg Pykhalov # Copyright © 2018 Alex Vong # Copyright © 2019, 2023 Efraim Flashner -# Copyright © 2020, 2021, 2023 Maxim Cournoyer +# Copyright © 2020, 2021, 2023, 2024 Maxim Cournoyer # Copyright © 2021 Chris Marusich # Copyright © 2021 Andrew Tropin # Copyright © 2023 Clément Lassieur @@ -668,6 +668,13 @@ tests/guix-gc.log: \ $(patsubst %.sh,%.log,$(filter-out tests/guix-gc.sh,$(SH_TESTS))) \ $(SCM_TESTS:%.scm=%.log) +check-local: + @echo + @if [ "$$WITH_SLOW_TESTS" != 1 ]; then \ + echo "Skipping slow tests; set WITH_SLOW_TESTS to 1 to run them"; \ + fi + @echo + else !CAN_RUN_TESTS TESTS = diff --git a/tests/guix-home.sh b/tests/guix-home.sh index 649d811a0c..1c7b6da1cd 100644 --- a/tests/guix-home.sh +++ b/tests/guix-home.sh @@ -22,6 +22,11 @@ # Test the 'guix home' using the external store, if any. # +# This test is very expensive as guix-home appears to refer to the +# current-guix package, which must be built the first time it runs (~20 +# minutes on a fast machine). +test "$WITH_SLOW_TESTS" != 1 && exit 77 + set -e guix home --version diff --git a/tests/guix-package.sh b/tests/guix-package.sh index 945d59cdfb..5b9af19153 100644 --- a/tests/guix-package.sh +++ b/tests/guix-package.sh @@ -22,6 +22,11 @@ # Test the `guix package' command-line utility. # +# This test contains expensive operations such as 'guix package -A', which +# cumulate into a total test time of multiple minutes (about 2 minutes on a +# fast machine). +test "$WITH_SLOW_TESTS" != 1 && exit 77 + guix package --version readlink_base () diff --git a/tests/guix-system.sh b/tests/guix-system.sh index 99147cf332..bd343ec4bc 100644 --- a/tests/guix-system.sh +++ b/tests/guix-system.sh @@ -22,6 +22,10 @@ # Test 'guix system', mostly error reporting. # +# This test is expensive as it builds the images of multiple operating +# systems; it takes more than a minute to run on a fast machine. +test "$WITH_SLOW_TESTS" != 1 && exit 77 + set -e guix system --version diff --git a/tests/guix-time-machine.sh b/tests/guix-time-machine.sh index df75c681da..70a2443376 100644 --- a/tests/guix-time-machine.sh +++ b/tests/guix-time-machine.sh @@ -41,6 +41,8 @@ fi # Visiting a commit older than v0.16.0 must fail (this test is expensive # because it clones the whole repository). -guix time-machine -q --commit=v0.15.0 $EXTRA_OPTIONS -- describe && false +if [ "$WITH_SLOW_TESTS" = 1 ]; then + guix time-machine -q --commit=v0.15.0 $EXTRA_OPTIONS -- describe && false +fi true -- 2.46.0