From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48219) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5QHC-0003vT-7G for guix-patches@gnu.org; Tue, 02 May 2017 01:23:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d5QH9-0008Nv-0F for guix-patches@gnu.org; Tue, 02 May 2017 01:23:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:51977) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d5QH8-0008NN-T4 for guix-patches@gnu.org; Tue, 02 May 2017 01:23:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d5QH8-0000QG-KY for guix-patches@gnu.org; Tue, 02 May 2017 01:23:02 -0400 Subject: bug#26722: [PATCH 1/3] gnu: Add python-sockjs-tornado. Resent-Message-ID: References: <20170430214415.3029-1-mail@cbaines.net> <87inlkhby9.fsf@fastmail.com> <87pofsfcy3.fsf@fastmail.com> From: Christopher Baines Message-ID: <565ef392-5f03-ac11-aac2-45ed713e732e@cbaines.net> Date: Tue, 2 May 2017 06:21:56 +0100 MIME-Version: 1.0 In-Reply-To: <87pofsfcy3.fsf@fastmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RIu02exPI20jopJw7oSUhm10FRhv38Fgg" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke , 26722-done@debbugs.gnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --RIu02exPI20jopJw7oSUhm10FRhv38Fgg Content-Type: multipart/mixed; boundary="Tq8eIDIEtIHtJUPdDTejJ0dwA1qGH3Nml"; protected-headers="v1" From: Christopher Baines To: Marius Bakke , 26722-done@debbugs.gnu.org Message-ID: <565ef392-5f03-ac11-aac2-45ed713e732e@cbaines.net> Subject: Re: bug#26722: [PATCH 1/3] gnu: Add python-sockjs-tornado. References: <20170430214415.3029-1-mail@cbaines.net> <87inlkhby9.fsf@fastmail.com> <87pofsfcy3.fsf@fastmail.com> In-Reply-To: <87pofsfcy3.fsf@fastmail.com> --Tq8eIDIEtIHtJUPdDTejJ0dwA1qGH3Nml Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 01/05/17 23:07, Marius Bakke wrote: > Christopher Baines writes: >=20 >> On 01/05/17 15:46, Marius Bakke wrote: >>> Hello Chris! >>> >>> Christopher Baines writes: >>> >>>> * gnu/packages/python.scm (python-sockjs-tornado): New variable. >>> >>> [...] >>> >>>> +(define-public python-sockjs-tornado >>>> + (package >>>> + (name "python-sockjs-tornado") >>>> + (version "1.0.3") >>>> + (source >>>> + (origin >>>> + (method url-fetch) >>>> + (uri (string-append >>>> + "https://pypi.python.org/packages/source/" >>>> + "s/sockjs-tornado/sockjs-tornado-" version ".tar.gz"))= >>> >>> Please use 'pypi-uri' here. >>> >>>> + (sha256 >>>> + (base32 >>>> + "16cff40nniqsyvda1pb2j3b4zwmrw7y2g1vqq78lp20xpmhnwwkd"))))= >>>> + (build-system python-build-system) >>>> + (inputs >>>> + `(("python-tornado" ,python-tornado))) >>> >>> Python does not have a good mechanism for specifying exact versions o= f >>> runtime dependencies, so they should normally be propagated. If the >>> package does not import this at runtime (e.g. only needed for tests) = it >>> should be a 'native-input'. >>> >>> LGTM with those changes. >> >> Thanks for the review Marius, I've now sent some updated patches. >=20 > Cheers! Pushed as 99aa2dce5d376b6612aab0971985f6320c03ecd2 :) Awesome, thanks Marius :) --Tq8eIDIEtIHtJUPdDTejJ0dwA1qGH3Nml-- --RIu02exPI20jopJw7oSUhm10FRhv38Fgg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQJFBAEBCAAvFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlkIF3gRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xe7zxAAqAT8wUa1zkXXsYdtZX7cg43lmroEpmtY CW4UcPa+sJ+7R3UFpCIb8M7RQe2GlsPa/sDZI2OLdTQdcaDYVYCdl0jUbWXAVCnk h/aMsFi0R2flfEFB+SuRi+cojrDyUih2MzD3AVjGCAlIEc8OR4UVkl4FrwP2sbZg GJLJ+6b5hP3mv7BOBp6+AkZh9RPE6B8oX5yDQpsRl/mlG77vYPZoo0Ric5podVrc p2oqZHk4IgvUefcySi9wHBkmXZdoxYCi+L159+EKoTnwjHK6PA7WtF+aGNzwFdhX mYPUdR+tXwx4lcZrcDI1HVu0Uxy9/OktGkNttyIPuLTwWYfbAWrYUSpHxiRFQP3v K0yv/j7AjTF8I/Nyzj21/1lw4CcThTImNwS8HHk6qKOjBMLJmD/SiBRnVI8xBGsZ yfQU0rs8p20LBNBj3knKFbVnbU8u0QiF5h6PpSPvMfXqHe7yA8q0xB0qLbYMtZMl HESm7GPcNQDa9Rxcib3w5fZ2PLghf9ns5c+Mca42CtvCrU28b9puQ98EaJJ1t7oc S2y9wNZ6w/ROrmtQ7mnnP487aRGLsrDNGh1sphkrzEIgk00wB2bgW2prPL0d/xbB FTQWYBrCZo4wk5S0PbiO6I3tcqfORF+KJ/4S1UTxQIh8aq10te46rF/gvAoZqvxT 5ydj9bAC62A= =MaLH -----END PGP SIGNATURE----- --RIu02exPI20jopJw7oSUhm10FRhv38Fgg--