From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id SPIVLYvmP2MJRAEAbAwnHQ (envelope-from ) for ; Fri, 07 Oct 2022 10:42:51 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 4AcxLYvmP2MuXgEA9RJhRA (envelope-from ) for ; Fri, 07 Oct 2022 10:42:51 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7735C211B7 for ; Fri, 7 Oct 2022 10:42:51 +0200 (CEST) Received: from localhost ([::1]:33152 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ogiwP-0000p4-Qa for larch@yhetil.org; Fri, 07 Oct 2022 04:42:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53712) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogivj-0000ZO-Kn for bug-guix@gnu.org; Fri, 07 Oct 2022 04:42:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35234) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ogivi-00026B-5H for bug-guix@gnu.org; Fri, 07 Oct 2022 04:42:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ogivi-0006ji-0N for bug-guix@gnu.org; Fri, 07 Oct 2022 04:42:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#28510: crash: guix build -S foo --with-source=bla Resent-From: jeremy@korwin-zmijowski.fr Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 07 Oct 2022 08:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28510 X-GNU-PR-Package: guix X-GNU-PR-Keywords: easy To: Josselin Poiret Cc: 28510@debbugs.gnu.org, Maxime Devos , zimoun Received: via spool by 28510-submit@debbugs.gnu.org id=B28510.166513211925886 (code B ref 28510); Fri, 07 Oct 2022 08:42:01 +0000 Received: (at 28510) by debbugs.gnu.org; 7 Oct 2022 08:41:59 +0000 Received: from localhost ([127.0.0.1]:34312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ogivf-0006jS-F3 for submit@debbugs.gnu.org; Fri, 07 Oct 2022 04:41:59 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:42355) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ogivd-0006jE-P5 for 28510@debbugs.gnu.org; Fri, 07 Oct 2022 04:41:58 -0400 Received: (Authenticated sender: jeremy@korwin-zmijowski.fr) by mail.gandi.net (Postfix) with ESMTPA id 709FB100005; Fri, 7 Oct 2022 08:41:50 +0000 (UTC) MIME-Version: 1.0 Date: Fri, 07 Oct 2022 10:41:50 +0200 From: jeremy@korwin-zmijowski.fr In-Reply-To: <87h7113k9a.fsf@jpoiret.xyz> References: <229c1399-ce4b-b942-1bae-deea501f1c48@telenet.be> <87k05y2yjc.fsf@jpoiret.xyz> <86a66u0xhr.fsf@gmail.com> <87h7113k9a.fsf@jpoiret.xyz> Message-ID: <565ee080af7ef230e1c769bcfed440c2@korwin-zmijowski.fr> X-Sender: jeremy@korwin-zmijowski.fr Content-Type: multipart/mixed; boundary="=_13936658fabfd420a0433caa4296d0b9" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1665132171; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=DSOAfpgoFb7EbSPFpwXZmmuZeHxRoTmwa6QpzTISSZo=; b=W0tmE+f0568UgBlNwgcBNgVRtHA0+UDEhHal2Pn41m1EOxGu4Tf6uC/DVoe94y3+DYtbeB PjgZA8o7zpqQiZmjeX/47mgEBtcgl2idT/Ignpe3ophdS/CtMeIvHEVkq/8upX9FR0k1B1 +BOiPezMsKPV8a7PHHs7Zc2zslSZ2Q6eZ2Yj88RpCOzD1w8NGQUyfdxbM/8WMfpCJyL8Bc 7SqgaRiSOALsyyzCNRpLhM0EBto7ibOOEIOWyQVaxZmNBIlLAmeX8bvukAB+BpFUyyVymr 7ZwAHIG81pZT5bVD4evTBZEjG0fGYqPtDy8Cx2nStLKhqhcJ9GpHGWBa7mc8eA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1665132171; a=rsa-sha256; cv=none; b=Me0+Y/2gT6UJbclirUWF7F3qZbnr84kJcICpcNS6qwsW8C+M8nqe5MUtunVcAjxnIMAYAE E3kllPuI8qj8Q+GN+rM2p///U4OdNvCfZXKmrTA7DCVclT4RGT6qyx5rQmNzgrchdtzrKB aHUqB5KzDwqICpi9Hjmx/BGJGS+vdBkSKxohbQGjdhkfZEEOXcGezPS1SK50pX7zSMykGf jUQkr9zi6p5Yl5q0zN4yhydU4zUK94X/WOBNLk4uyX6O6TuKrZ+/fab3/jdok5R5ROUbmc YuUy850rd0eogyuQFyx34zv+T42GBgH4jbquVkbEsrVvT+HOPOhF6N4EUFGKCg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 0.73 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 7735C211B7 X-Spam-Score: 0.73 X-Migadu-Scanner: scn0.migadu.com X-TUID: JFAeGHuDBeJL --=_13936658fabfd420a0433caa4296d0b9 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8; format=flowed Le 2022-09-20 21:42, Josselin Poiret a écrit : > Hi Simon, > > zimoun writes: > >> Well, I would add an error handler; as proposed [1]. :-) Because does >> “guix build foo --source --with-source=bla” make sense? What is the >> use-case for such command? > > My bad, I didn't see the previous discussion on the subject. To me, > the > lack of generality would be unexpected: if I have a package with a > source, I expect to be able to get that source, whatever the source may > be. Maxime's minimal example shows that it could happen for a variety > of different reasons, not just a --with-source= flag. I don't know > what > a proper fix for it would be though, since we're passing things around > that we pretend are derivations but are not, and in many places. > > Best, Hi ! I feel not able to take decision about the proper way right now. So as a step forward I wrote a test to capture the behavior expected. Please have a look at it as it's the starting point for me. Next, I can implement the error handler, making the previous test to pass. As the test checks the behaviour, it will let enough space to change implementation later without invalitating the test. Cheers, Jérémy --=_13936658fabfd420a0433caa4296d0b9 Content-Transfer-Encoding: base64 Content-Type: text/plain; name=guix-scripts.scm Content-Disposition: attachment; filename=guix-scripts.scm; size=930 KGRlZmluZS1tb2R1bGUgKHRlc3RzIHNjcmlwdHMgYnVpbGQpCiAgIzp1c2UtbW9kdWxlIChzcmZp IHNyZmktNjQpCiAgIzp1c2UtbW9kdWxlIChpY2UtOSBleGNlcHRpb25zKQogICM6dXNlLW1vZHVs ZSAoZ3VpeCBzY3JpcHRzIGJ1aWxkKQogICM6dXNlLW1vZHVsZSAoc3JmaSBzcmZpLTM0KSkKCih0 ZXN0LWJlZ2luICJzY3JpcHRzIikKCihkZWZpbmUgRFVNTVlfREVGSU5JVElPTl9QQVRIICIvdG1w L2Euc2NtIikKCihkZWZpbmUgKGNyZWF0ZS1kdW1teS1kZWZpbml0aW9uKQogIChjYWxsLXdpdGgt b3V0cHV0LWZpbGUgRFVNTVlfREVGSU5JVElPTl9QQVRICiAgICAobGFtYmRhIChwb3J0KQogICAg ICAoZm9ybWF0IHBvcnQKICAgICAgICAgICAgICAiKHVzZS1tb2R1bGVzIChnbnUgcGFja2FnZXMp IChndWl4IHBhY2thZ2VzKSAoZ3VpeCBnZXhwKSkgKHBhY2thZ2UgKGluaGVyaXQgKHNwZWNpZmlj YXRpb24tPnBhY2thZ2UgXCJoZWxsb1wiKSkgKHNvdXJjZSAobG9jYWwtZmlsZSBcImEuc2NtXCIp KSkiKSkpKQoKKGRlZmluZSAoZGVsZXRlLWR1bW15LWRlZmluaXRpb24pCiAgKGRlbGV0ZS1maWxl IERVTU1ZX0RFRklOSVRJT05fUEFUSCkpCgoodGVzdC1ncm91cC13aXRoLWNsZWFudXAgImJ1aWxk IgoKICAoY3JlYXRlLWR1bW15LWRlZmluaXRpb24pCgogICh0ZXN0LWVxdWFsICJwYWNrYWdlIGRl ZmluaXRpb24gYXMgb25seSBzb3VyY2UiCiAgICAiL2dudS9zdG9yZS83bW5rcmc5Ym15Ymd5ZjFk bjVuNjdkaTZuZzZxdmhrei1hLnNjbSIKICAgIChndWFyZAogICAgICAgIChleAogICAgICAgICAo KGV4Y2VwdGlvbj8gZXgpICNmKSkKICAgICAgKGd1aXgtYnVpbGQgIi1mIiBEVU1NWV9ERUZJTklU SU9OX1BBVEggIi0tc291cmNlIikpKQoKICAoZGVsZXRlLWR1bW15LWRlZmluaXRpb24pKQoKKHRl c3QtZW5kICJzY3JpcHRzIikK --=_13936658fabfd420a0433caa4296d0b9--