From: Ben Woodcroft <b.woodcroft@uq.edu.au>
To: Chris Marusich <cmmarusich@gmail.com>,
"guix-devel@gnu.org" <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: Add python-contextlib2
Date: Wed, 18 Nov 2015 22:55:37 +1000 [thread overview]
Message-ID: <564C7549.3070707@uq.edu.au> (raw)
In-Reply-To: <CAEKzfHki1Nq01yUrDf08gFfc+dxahS2kBcoqwhn_1zWWt8Lq8w@mail.gmail.com>
Hi there.
On 18/11/15 18:31, Chris Marusich wrote:
> Hi,
>
> I've packaged contextlib2. This is my first submission, so please let
> me know if there is anything that should be different about the
> changes I've made. Also, if there's anything odd about the way I've
> formatted these patches or this email, please let me know so I can
> correct it next time.
If I'm understanding correctly, the sole purpose of the patch is to make
the tests run. In that case, I think it might be simpler to replace the
check phase like so?
(build-system python-build-system)
(arguments
`(#:phases
(modify-phases %standard-phases
(replace 'check
(lambda _ (system* "python" "test_contextlib2.py", "-v"))))))
Thanks for the contribution. I second Andreas' welcome.
ben
next prev parent reply other threads:[~2015-11-18 12:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 8:31 [PATCH] gnu: Add python-contextlib2 Chris Marusich
2015-11-18 8:46 ` Andreas Enge
2015-11-18 8:46 ` Chris Marusich
2015-11-18 12:55 ` Ben Woodcroft [this message]
2015-11-21 21:28 ` Chris Marusich
2015-11-26 13:44 ` Ludovic Courtès
2015-12-01 8:22 ` Chris Marusich
2015-12-06 21:49 ` Ludovic Courtès
2015-12-08 5:14 ` Chris Marusich
2015-12-13 23:16 ` Ludovic Courtès
2015-12-14 2:15 ` Chris Marusich
2015-12-14 8:44 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564C7549.3070707@uq.edu.au \
--to=b.woodcroft@uq.edu.au \
--cc=cmmarusich@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.