From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id EO1ILWq8smYHNgAAe85BDQ:P1 (envelope-from ) for ; Wed, 07 Aug 2024 00:14:34 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id EO1ILWq8smYHNgAAe85BDQ (envelope-from ) for ; Wed, 07 Aug 2024 02:14:34 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="RHoXWJ/i"; dkim=fail ("headers rsa verify failed") header.d=lunabee.space header.s=purelymail3 header.b=NmLvdNLD; dkim=fail ("headers rsa verify failed") header.d=purelymail.com header.s=purelymail3 header.b=rZdcFbyc; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1722989674; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=t3putvifLmBtxRMBIO2MkhAQkvsLpbOrET+GfLPM8+U=; b=OpoDtfoI3PzZJfYlhLmhzk3qjZ9jy/CNjOpgMETmM2j6JA79eYhr0lJKWIvLp9g+hD+Nzf Pruv7kvZXgutHCr+HYfCcgjnCGiMkvKgHzXXiN8D3eSRgI1GMUI7zaVu9sqlSSzNwh/txY O0m3YsKHarQal0G7h6FNtxkgTNyWrzoqma6gq4RzD3QcdVeW9TrhU0JswtEh7bLkn103SK gk+vuiZ+xIx2Txf4ZaqsmVLp3cLxBFZBrscP0lipZ41Lvp6p3fM10w8l67r9y5+lkLaZFg NwzPa3v2FLY5yEfUs9iFnrGgvSJO9Hv+o5c2vitXw6nwZ3iLsVCGPlwI3aNWFA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="RHoXWJ/i"; dkim=fail ("headers rsa verify failed") header.d=lunabee.space header.s=purelymail3 header.b=NmLvdNLD; dkim=fail ("headers rsa verify failed") header.d=purelymail.com header.s=purelymail3 header.b=rZdcFbyc; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1722989674; a=rsa-sha256; cv=none; b=W/0GWYfzF6dikSR338aYworBHWKaySTPLJQ6zMd2mpMVXDLt/EQxsTbm1h8uMRrkWoacq8 88ko0vV0Aug7EPhEsrY5UJFCsfKWUOhOPgze9p+ySeeLxFywOLTda44P1ntEpvntwclcE+ jFFIzmAr8zeHAxV1MoVK+tnLurHYztSqc7cqK+4u+EbC+DKoGOYwJamuwtB17HaZ4Rp5jw 4VcEvYdVwjRE+UZC6zA+8ohHehq6ZsAcVXsm5zaEoLVu8OhuhjsfUQObG7HRiU2pUsGhZQ l+KsAOBLjmDsgct1RyZa02UcVF/nKVSbJt+uaSKaTYXCmdHndNebOLLfv4hmIg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7EBA256248 for ; Wed, 7 Aug 2024 02:14:34 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sbUJL-0004nM-IP; Tue, 06 Aug 2024 20:13:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbUJD-0004Fk-KQ for guix-patches@gnu.org; Tue, 06 Aug 2024 20:13:43 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sbUJA-00025C-B5 for guix-patches@gnu.org; Tue, 06 Aug 2024 20:13:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:Date:From:To:Subject; bh=t3putvifLmBtxRMBIO2MkhAQkvsLpbOrET+GfLPM8+U=; b=RHoXWJ/it9mlTV8CATYGbskz9ABasRgMa5UF38uaxlomB5WGRnZlhzgwyM73GSJ4zVOY7dCcbkfar1IYEdltQFZu6isxtqd7KLNA+Mt69BQORuFEFRdsoat00N7igcd2xPpvFxpid1bQeICQh5QNj6FNjiV/kIlor+QnvVloSkFMNfrdUI+8/B6KV/b3L2TRA+Luofdr40E4f6JCqe1uCfltta3/s5hzVGfNHKvn+56IRlbiK4gZzLaza7JWNtKC0asCY/jugfFY9r297csyPmfh2NQZ3bWJcbiK3+ybW1CracACvX/ITkNnLTE+K7LH9T+jlvrhWitbRKtnbPZDWw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sbUJY-0006xe-Dq for guix-patches@gnu.org; Tue, 06 Aug 2024 20:14:04 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72457] [PATCH v5 05/15] gnu: system: Remove useless boot parameters. Resent-From: Lilah Tascheter Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 07 Aug 2024 00:14:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72457 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 72457@debbugs.gnu.org Cc: Lilah Tascheter , Sergey Trofimov Received: via spool by 72457-submit@debbugs.gnu.org id=B72457.172298963326644 (code B ref 72457); Wed, 07 Aug 2024 00:14:04 +0000 Received: (at 72457) by debbugs.gnu.org; 7 Aug 2024 00:13:53 +0000 Received: from localhost ([127.0.0.1]:33235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbUJM-0006va-J7 for submit@debbugs.gnu.org; Tue, 06 Aug 2024 20:13:53 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:55746) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbUJG-0006ua-4v for 72457@debbugs.gnu.org; Tue, 06 Aug 2024 20:13:46 -0400 DKIM-Signature: a=rsa-sha256; b=NmLvdNLDclYP7toTvA6HGUEmiKaQeu86dhzSbAVpcgjSvTjxRcRWX017FMl7wfF5aGlSmbCLzISIiSW5ls8b+cuoSIZAu0HH3nI5MDNHCVlQdJC37VDMfFaBS3UgVCD9hBFZGx/9ymBLTo42X6PytNuQv0NYaucmIUVhe9mGEhGyElMujaijqq+KxiEr1Px5slcO4vsQlbO3uQycyu9ATAWF4zlRCVbyFXs7DAYBsIaOLpPwiLHi8v69/PMAu9yja3f+826NoU6Px6RRUckui4eXcGs/JP+V18BswKJRz4ZrUsK45G2zY6dhvj5nz6O6JxiPEa1tARl8LzQMmqqt0w==; s=purelymail3; d=lunabee.space; v=1; bh=ol1uWhvcd6jg8jrl+jAW7wdPNF/rhebpv51yL/ZJ3vU=; h=Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=rZdcFbycLiSQnl/DTm6J06NbZAVBXS8aNUvdPaOJMlb3pfDJOTFki0c7cgBEdVlsfwoUF4UoGeHMX/M9K9tdla88Gqk4PGLNUUjFxRsF5ZFJQAD++yiRFbK6SdTcv6yPqtzgOrup2xvTHybtyStukkHUPlbRhoXFHYSnd7I5KLvssY0DmHCn1Z73g4D/RWp49ZcXGSTI1Pisfa4WoteCFsSvLMp3cwWenApC6EK9iQkrCOtrQTbBQd6YH9cgc8jK/mgq2bQ6QG7zXo8qYPAbp9s8buYzzIBwVXjAXcsZ/nVS8CNipi5Y9lyXDYHZN2gJke2K5GBG1N9y+eekc/+oJg==; s=purelymail3; d=purelymail.com; v=1; bh=ol1uWhvcd6jg8jrl+jAW7wdPNF/rhebpv51yL/ZJ3vU=; h=Feedback-ID:Received:From:To:Subject:Date; Feedback-ID: 8937:2070:null:purelymail X-Pm-Original-To: 72457@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -1661201426; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 07 Aug 2024 00:13:11 +0000 (UTC) Date: Tue, 6 Aug 2024 19:11:18 -0500 Message-ID: <563ee3659ab7cae85c859a6c95211564e6eef37d.1722989488.git.lilah@lunabee.space> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by Purelymail Content-Type: text/plain; charset=UTF-8 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Lilah Tascheter via Guix-patches Reply-To: Lilah Tascheter Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 7EBA256248 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -6.94 X-Spam-Score: -6.94 X-TUID: pFHR1Ash1kAo * gnu/system.scm (operating-system-boot-parameters, operating-system-boot-parameters-file): Delete bootloader-menu-entries. * gnu/system/boot.scm (boot-parameters)[bootloader-menu-entries]: Delete fields. (read-boot-parameters): Don't read bootloader-menu-entries. * tests/boot-parameters.scm (%grub-boot-parameters, test-read-boot-parameters, test-read-boot-parameters): Don't include bootloader-menu-entries. ("read, bootloader-menu-entries, default value"): Delete test. Change-Id: I46d9cff4604dbfcf654b0820fdb77e72aecffbb4 --- gnu/system.scm | 7 ------- gnu/system/boot.scm | 8 -------- tests/boot-parameters.scm | 14 ++------------ 3 files changed, 2 insertions(+), 27 deletions(-) diff --git a/gnu/system.scm b/gnu/system.scm index a345b52d55..66c1a80733 100644 --- a/gnu/system.scm +++ b/gnu/system.scm @@ -1304,8 +1304,6 @@ (define* (operating-system-boot-parameters os root-de= vice (initrd initrd) (multiboot-modules multiboot-modules) (bootloader-name bootloader-name) - (bootloader-menu-entries - (bootloader-configuration-menu-entries (operating-system-bootloader = os))) (locale locale) (store-device (ensure-not-/dev (file-system-device store))) (store-directory-prefix (btrfs-store-subvolume-file-name file-systems= )) @@ -1347,11 +1345,6 @@ (define* (operating-system-boot-parameters-file os) #$(boot-parameters-multiboot-modules param= s))) #~()) (bootloader-name #$(boot-parameters-bootloader-name p= arams)) - (bootloader-menu-entries - #$(map menu-entry->sexp - (or (and=3D> (operating-system-bootloader os) - bootloader-configuration-menu-entr= ies) - '()))) (locale #$(boot-parameters-locale params)) (store (device diff --git a/gnu/system/boot.scm b/gnu/system/boot.scm index 2b5302ce5f..4d89827ced 100644 --- a/gnu/system/boot.scm +++ b/gnu/system/boot.scm @@ -54,7 +54,6 @@ (define-module (gnu system boot) boot-parameters-label boot-parameters-root-device boot-parameters-bootloader-name - boot-parameters-bootloader-menu-entries boot-parameters-store-crypto-devices boot-parameters-store-device boot-parameters-store-directory-prefix @@ -113,8 +112,6 @@ (define-record-type* ;; partition. (root-device boot-parameters-root-device) (bootloader-name boot-parameters-bootloader-name) - (bootloader-menu-entries ;list of - boot-parameters-bootloader-menu-entries) (store-device boot-parameters-store-device) (store-mount-point boot-parameters-store-mount-point) (store-directory-prefix boot-parameters-store-directory-prefix) @@ -176,11 +173,6 @@ (define (read-boot-parameters port) ((_ args) (list args)) (#f 'grub))) ; for compatibility reasons. =20 - (bootloader-menu-entries - (match (assq 'bootloader-menu-entries rest) - ((_ entries) (map sexp->menu-entry entries)) - (#f '()))) - ;; In the past, we would store the directory name of linux instead o= f ;; the absolute file name of its image. Detect that and correct it. (kernel (if (string=3D? kernel (direct-store-path kernel)) diff --git a/tests/boot-parameters.scm b/tests/boot-parameters.scm index 2e7976aa6c..f214de360d 100644 --- a/tests/boot-parameters.scm +++ b/tests/boot-parameters.scm @@ -64,7 +64,6 @@ (define %root-path "/") (define %grub-boot-parameters (boot-parameters (bootloader-name 'grub) - (bootloader-menu-entries '()) (root-device %default-root-device) (label %default-label) (kernel %default-kernel) @@ -107,7 +106,6 @@ (define* (test-read-boot-parameters #:key (version %boot-parameters-version) (bootloader-name 'grub) - (bootloader-menu-entries '()) (label %default-label) (root-device (quote-uuid %default-root-device)) (kernel %default-kernel) @@ -127,7 +125,7 @@ (define* (test-read-boot-parameters (cond ((eq? 'false val) (format #false fmt #false)) (val (format #false fmt val)) (else ""))) - (format #false "(boot-parameters~a~a~a~a~a~a~a~a~a~a)" + (format #false "(boot-parameters~a~a~a~a~a~a~a~a~a)" (sexp-or-nothing " (version ~S)" version) (sexp-or-nothing " (label ~S)" label) (sexp-or-nothing " (root-device ~S)" root-device) @@ -145,9 +143,7 @@ (define* (test-read-boot-parameters store-crypto-devices)) "") (sexp-or-nothing " (locale ~S)" locale) - (sexp-or-nothing " (bootloader-name ~a)" bootloader-name) - (sexp-or-nothing " (bootloader-menu-entries ~S)" - bootloader-menu-entries))) + (sexp-or-nothing " (bootloader-name ~a)" bootloader-name))) (let ((str (generate-boot-parameters))) (call-with-input-string str read-boot-parameters))) =20 @@ -170,7 +166,6 @@ (define* (test-read-boot-parameters =20 (test-assert "read, construction, optional fields" (and (test-read-boot-parameters #:bootloader-name #false) - (test-read-boot-parameters #:bootloader-menu-entries #false) (test-read-boot-parameters #:kernel-arguments #false) (test-read-boot-parameters #:with-store #false) (test-read-boot-parameters #:store-device #false) @@ -223,11 +218,6 @@ (define* (test-read-boot-parameters (boot-parameters-bootloader-name (test-read-boot-parameters #:bootloader-name #false))) =20 -(test-eq "read, bootloader-menu-entries, default value" - '() - (boot-parameters-bootloader-menu-entries - (test-read-boot-parameters #:bootloader-menu-entries #false))) - (test-eq "read, kernel-arguments, default value" '() (boot-parameters-kernel-arguments --=20 2.45.2