From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Carlos O'Donell" <carlos@redhat.com>
Subject: Re: [PATCH] Gracefully handle incompatible locale data
Date: Wed, 28 Oct 2015 02:19:33 -0400
Message-ID: <563068F5.3000705@redhat.com>
References: <876132lbic.fsf@gnu.org>
 <20151027153037.GB2483@var.bordeaux.inria.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Return-path: <libc-alpha-return-64603-glibc-alpha=m.gmane.org@sourceware.org>
List-Unsubscribe: <mailto:libc-alpha-unsubscribe-glibc-alpha=m.gmane.org@sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
In-Reply-To: <20151027153037.GB2483@var.bordeaux.inria.fr>
To: Samuel Thibault <samuel.thibault@gnu.org>, =?UTF-8?Q?Ludovic_Court=c3=a8?= =?UTF-8?Q?s?= <ludo@gnu.org>
Cc: libc-alpha@sourceware.org, guix-devel@gnu.org
List-Id: guix-devel.gnu.org

On 10/27/2015 11:30 AM, Samuel Thibault wrote:
> Hello,
> 
> Ludovic Courtès, le Tue 22 Sep 2015 17:27:55 +0200, a écrit :
>>   loadlocale.c:130: _nl_intern_locale_data: Assertion `cnt < (sizeof (_nl_value_type_LC_COLLATE) / sizeof (_nl_value_type_LC_COLLATE[0]))' failed.
>>
>> This patch changes such conditions to return EINVAL instead of aborting.
> 
> Just like it does for the __glibc_unlikely (idx > (size_t)
> newdata->filesize) test above, so it doesn't actually introduce any new
> error condition.
> 
> I thus commited the change, thanks!
> 
> Samuel
> 

Thanks Samuel!

c.