From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id 0KHNH+k2DWYOSQEAqHPOHw:P1 (envelope-from ) for ; Wed, 03 Apr 2024 13:00:57 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id 0KHNH+k2DWYOSQEAqHPOHw (envelope-from ) for ; Wed, 03 Apr 2024 13:00:57 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1712142057; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=WmMt1ARx2cO7K1KNUKTZIBLoFFozVjSRVs5yOxz4+ss=; b=GdcPQQlxZdcQAUOyvv0xZAUMpCJLJbQPTHP+nQO4A/N4Jhmlsp3icHTDmFVuauwdnjbiaJ WHYdiEdeGghTBGS3/0JS8wzXQ2afkcuWiMqSXgYMjYfJ3SrTM0lh4MswdBpzcm5Eg/o3nw IC1G6gh5xQJGNeUMbIYUFetj0ceD/27i3zv9rAwGITc19REEUXZlwwCvCbTUk46aexxsP4 BI/WUnbNYUitP55Hm7riBBvFyxb/4gmqCepWjo1wEsX9jS8gpo/2/zqhyTQFpn4fcqNB3t ehqsVCMNQG32AghTXssNx1KG86tiRG2NaNHUmQRxJlNbJ6nqLg0pfKLL7cnbeQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1712142057; a=rsa-sha256; cv=none; b=erYPs82NPkve1Z5Nf7sVrsHkgjNLv71RlXxMKHEbgIXFXlEj2Xaqi24M37MTk02GukNi60 XAg+9QFv7ZSM1FvR68RosN7QDkqRyRNRNHR2FuqHbUHYggAUK71Bcg5RACxA8ICX0yLs+J 16Mlf0fdCzcNpDcMc601ne0dFlqNHOHNeIy5UibT6G5Xlcq1mUmIQIQAZx6U6PhZqayrOC lYvTEnrf9nEbZHKukN/C4A+SfMBvJZ6cvZzPfKteSNyEjLAq+2CMAEuYh8uT6wYVk0wN/k xIzYYLf9CWRBVn/Bi0z/6nybMyItEyrPdQb3w9LodSz7R5pDpwKzqOu6uhHVcA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 382443C07B for ; Wed, 3 Apr 2024 13:00:57 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rryLt-0004Vu-T1; Wed, 03 Apr 2024 07:00:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rryLr-0004U4-9h for guix-devel@gnu.org; Wed, 03 Apr 2024 07:00:19 -0400 Received: from vmi993448.contaboserver.net ([194.163.141.236] helo=mutix.org) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rryLp-0001Qe-Al for guix-devel@gnu.org; Wed, 03 Apr 2024 07:00:19 -0400 Received: from [192.168.1.172] (host81-147-82-218.range81-147.btcentralplus.com [81.147.82.218]) (Authenticated sender: cdo) by mutix.org (Postfix) with ESMTPSA id 71022A62D29; Wed, 3 Apr 2024 13:00:11 +0200 (CEST) Message-ID: <55f9be63-419e-57ba-7bd8-691cf80ab012@mutix.org> Date: Wed, 3 Apr 2024 12:00:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: Coordinators for patch review session on Tuesday Content-Language: en-US To: Steve George Cc: guix-devel , efraim@flashner.co.il References: From: Christina O'Donnell In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=194.163.141.236; envelope-from=cdo@mutix.org; helo=mutix.org X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.802, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.93 X-Spam-Score: -3.93 X-Migadu-Queue-Id: 382443C07B X-Migadu-Scanner: mx13.migadu.com X-TUID: nJjaqSJpm+WI Hi Steve, On 02/04/2024 21:23, Steve George wrote: > Hi Christina - thanks for coming along today - I hope it was useful. Yes I did find it helpful. Since I'm the least experienced out of everyone there, I just stayed quiet and tried to absorb as much as I could. It was good to see that not everyone was using Emacs, and I'm going to try to start using Efraim's vi script for GTAGS in Guile. > There's good instructions on the Wiki on how to review patches: > > https://libreplanet.org/wiki?title=Group:Guix/PatchReviewSessions2024 > > I would love feedback on how to improve them! > > There's plenty of patches to review, I've been keeping a list of them for the patch review calls: > > https://debbugs.gnu.org/cgi-bin/pkgreport.cgi?tag=patch-review-hackers-list;users=guix > > And the wiki page references some other reports. > > Please pick some patches and have a go - if you want someone else to look at them feel free to ping here or on IRC! Thank you for writing this up in so much depth! I've reviewed [1] and tried to tag it as reviewed-looks-good, though I don't think that has gone through. If you or someone else could take a look at it then I'd appreciate that. I plan on reviewing some more patches this evening. Kind regards, Christina [1] https://debbugs.gnu.org/cgi-bin/bugreport.cgi?users=guix;bug=65938