* [PATCH 2/2] gnu: Add ruby-simplecov.
@ 2015-09-16 4:06 Pjotr Prins
2015-09-16 9:34 ` Ricardo Wurmus
0 siblings, 1 reply; 3+ messages in thread
From: Pjotr Prins @ 2015-09-16 4:06 UTC (permalink / raw
To: guix-devel
* gnu/packages/ruby.scm (ruby-simplecov): New variable.
---
gnu/packages/ruby.scm | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 539b00b..2f7f89c 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -1147,6 +1147,34 @@ Ruby objects in a snap.")
(home-page "https://ms-ati.github.io/docile/")
(license license:expat)))
+(define-public ruby-simplecov
+(package
+ (name "ruby-simplecov")
+ (version "0.10.0")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (rubygems-uri "simplecov" version))
+ (sha256
+ (base32
+ "1q2iq2vgrdvvla5y907gkmqx6ry2qvnvc7a90hlcbwgp1w0sv6z4"))))
+ (build-system ruby-build-system)
+ (propagated-inputs
+ `(("ruby-docile" ,ruby-docile)
+ ("ruby-json" ,ruby-json)))
+ (arguments
+ '(#:tests? #f)) ; needs github-markup, among others
+ (synopsis "Code coverage for Ruby")
+ (description "Code coverage analysis tool for Ruby. It uses Ruby's
+built-in Coverage library to gather code coverage data, but makes
+processing its results much easier by providing a clean API to filter,
+group, merge, format, and display those results, giving you a complete
+code coverage suite that can be set up with just a couple lines of
+code.
+")
+ (home-page "http://github.com/colszowka/simplecov")
+ (license license:expat)))
+
(define-public ruby-gherkin3
(package
(name "ruby-gherkin3")
--
2.4.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] gnu: Add ruby-simplecov.
2015-09-16 4:06 [PATCH 2/2] gnu: Add ruby-simplecov Pjotr Prins
@ 2015-09-16 9:34 ` Ricardo Wurmus
2015-09-17 5:20 ` Pjotr Prins
0 siblings, 1 reply; 3+ messages in thread
From: Ricardo Wurmus @ 2015-09-16 9:34 UTC (permalink / raw
To: Pjotr Prins; +Cc: guix-devel
Hi Pjotr,
> * gnu/packages/ruby.scm (ruby-simplecov): New variable.
[...]
> + (propagated-inputs
> + `(("ruby-docile" ,ruby-docile)
> + ("ruby-json" ,ruby-json)))
> + (arguments
> + '(#:tests? #f)) ; needs github-markup, among others
> + (synopsis "Code coverage for Ruby")
I find it very surprising to see only “docile” and “json” as inputs and
not “ruby-simplecov-html”. According to
https://rubygems.org/gems/simplecov “simplecov-html” is a runtime
dependency.
With my Ruby packages I’ve been closely following the dependencies as
they are declared on rubygems.org.
I’ve sent a patch to add “ruby-simplecov-html” to the ML a couple of
minutes ago, so maybe you could update your patch and add it as an
input.
> + (description "Code coverage analysis tool for Ruby. It uses Ruby's
> +built-in Coverage library to gather code coverage data, but makes
> +processing its results much easier by providing a clean API to filter,
> +group, merge, format, and display those results, giving you a complete
> +code coverage suite that can be set up with just a couple lines of
> +code.
> +")
The closing quote and the closing parenthesis should be on the same line
as the period. The rest looks good to me.
~~ Ricardo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] gnu: Add ruby-simplecov.
2015-09-16 9:34 ` Ricardo Wurmus
@ 2015-09-17 5:20 ` Pjotr Prins
0 siblings, 0 replies; 3+ messages in thread
From: Pjotr Prins @ 2015-09-17 5:20 UTC (permalink / raw
To: Ricardo Wurmus; +Cc: guix-devel
The dependency is only for those cases that use HTML output. I am
using it for cucumber which don't needs it. Feel free to put in the
dependency. And push it.
Pj.
On Wed, Sep 16, 2015 at 11:34:18AM +0200, Ricardo Wurmus wrote:
> Hi Pjotr,
>
> > * gnu/packages/ruby.scm (ruby-simplecov): New variable.
>
> [...]
>
> > + (propagated-inputs
> > + `(("ruby-docile" ,ruby-docile)
> > + ("ruby-json" ,ruby-json)))
> > + (arguments
> > + '(#:tests? #f)) ; needs github-markup, among others
> > + (synopsis "Code coverage for Ruby")
>
> I find it very surprising to see only “docile” and “json” as inputs and
> not “ruby-simplecov-html”. According to
> https://rubygems.org/gems/simplecov “simplecov-html” is a runtime
> dependency.
>
> With my Ruby packages I’ve been closely following the dependencies as
> they are declared on rubygems.org.
>
> I’ve sent a patch to add “ruby-simplecov-html” to the ML a couple of
> minutes ago, so maybe you could update your patch and add it as an
> input.
>
> > + (description "Code coverage analysis tool for Ruby. It uses Ruby's
> > +built-in Coverage library to gather code coverage data, but makes
> > +processing its results much easier by providing a clean API to filter,
> > +group, merge, format, and display those results, giving you a complete
> > +code coverage suite that can be set up with just a couple lines of
> > +code.
> > +")
>
> The closing quote and the closing parenthesis should be on the same line
> as the period. The rest looks good to me.
>
> ~~ Ricardo
>
--
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-17 5:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-16 4:06 [PATCH 2/2] gnu: Add ruby-simplecov Pjotr Prins
2015-09-16 9:34 ` Ricardo Wurmus
2015-09-17 5:20 ` Pjotr Prins
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.