From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Woodcroft Subject: Re: [PATCH] gnu: Add python-xlrd. Date: Sun, 20 Sep 2015 10:48:59 +1000 Message-ID: <55FE027B.2000306@uq.edu.au> References: <55FD6561.8050608@uq.edu.au> <87k2rmflyv.fsf@openmailbox.org> <87si6a5fzf.fsf@mdc-berlin.de> <877fnmno1v.fsf@openmailbox.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36886) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZdSoW-0005zr-TO for guix-devel@gnu.org; Sat, 19 Sep 2015 20:49:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZdSoT-0004TD-NB for guix-devel@gnu.org; Sat, 19 Sep 2015 20:49:08 -0400 Received: from mailhub1.soe.uq.edu.au ([130.102.132.208]:59910 helo=newmailhub.uq.edu.au) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZdSoT-0004Q7-4b for guix-devel@gnu.org; Sat, 19 Sep 2015 20:49:05 -0400 In-Reply-To: <877fnmno1v.fsf@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Mathieu Lirzin , Ricardo Wurmus Cc: "guix-devel@gnu.org" On 20/09/15 06:37, Mathieu Lirzin wrote: > Ricardo Wurmus writes: > >> Mathieu Lirzin writes: >> >>>> + ;; so use nose to run tests instead for now. >>>> + (replace 'check (lambda _ (zero? (system* "nosetests")))))= )) >>>> + (native-inputs >>>> + `(("python-setuptools" ,python2-setuptools) >>>> + ("python-nose" ,python2-nose))) >>> I don't know python packaging but when I look at other packages it >>> seems that these are usually used as =E2=80=9Cinputs=E2=80=9D not >>> =E2=80=9Cnative-inputs=E2=80=9D. >> Nose is used for the tests only and setuptools is used at build time, = so >> I think it=E2=80=99s fine like this. > Is this a general statement or something specific to this package? If > this is general it seems to be a good idea to make a big commit that > fixes all the python packages which use these dependencies as normal > inputs? WDYT? If someone were to change things wholesale, it might also be a good idea=20 to change the pypi importer to match. Let me know when you want me to send an updated patch - all your=20 comments look good to me Marthieu. ben