From: Ben Woodcroft <b.woodcroft@uq.edu.au>
To: Andreas Enge <andreas@enge.fr>,
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>
Subject: Re: [PATCH] Add MAFFT.
Date: Sat, 12 Sep 2015 22:20:11 +1000 [thread overview]
Message-ID: <55F4187B.8020804@uq.edu.au> (raw)
In-Reply-To: <20150907085519.GA4513@debian>
[-- Attachment #1: Type: text/plain, Size: 805 bytes --]
On 07/09/15 18:55, Andreas Enge wrote:
> On Tue, Aug 25, 2015 at 10:58:42PM +0200, Ludovic Courtès wrote:
>> It seems this message was left unanswered. Andreas?
> I had a cursory look at the patch, here are some comments:
>
> [..]
>> +protein sequences. For instance, it offers L-INS-i (accurate; for alignment
>> +of <???200 sequences) and FFT-NS-2 (fast; for alignment of <???30,000
> Is this an artefact of the mailer?
>
> I did not check whether the package passes "guix lint".
>
> Could you send an updated patch?
Attached - I was only able to remove some of the long string-append
lines. Apologies for that second "patch" - not intentional. Thanks for
the review. I've changed the character to a different "~" so hopefully
more standard now. Guix lint doesn't complain.
ben
[-- Attachment #2: 0001-gnu-Add-mafft.patch --]
[-- Type: text/x-patch, Size: 3665 bytes --]
From 0796e8be05977e6d30eab787a1550bd8d1f12b2d Mon Sep 17 00:00:00 2001
From: Ben Woodcroft <donttrustben@gmail.com>
Date: Sat, 12 Sep 2015 22:10:20 +1000
Subject: [PATCH] gnu: Add mafft.
* gnu/packages/bioinformatics.scm (mafft): New variable.
---
gnu/packages/bioinformatics.scm | 60 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 60 insertions(+)
diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
index 03eb2df..e0b7e40 100644
--- a/gnu/packages/bioinformatics.scm
+++ b/gnu/packages/bioinformatics.scm
@@ -1543,6 +1543,66 @@ resolution of binding sites through combining the information of both
sequencing tag position and orientation.")
(license license:bsd-3)))
+(define-public mafft
+ (package
+ (name "mafft")
+ (version "7.221")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append
+ "http://mafft.cbrc.jp/alignment/software/mafft-" version
+ "-without-extensions-src.tgz"))
+ (file-name (string-append name "-" version ".tgz"))
+ (sha256
+ (base32
+ "0xi7klbsgi049vsrk6jiwh9wfj3b770gz3c8c7zwij448v0dr73d"))))
+ (build-system gnu-build-system)
+ (arguments
+ `(#:tests? #f ; no automated tests, though there are tests in the read me
+ #:make-flags (let ((out (assoc-ref %outputs "out")))
+ (list (string-append "PREFIX=" out)
+ (string-append "BINDIR="
+ (string-append out "/bin"))))
+ #:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'enter-dir
+ (lambda _ (chdir "core") #t))
+ (add-after 'enter-dir 'patch-makefile
+ (lambda _
+ ;; on advice from the MAFFT authors, there is no need to
+ ;; distribute mafft-profile, mafft-distance, or
+ ;; mafft-homologs.rb as they are too "specialised".
+ (substitute* "Makefile"
+ ;; remove mafft-homologs.rb from SCRIPTS
+ (("^SCRIPTS = mafft mafft-homologs.rb")
+ "SCRIPTS = mafft")
+ ;; remove mafft-distance from PROGS
+ (("^PROGS = dvtditr dndfast7 dndblast sextet5 mafft-distance")
+ "PROGS = dvtditr dndfast7 dndblast sextet5")
+ ;; remove mafft-profile from PROGS
+ (((string-append "splittbfast disttbfast tbfast mafft-profile"
+ " f2cl mccaskillwrap"))
+ "splittbfast disttbfast tbfast f2cl mccaskillwrap")
+ (("^rm -f mafft-profile mafft-profile.exe") "#")
+ (("^rm -f mafft-distance mafft-distance.exe") ")#")
+ ;; do not install MAN pages in libexec folder
+ (((string-append "^\t\\$\\(INSTALL\\) -m 644 \\$\\(MANPAGES"
+ "\\) \\$\\(DESTDIR\\)\\$\\(LIBDIR\\)"))
+ "#"))
+ #t))
+ (delete 'configure))))
+ (inputs
+ `(("perl" ,perl)))
+ (home-page "http://mafft.cbrc.jp/alignment/software/")
+ (synopsis
+ "Multiple sequence alignment program")
+ (description
+ "MAFFT offers a range of multiple alignment methods for nucleotide and
+protein sequences. For instance, it offers L-INS-i (accurate; for alignment
+of <~200 sequences) and FFT-NS-2 (fast; for alignment of <~30,000
+sequences).")
+ (license (license:non-copyleft "file://license"
+ "See license in the distribution."))))
(define-public metabat
(package
--
2.4.3
next prev parent reply other threads:[~2015-09-12 12:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 12:43 [PATCH] Add MAFFT Ben Woodcroft
2015-07-25 19:26 ` Ricardo Wurmus
2015-07-26 3:10 ` Ben Woodcroft
2015-07-26 9:43 ` Andreas Enge
2015-07-26 10:16 ` Ricardo Wurmus
2015-07-26 10:29 ` Andreas Enge
2015-07-31 22:42 ` Ben Woodcroft
2015-08-25 20:58 ` Ludovic Courtès
2015-09-07 8:55 ` Andreas Enge
2015-09-07 9:07 ` Ricardo Wurmus
2015-09-12 12:20 ` Ben Woodcroft [this message]
2015-09-16 20:19 ` Ludovic Courtès
2015-09-16 21:09 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F4187B.8020804@uq.edu.au \
--to=b.woodcroft@uq.edu.au \
--cc=andreas@enge.fr \
--cc=guix-devel@gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.