From: "Pádraig Brady" <P@draigBrady.com>
To: "Paul Eggert" <eggert@cs.ucla.edu>, "Ludovic Courtès" <ludo@gnu.org>
Cc: 21460@debbugs.gnu.org, bug-guix@gnu.org
Subject: bug#21460: Race condition in tests/tail-2/assert.sh
Date: Sat, 12 Sep 2015 03:22:12 +0100 [thread overview]
Message-ID: <55F38C54.8070306@draigBrady.com> (raw)
In-Reply-To: <55F37B4E.6060600@cs.ucla.edu>
On 12/09/15 02:09, Paul Eggert wrote:
> Pádraig Brady wrote:
>> + else if (new_stats.st_nlink == 0) /* XXX: what about multi-linked files. */
>
> That comment was my thought exactly. It appears to be a kernel bug that really
> needs to get fixed in the kernel; there just doesn't seem to be a reliable
> workaround in user space.
I double checked with kernel guys, and Al Viro
essentially said the inode and directory operations are independent.
https://lkml.org/lkml/2015/9/11/790
So we probably need to handle the IN_DELETE event
on the directory to cater for this race, as done in:
https://lists.gnu.org/archive/html/coreutils/2015-07/msg00015.html
cheers,
Pádraig.
next prev parent reply other threads:[~2015-09-12 2:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 16:23 bug#21459: Race condition in tests/tail-2/assert.sh Ludovic Courtès
2015-09-11 17:18 ` bug#21460: " Paul Eggert
2015-09-11 20:55 ` Ludovic Courtès
2015-09-11 22:49 ` Pádraig Brady
2015-09-11 23:48 ` Pádraig Brady
2015-09-12 1:09 ` Paul Eggert
2015-09-12 2:22 ` Pádraig Brady [this message]
2015-10-02 15:50 ` Pádraig Brady
2015-09-11 20:34 ` bug#21459: " Pádraig Brady
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F38C54.8070306@draigBrady.com \
--to=p@draigbrady.com \
--cc=21460@debbugs.gnu.org \
--cc=bug-guix@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.