all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ben Woodcroft <b.woodcroft@uq.edu.au>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>
Subject: Re: [PATCH] Add prodigal.
Date: Sat, 27 Jun 2015 22:33:31 +1000	[thread overview]
Message-ID: <558E981B.4000402@uq.edu.au> (raw)
In-Reply-To: <87y4j5xwiw.fsf@mdc-berlin.de>

[-- Attachment #1: Type: text/plain, Size: 1307 bytes --]


On 27/06/15 20:40, Ricardo Wurmus wrote:
>>   +    (synopsis "Protein-coding gene prediction for Archaea and Bacteria")
> Shouldn’t “Archaea” and “Bacteria” both be lower-cased?
I don't believe so. As I understand it you can use "bacterial" and 
"archaeal" with lower case, but here we are referring to the domains as 
nouns.

I did take some small liberties here. The original sentence on the web was

 >Fast, reliable protein-coding gene prediction for prokaryotic genomes.

To me this is problematic in two ways:
1. It works on more than just genomes
2. There is some contention in the field about the use of "prokaryote", 
since this refers to a paraphyletic group - us humans are more closely 
related to Archaea than Bacteria.
http://link.springer.com/referenceworkentry/10.1007/978-3-642-30194-0_114

I figure it was just easier to sidestep the issue and put Archaea and 
Bacteria.
> another thing just occurred to me.  Instead of replacing the install
> phase you might just overwrite the INSTALLDIR variable, something like
> this:
>
>      #:make-flags (list (string-append "INSTALLDIR="
>                                        (assoc-ref %outputs "out")))
>
> What do you think?
That made it more concise, and maybe more future proof (though need 
added "/bin").

[-- Attachment #2: 0001-gnu-Add-prodigal.patch --]
[-- Type: text/x-patch, Size: 2050 bytes --]

From 086a910d53995cb209a7413c74705d2ad3b8e17e Mon Sep 17 00:00:00 2001
From: Ben Woodcroft <donttrustben@gmail.com>
Date: Sat, 27 Jun 2015 22:28:19 +1000
Subject: [PATCH] gnu: Add prodigal.

* gnu/packages/bioinformatics.scm (prodigal): New variable.
---
 gnu/packages/bioinformatics.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
index 31df219..f321d82 100644
--- a/gnu/packages/bioinformatics.scm
+++ b/gnu/packages/bioinformatics.scm
@@ -1405,6 +1405,37 @@ files and writing bioinformatics applications.")
 generated using the PacBio Iso-Seq protocol.")
       (license license:bsd-3))))
 
+(define-public prodigal
+  (package
+    (name "prodigal")
+    (version "2.6.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://github.com/hyattpd/Prodigal/archive/v"
+                    version ".tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "0m8sb0fg6lmxrlpzna0am6svbnlmd3dckrhgzxxgb3gxr5fyj284"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f ;no check target
+       #:make-flags (list (string-append "INSTALLDIR="
+                                         (assoc-ref %outputs "out")
+                                         "/bin"))
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure))))
+    (home-page "http://prodigal.ornl.gov")
+    (synopsis "Protein-coding gene prediction for Archaea and Bacteria")
+    (description
+     "Prodigal runs smoothly on finished genomes, draft genomes, and
+metagenomes, providing gene predictions in GFF3, Genbank, or Sequin table
+format.  It runs quickly, in an unsupervised fashion, handles gaps, handles
+partial genes, and identifies translation initiation sites.")
+    (license license:gpl3+)))
+
 (define-public rsem
   (package
     (name "rsem")
-- 
2.4.3


  reply	other threads:[~2015-06-27 12:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-26 23:26 [PATCH] Add prodigal Ben Woodcroft
2015-06-26 23:30 ` Ben Woodcroft
2015-06-27 10:40   ` Ricardo Wurmus
2015-06-27 10:42     ` Ricardo Wurmus
2015-06-27 12:33       ` Ben Woodcroft [this message]
2015-07-05  4:52         ` Ben Woodcroft
2015-07-05  6:58           ` Mark H Weaver
2015-07-05  7:06           ` Alex Kost
2015-07-05  7:39             ` Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=558E981B.4000402@uq.edu.au \
    --to=b.woodcroft@uq.edu.au \
    --cc=guix-devel@gnu.org \
    --cc=ricardo.wurmus@mdc-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.