From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id aOyaLkxGrmU5jAAA62LTzQ:P1 (envelope-from ) for ; Mon, 22 Jan 2024 11:41:16 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id aOyaLkxGrmU5jAAA62LTzQ (envelope-from ) for ; Mon, 22 Jan 2024 11:41:16 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=inria.fr header.s=dc header.b=s3rCT5Qs; dmarc=fail reason="SPF not aligned (relaxed)" header.from=inria.fr (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1705920076; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=JEejeQ+1XmRYs0yZ40E5/6P9v3ApsKua9EJb1RBqP+4=; b=iKbR6UUZTt2U9GeQ+zBLubVARdtvWH/MeiKQirE4G5xLdE/bMUxAbfUqZH/n7Cu2RkTjt4 SsARXtEX706V+C/qLihb5FNs5NzJL+MsMz+27hcp9xZJhqRu9gi0zBWxrIdFLVfSrAhmHD 4G6bLzQqsKgLLcP1YkcI3tPQtAey5RBl/RzcmmC0i3WMxHlTtDWdGScBr01ylokeFw5ueh q0WmJJPNOkhrJI09z4JUcD0k1TVLXToKopFsdIDho2U0k33npHDfrjTrxw00po5C9Zkm4w stIdZP/45pOAYrQygVNVzZ1KvYUGsXDAIGDmWQsZcjPGrj0u4vqFxdRCxeh+qw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=inria.fr header.s=dc header.b=s3rCT5Qs; dmarc=fail reason="SPF not aligned (relaxed)" header.from=inria.fr (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1705920076; a=rsa-sha256; cv=none; b=O7w3027CAeWzQinLJtnkILnoZytQzu+lB7HKfRVTl/zVytjIZ6eUlCMJMKf4Jc0Tlp2Olt wlIGlUUvqCSw/eqlOh7Npdmr+GOE8LpqU/Uei/mHt6QvCSTlJcvE3L338HGdV64HHlqT1P 6W49rtarjHTCIRPF1hGtKPQ1qu+wN5DAK7PD9j/08TgnZv4pvH5DrDYcjXxvTMKlr+KMZL FWUnGPnlHw4WbRjEIRX9qcWMRKbYA7yQLlIekV4/UHFQxH40j5ciemXoR01IxXD1ckTuIS NEGUnk62zRfw6t1jfqXJXn1MmNqISM6mE3BFXRBpA9iT254t+r8aZ/FoUc1ksg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8141724E18 for ; Mon, 22 Jan 2024 11:41:16 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rRrjh-0006JN-NH; Mon, 22 Jan 2024 05:41:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rRrje-0006J5-Sa for guix-patches@gnu.org; Mon, 22 Jan 2024 05:40:58 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rRrje-000630-JF for guix-patches@gnu.org; Mon, 22 Jan 2024 05:40:58 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rRrji-00013C-GD for guix-patches@gnu.org; Mon, 22 Jan 2024 05:41:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68405] [PATCH v4] guix: download: Add support for git repositories. Resent-From: Romain Garbage Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 22 Jan 2024 10:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68405 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 68405 <68405@debbugs.gnu.org>, Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 68405-submit@debbugs.gnu.org id=B68405.17059200083962 (code B ref 68405); Mon, 22 Jan 2024 10:41:02 +0000 Received: (at 68405) by debbugs.gnu.org; 22 Jan 2024 10:40:08 +0000 Received: from localhost ([127.0.0.1]:39959 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rRrio-00011p-RP for submit@debbugs.gnu.org; Mon, 22 Jan 2024 05:40:08 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:2690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rRrij-000119-Rw for 68405@debbugs.gnu.org; Mon, 22 Jan 2024 05:40:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:message-id:in-reply-to:references: subject:mime-version:content-transfer-encoding; bh=JEejeQ+1XmRYs0yZ40E5/6P9v3ApsKua9EJb1RBqP+4=; b=s3rCT5QsYPfXTZcVhiVCl4QY/tJjSp7b0de+ilDEmiVp4Lob+xoN43ET Uz8HEMgEztaIjTk5okowuYJXvJhuYvmAzH/2SNkF826mPEruPf6jHtQ00 zFhAJHwAqrlhM2YQMGS8wDbXWR3nNfmoRGAhvQIjvbesnUnGSoGIJqnXe Q=; Received-SPF: Pass (mail2-relais-roc.national.inria.fr: domain of romain.garbage@inria.fr designates 128.93.142.32 as permitted sender) identity=mailfrom; client-ip=128.93.142.32; receiver=mail2-relais-roc.national.inria.fr; envelope-from="romain.garbage@inria.fr"; x-sender="romain.garbage@inria.fr"; x-conformance=spf_only; x-record-type="v=spf1"; x-record-text="v=spf1 include:mailout.safebrands.com a:basic-mail.safebrands.com a:basic-mail01.safebrands.com a:basic-mail02.safebrands.com ip4:128.93.142.0/24 ip4:192.134.164.0/24 ip4:128.93.162.160 ip4:89.107.174.7 mx ~all" Received-SPF: None (mail2-relais-roc.national.inria.fr: no sender authenticity information available from domain of postmaster@zcs-store5.inria.fr) identity=helo; client-ip=128.93.142.32; receiver=mail2-relais-roc.national.inria.fr; envelope-from="romain.garbage@inria.fr"; x-sender="postmaster@zcs-store5.inria.fr"; x-conformance=spf_only X-IronPort-AV: E=Sophos;i="6.05,211,1701126000"; d="scan'208";a="147916808" X-MGA-submission: MDEw/ZnSN4P2DkQJ1BITx4hhD8GJHBn+nE+Dx7YZyDWCFC9hIC1Peqf6eRFKDi4LnFvaZT9XP/Dk4rPEFkvOo3h+RahPIIwUyJucXPo4xHZGlXD9Z2njG0kdjJdmJKRZuYG1UByZd8ImXAiyzjiRMPJYla/WCxUByQ3ot/Ae1U1YfQ== Received: from zcs-store5.inria.fr ([128.93.142.32]) by mail2-relais-roc.national.inria.fr with ESMTP; 22 Jan 2024 11:39:51 +0100 Date: Mon, 22 Jan 2024 11:39:51 +0100 (CET) From: Romain Garbage Message-ID: <555736077.15526795.1705919991769.JavaMail.zimbra@inria.fr> In-Reply-To: <87v87ohene.fsf@gmail.com> References: <20240119102417.17155-1-romain.garbage@inria.fr> <87v87ohene.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [193.50.110.153] X-Mailer: Zimbra 8.8.15_GA_4581 (ZimbraWebClient - FF115 (Linux)/8.8.15_GA_4581) Thread-Topic: guix: download: Add support for git repositories. Thread-Index: Y3e7xAkhoyuNBFtWlJeR9d26F7Rdew== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 2.14 X-Spam-Score: 2.14 X-Migadu-Queue-Id: 8141724E18 X-Migadu-Scanner: mx12.migadu.com X-TUID: LMk48mtB5TWw Hello, ----- Mail original ----- > De: "Maxim Cournoyer" > =C0: "Romain Garbage" > Cc: "68405" <68405@debbugs.gnu.org>, "Ludovic Court=E8s" > Envoy=E9: Samedi 20 Janvier 2024 03:23:01 > Objet: Re: [PATCH v4] guix: download: Add support for git repositories. [...] >> + (with-store store >> + ;; TODO: Verify certificate support and deactivation. >> + (with-git-error-handling >> + (latest-repository-commit store url #:recursive? recursive? #:re= f >> reference))))) >=20 > The above contains too long lines still :-). Sorry, I missed them, I sent a v5 hopefully wrapping all the lines longer t= han 80 characters :) [...] =20 > Otherwise, I've tested it with: >=20 > --8<---------------cut here---------------start------------->8--- > ./pre-inst-env guix download -gr > https://git.jami.net/savoirfairelinux/jami-client-qt -o /tmp/jami > --8<---------------cut here---------------end--------------->8--- >=20 > and it worked as advertised; very nice! >=20 > Some idea for the future: the --recurse option could take an optional > argument that'd be a comma-separated list of submodules to fetch, e.g. >=20 > --8<---------------cut here---------------start------------->8--- > ./pre-inst-env guix download --git \ > --recurse=3Ddaemon,3rdparty/SortFilterProxyModel \ > https://git.jami.net/savoirfairelinux/jami-client-qt -o /tmp/jami > --8<---------------cut here---------------end--------------->8--- >=20 > and it'd recurse *only* the listed submodules. This would be useful as > some projects contain submodules for windows or other platforms we do > not care about and they may be very large (heavy) to download. >=20 > The same idea could be implemented for our git-reference, where > recursive? could accept a git submodule names list. That's actually a nice idea. I will see if I can find some time to add it t= o a later patch. > But back to the current scope: >=20 > Reviewed-by: Maxim Cournoyer Thank you for your review ! --=20 Romain