From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id kO8jINUvWWSBtwAASxT56A (envelope-from ) for ; Mon, 08 May 2023 19:22:29 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 4AwWINUvWWSF1AAA9RJhRA (envelope-from ) for ; Mon, 08 May 2023 19:22:29 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3057A2120A for ; Mon, 8 May 2023 19:22:29 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pw4Yn-00066k-UU; Mon, 08 May 2023 13:22:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pw4Yl-00066T-3i for bug-guix@gnu.org; Mon, 08 May 2023 13:22:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pw4Yk-0002sq-Ru for bug-guix@gnu.org; Mon, 08 May 2023 13:22:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pw4Yk-0006dT-Gh for bug-guix@gnu.org; Mon, 08 May 2023 13:22:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#63082: [PATCH v3 05/16] services: mpd: Obsolete the 'group' field. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 08 May 2023 17:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63082 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxim Cournoyer Cc: 63082@debbugs.gnu.org Received: via spool by 63082-submit@debbugs.gnu.org id=B63082.168356647125439 (code B ref 63082); Mon, 08 May 2023 17:22:02 +0000 Received: (at 63082) by debbugs.gnu.org; 8 May 2023 17:21:11 +0000 Received: from localhost ([127.0.0.1]:41488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pw4Xu-0006cF-Vo for submit@debbugs.gnu.org; Mon, 08 May 2023 13:21:11 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:44312) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pw4Xt-0006c0-Bo for 63082@debbugs.gnu.org; Mon, 08 May 2023 13:21:09 -0400 Received: by mail-ed1-f65.google.com with SMTP id 4fb4d7f45d1cf-50bc37e1525so9383153a12.1 for <63082@debbugs.gnu.org>; Mon, 08 May 2023 10:21:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683566462; x=1686158462; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=ShxakLvAGe5jpiXVF69R0XTx42BoWAPV4eh4VLvdSUI=; b=bnGsAIvkTLVy9MHyc5tKY3xWUnVupw1gJxRT/2Jfb+ETFJb0rrZMtzoxa+2qt6jHTS NqxcqLW2G8pIh4DUs8ob7ta2oumTi96WovHAneABKjArs3EYtHvZyy0ZxLbkAwA6dzT3 WuXx96AChsQpPFdqRpOzxcCKBb6cprXAYOdByUGmXTT7K6vGlaIFzmQGvL1qOaOl3UJJ gf9bvVbQYle+LwmhZqgXiqT01QSUt/pCi12ex9fvKAkQtXBO1fYEtZTMNyT6D9esvOjR 4HGmTuFBTau0CVAVDJwdcmXhgBw3cNRRV/u2Qr78HkM9Q6TwpYyTCFUPrtTIpbVubQ3X d6pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683566462; x=1686158462; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ShxakLvAGe5jpiXVF69R0XTx42BoWAPV4eh4VLvdSUI=; b=EG1RFEeJc+p0N3VVRblo2rf9Vh93hMAKJM+kmebZWhkxX9tow1wDcUXGuiDy/8SIkk 7nQ3bu23ZMSk7VshYNOPZ9fr54wsJs8I8hadhvMhWxnedPHctpDoe9aChQtI6euVme8P WARWY9bGywbjY3r7yGp5B7R4XEjp4PKXxBc/xClsGCCjstB0p9vSMf3aDN0LJGNe3abh yHknyH2IX3PsnDIRr0cwG6YAR5s2IJVKlT8lb0NLSWt4vrk9GLOmYnAqBqo+pE6PW3H7 nQ+dsQ2+W4bEXMT5ibGeWk9HNAfDCajgGxFtXXL2Wsi4KwSKTQlEvV/uH5TFyz0HK/2z LfDA== X-Gm-Message-State: AC+VfDwa2N2n+vPMwMBGIhy4WnP2ZuyoMXRvsVKc8sW1SPbjZ9DTCCeu I81/iWw39+JkvUN5vV5YOpI= X-Google-Smtp-Source: ACHHUZ7I2in1pftJaW2QgsrhB7NOPQVSvssdAL5FHA1fSlDdxcoa+jLVyzyIps6o/gJL/S0wrF8P+A== X-Received: by 2002:a17:907:3f06:b0:966:335a:5b07 with SMTP id hq6-20020a1709073f0600b00966335a5b07mr6310269ejc.62.1683566461911; Mon, 08 May 2023 10:21:01 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id hs32-20020a1709073ea000b009534211cc97sm208165ejc.159.2023.05.08.10.21.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 May 2023 10:21:01 -0700 (PDT) Message-ID: <55290ced23b1e241074977ee89860fa612e72666.camel@gmail.com> From: Liliana Marie Prikler Date: Mon, 08 May 2023 19:21:00 +0200 In-Reply-To: <87a5yfy6nc.fsf@gmail.com> References: <40db40a2bbfe5e0586d8b8c9694607bc0d66e340.1683299529.git.maxim.cournoyer@gmail.com> <7ba0cf980bf4ad3766c6c0ae30b069ed2891128e.camel@gmail.com> <875y943l6c.fsf@gmail.com> <69a7c685bb22add38026990a91f099db44eb80ec.camel@gmail.com> <87r0rsxb6r.fsf@gmail.com> <17e566fadba5d61844d0e40b08d072e39baa409c.camel@gmail.com> <87a5yfy6nc.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1683566549; a=rsa-sha256; cv=none; b=NNRkfv+kQCvO7i+GRbwx38p4cDO4t14iUOpCL8QA88l/9fUXiYdcnQESvf4bp7SpU9OS6y mKhibFfmQ5CBooCQHmLamlIW0vAhZCtUdI+205LQO3g39Cm3PCt4eGAyYYDjQ9urJyp0gf bj+q0+of9zx8DIaktoMgOigIAdlb3UnpB+prh6raTOqR/8Y1vWiyDTjdXwOlhUVSmK8ziE t5m6vCmmC21YDsBk180g6ZXc3qJJqJJIImHSGMDAEKIkpPUNIx0QKa6GXa+q0Tp0rrP9jt sm+OzMW5tapw9b3Naxx0XK+UzGekZB5hq+W97EIfxsnaiNXOd4Neg12iV+S6Kw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=bnGsAIvk; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1683566549; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ShxakLvAGe5jpiXVF69R0XTx42BoWAPV4eh4VLvdSUI=; b=N/XHKHMiB1yN6b5Y5tniGr6/Dc9ATAhBLydnSbLuNQ92VPH+UY3smv2MRKOGX2lB0Z1Gws aNldjQFu4kIOyjn8bgEcnoPZGBXyMe+PwHUgYgm+co2BzzN9rAbgiBJIl+RlbfQrBPLDg3 xGizhySRfoC+fElpIkRYYLXZx16jEJ2tt9wYf3wKeoa2dZCtHbQhIuPpJg4sS/8JJzk2QF H5qHvVd2V/70h2NkPe8Le/yrJL48yhUQVA6o9iGPqUO17xGz7WUJkwcBoxWBRXsfHAuENV dAM2YYnKNFiP5ZqoqDGU3rktr/1CSPHsnaCQTXpK9pE0u/cvpuTrhyTLm5K5nw== X-Migadu-Spam-Score: -1.59 X-Spam-Score: -1.59 X-Migadu-Queue-Id: 3057A2120A X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=bnGsAIvk; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-TUID: Ad4SmuUrPrq4 Am Sonntag, dem 07.05.2023 um 21:05 -0400 schrieb Maxim Cournoyer: > Hi Liliana, >=20 > Liliana Marie Prikler writes: >=20 > > Hi Maxim, > >=20 > > Am Sonntag, dem 07.05.2023 um 14:12 -0400 schrieb Maxim Cournoyer: > > > My focus on this series was making sure the configuration is > > > easy(er) > > > to reason with and that it works out of the box for the most > > > part. > > Obsoleting the group field does imho not significantly ease its > > use. > > It rather makes its non-ootb use harder, because you now have to > > edit > > two operating-system fields, without changing anything for the ootb > > use. >=20 > If you haven't tried that already, I'd like to give you the following > challenge: with the current MPD service, are you able to configure it > so that it works as your user, touching the minimum amount of > configuration switches (as you'd do if you were a new MPD service > user getting started?). I mean, I do have an unfair advantage at this challenge, but: (define* (by proc value #:optional (=3D equal?)) (lambda (record) (=3D (proc record) value))) (service mpd-service-type (mpd-configuration (user (find (by user-account-name my-user-name) users)) (group (find (by user-group-name "users") %base-groups)))) If you want, you can also make that a match-lambda. > With this series I opinionated on the side that less is better, > coming from the realization that configuring a working MPD was > already quite the challenge (less after this series, if it succeeds > at its goal).=C2=A0 In my opinion, the main two use cases for configuring > the services user/group probably are: >=20 > 1. you want to run it as an existing user > 2. you want it to run as its own user >=20 > The defaults cover 2, while for 1 you don't have a need to configure > a group for it, since an existing user will also already have an > existing group (and the captures such group). Seeing how you write about "the main two use cases", I think either there is a third use case not mentioned or you are underselling the extent of the second use case. > > > It puts the issue aside; if you can't configure a mismatched > > > group, you can't shoot yourself in the foot. > > No, it doesn't: Since it pulls in the groups field into "stuff you > > need to worry about when editing your MPD service", it actually > > exacerbates the issue.=C2=A0 Yes, the API is awkward, but it does help > > making mpd-service-type self-contained. >=20 > The thing is that the 'group' field of mpd-service-type has a > default, which is easy to forget (because it's duplicated from a > object and you may reasonably expect the service to > default to the specified user-account's group).=C2=A0 But that's not easy > to achieve.=C2=A0 I tried. I mean, if you want to serialize the user account's group, by all means go ahead, but the group field should stay semantically intact for the case that user:group are provided as strings. Well, as it turns out, you don't need to serialize the user or the group to the config file, so that's not even an issue holding us back. > >=20 Cheers