From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyril Roelandt Subject: Re: [PATCH 4/5] guix lint: Make sure a synopsis cannot start with a lower-case article. Date: Mon, 06 Oct 2014 02:28:37 +0200 Message-ID: <5431E235.40809@gmail.com> References: <1411854568-11187-1-git-send-email-tipecaml@gmail.com> <1411854568-11187-5-git-send-email-tipecaml@gmail.com> <87bnpzafod.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33297) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XawAT-0006u0-5g for guix-devel@gnu.org; Sun, 05 Oct 2014 20:28:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XawAK-0005dH-3a for guix-devel@gnu.org; Sun, 05 Oct 2014 20:28:49 -0400 In-Reply-To: <87bnpzafod.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?UTF-8?B?THVkb3ZpYyBDb3VydMOocw==?= Cc: guix-devel@gnu.org On 09/28/2014 06:11 PM, Ludovic Courtès wrote: > Cyril Roelandt skribis: > >> * guix/scripts/lint.scm (check-start-article): use "string-ci=?" instead of "string=?". >> * tests/lint.scm: Add corresponding tests. > > Test names, lines wrapped please. :-) > >> (define (check-start-article synopsis) >> - (if (or (string=? (string-take synopsis 2) "A ") >> - (string=? (string-take synopsis 3) "An ")) >> + (if (or (string-ci=? (string-take synopsis 2) "A ") >> + (string-ci=? (string-take synopsis 3) "An ")) > > There’s also a problem if SYNOPSIS is shorter, but I wonder if we should > worry about it? > Nah, doesn't seem so bad. Cyril.