From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyril Roelandt Subject: Re: [PATCH 3/5] guix lint: check whether descriptions and synopses start with an upper-case letter. Date: Mon, 06 Oct 2014 02:28:12 +0200 Message-ID: <5431E21C.5040504@gmail.com> References: <1411854568-11187-1-git-send-email-tipecaml@gmail.com> <1411854568-11187-4-git-send-email-tipecaml@gmail.com> <87iok7afrj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33230) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XawA4-0006qY-L9 for guix-devel@gnu.org; Sun, 05 Oct 2014 20:28:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xaw9v-0005T7-KF for guix-devel@gnu.org; Sun, 05 Oct 2014 20:28:24 -0400 In-Reply-To: <87iok7afrj.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?UTF-8?B?THVkb3ZpYyBDb3VydMOocw==?= Cc: guix-devel@gnu.org On 09/28/2014 06:09 PM, Ludovic Courtès wrote: > Cyril Roelandt skribis: > >> * guix/scripts/lint.scm (check-description-style, check-synopsis-start-upper-case): New methods >> * tests/lint.scm: Test them. > > Please specify the test names, and wrap lines. > >> +(define (start-with-upper-case s) >> + (char-set-contains? char-set:upper-case (string-ref s 0))) > > Rather ‘starts-with-capital-letter?’ (with the question mark, as is > conventional, and more grammatically correct I think.) > > Also it may be worth checking that S has one or more character, so > gracefully handle empty synopses. > Not sure whether the "starts-with-capital-letter" function would make a lot of sense with an empty string, that why I test this in the caller. WDYT ? > OK to push with these changes, thanks! > > Ludo’. >