From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:34201) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJoxE-0003VJ-NB for guix-patches@gnu.org; Thu, 25 Apr 2019 20:43:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJoxC-00089J-Un for guix-patches@gnu.org; Thu, 25 Apr 2019 20:43:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46097) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hJoxC-000885-Gg for guix-patches@gnu.org; Thu, 25 Apr 2019 20:43:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hJoxC-0006kk-Bx for guix-patches@gnu.org; Thu, 25 Apr 2019 20:43:02 -0400 Subject: [bug#35423] [PATCH] gnu: Add julius. References: <3d5daf0540406554d3082f94fdc6079c@disroot.org> In-Reply-To: <3d5daf0540406554d3082f94fdc6079c@disroot.org> Resent-Message-ID: Mime-Version: 1.0 Date: Fri, 26 Apr 2019 00:41:55 +0000 Content-Type: multipart/mixed; boundary="--=_RainLoop_654_718490006.1556239315" From: nly@disroot.org Message-ID: <52e174f4e91974bc416b9c465ae31d48@disroot.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 35423@debbugs.gnu.org ----=_RainLoop_654_718490006.1556239315 Content-Type: multipart/alternative; boundary="--=_RainLoop_283_120774218.1556239315" ----=_RainLoop_283_120774218.1556239315 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable > nly,=0A=0A> Thanks for the patch! Unfortunately, the indentation's bugg= ered.=0A> How did you create/send it?=0A=0A> nly@disroot.org (mailto:nly@= disroot.org) wrote:=0A> > Julius is a speech recognition tool. Package us= es a custom=0A> > license.=0A> >=0A> > From e01acf44822c57cf2af4678007ddd= 6a70b61ce1e Mon Sep 17=0A> > 00:00:00 2001=0A> > From: Amar Singh =0A> > Date: Sun, 21 Apr 2019 19:37:37= +0530=0A> > Subject: [PATCH] gnu: Add julius.=0A> >=0A> > * gnu/packages= /speech.scm (julius): New variable.=0A> > ---=0A> > gnu/packages/speech.s= cm | 39=0A> > +++++++++++++++++++++++++++++++++++++++=0A> > 1 file change= d, 39 insertions(+)=0A> >=0A> > diff --git a/gnu/packages/speech.scm b/gn= u/packages/speech.scm=0A> > index 2d6c63e3f9..a99be8a0aa 100644=0A> > ---= a/gnu/packages/speech.scm=0A> > +++ b/gnu/packages/speech.scm=0A> > @@ -= 33,9 +33,11 @@=0A> > #:use-module (gnu packages gcc)=0A> > #:use-module (= gnu packages glib)=0A> > #:use-module (gnu packages linux)=0A> > + #:use-= module (gnu packages perl)=0A> > #:use-module (gnu packages pkg-config)= =0A> > #:use-module (gnu packages pulseaudio)=0A> > #:use-module (gnu pac= kages python)=0A> > + #:use-module (gnu packages sdl)=0A> > #:use-module = (gnu packages textutils))=0A> > (define-public espeak=0A> > @@ -119,6 +12= 1,43 @@ It is based on the eSpeak engine and=0A> > supports spectral and = Klatt formant=0A> > synthesis, and the ability to use MBROLA voices.")=0A= > > (license license:gpl3+)))=0A> > +(define-public julius=0A> > + (packa= ge=0A> > + (name "julius")=0A> > + (version "8c60cb8c")=0A=0AWeb mail mus= t've wrapped the text.=0A=0A> Package versions must be monotonically incr= easing over time so=0A> Guix (and users) can determine which is newer. Gi= t commits=0A> aren't.=0A=0A> We also prefer to package upstream releases = whenever possible, and=0A> I see there's a 4.5 release on GitHub. Would t= hat do?=0A=0A> If not, can you use GIT-VERSION (with "4.5" as the first a= rgument)=0A> instead? Examples abound in (gnu packages).=0A=0A> > + (sour= ce=0A> > + (origin=0A> > + (method git-fetch)=0A> > + (uri=0A> > + (git-r= eference=0A> > + (url "https://github.com/julius-speech/julius (https://g= ithub.com/julius-speech/julius)")=0A> > + (commit version)))=0A> > + (fil= e-name=0A> > + (git-file-name name version))=0A=0A> This can remain uncha= nged even if you'd switch to GIT-VERSION.=0A=0AUsing git-version now, (gi= t-version "4.5" "1" commit). The commit is indeed version 4.5.=0A=0A> > += (sha256=0A> > + (base32=0A> > + "11qbp9kid251lx6li4fv1r6l0pixxcs1m00sax1= z057bhcv4jc7a"))))=0A> > + (build-system gnu-build-system)=0A> > + (argum= ents=0A> > + `(#:phases=0A> > + (modify-phases %standard-phases=0A> > + (= delete 'check))))=0A> > + (inputs=0A> > + `(("alsa-lib" ,alsa-lib)=0A> > = + ("zlib" ,zlib)=0A> > + ("sdl2" ,sdl2)=0A> > + ("perl" ,perl)))=0A=0A> N= itpick: might as wel sort these before they go in.=0A=0A> > + (home-page = "https://github.com/julius-speech (https://github.com/julius-speech/)")= =0A=0A> According to the README, the =C3=A2=E2=82=AC=CB=9Cofficial=C3=A2= =E2=82=AC=E2=84=A2 home page is just=0A=0A> https://github.com/julius-spe= ech/julius (https://github.com/julius-speech/julius)=0A=0A> > + (synopsis= "Open-Source Large Vocabulary Continuous Speech=0A> > +Recognition Engin= e")=0A=0A> Everything in Guix is =C3=A2=E2=82=AC=CB=9COpen Source=C3=A2= =E2=82=AC=E2=84=A2 (not a term we should be=0A> promoting anyway :-) so w= e don't mention it in synopses or=0A> descriptions.=0A=0A> I don't think = the capitalisation is helpful (even if =C3=A2=E2=82=AC=CB=9CLVCSR=C3=A2= =E2=82=AC=E2=84=A2 were=0A> a common initialism, =C3=A2=E2=82=AC=CB=9CEng= ine=C3=A2=E2=82=AC=E2=84=A2 wouldn't be capitalised).=0A=0A> > + (descrip= tion=0A> > + "Julius is a high-performance, small-footprint large=0A> > v= ocabulary continuous=0A> > + speech recognition (LVCSR) decoder software = for speech-related=0A> > researchers and=0A> > +developers.")=0A=0A> Here= you can use @acronym{LVCSR, large vocabulary continuous=0A> speech recog= nition} if you like.=0A=0A> This description is awfully short. Since you'= re familiar with the=0A> software, would you mind expanding it? You can r= e-use the most=0A> relevant parts of the README or other documentation.= =0A=0ASynopsis is lowercase now, Added one more sentence to description. = Use=0A@(acronym ..) in description.=0A=0A> > + (license=0A> > + (license:= non-copyleft "http://julius.osdn.jp/LICENSE.txt (http://julius.osdn.jp/LI= CENSE.txt)"=0A> > + "Julius-Modified-BSD-4Clause"))))=0A=0A> Hmm. I'm not= sure if clauses 3 and 5 could be problematic. Has=0A> this licence been = previously discussed elsewhere in the FSDG=0A> world?=0A>=0A> Thanks!=0A= =0A> T G-R=0A=0AYes, Julius is free software as of Version 4.2.2. It's be= en discussed at=0AFedora project: https://fedoraproject.org/wiki/Licensin= g/Julius (https://fedoraproject.org/wiki/Licensing/Julius)=0A=0ASee attac= hment for patch. Alternatively: http://nly.info.tm:9001/guix/gnu-add-juli= us.patch (http://nly.info.tm:9001/guix/gnu-add-julius.patch)=0A=0ACheers,= =0AAmar Singh ----=_RainLoop_283_120774218.1556239315 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable
<= div>
&g= t; nly,

> Thanks for the patch! Unfortunately, the indentation'= s buggered.
> How did you create/send it?

> nly@d= isroot.org wrote:
> > Julius is a speech recognition tool. P= ackage uses a custom
> > license.
> >
> > From= e01acf44822c57cf2af4678007ddd6a70b61ce1e Mon Sep 17
> > 00:00:0= 0 2001
> > From: Amar Singh <nly@disroot.org><= br>> > Date: Sun, 21 Apr 2019 19:37:37 +0530
> > Subject: = [PATCH] gnu: Add julius.
> >
> > * gnu/packages/speech.= scm (julius): New variable.
> > ---
> > gnu/packages/sp= eech.scm | 39
> > +++++++++++++++++++++++++++++++++++++++
>= ; > 1 file changed, 39 insertions(+)
> >
> > diff --= git a/gnu/packages/speech.scm b/gnu/packages/speech.scm
> > inde= x 2d6c63e3f9..a99be8a0aa 100644
> > --- a/gnu/packages/speech.sc= m
> > +++ b/gnu/packages/speech.scm
> > @@ -33,9 +33,11= @@
> > #:use-module (gnu packages gcc)
> > #:use-modul= e (gnu packages glib)
> > #:use-module (gnu packages linux)
&= gt; > + #:use-module (gnu packages perl)
> > #:use-module (gn= u packages pkg-config)
> > #:use-module (gnu packages pulseaudio= )
> > #:use-module (gnu packages python)
> > + #:use-mo= dule (gnu packages sdl)
> > #:use-module (gnu packages textutils= ))
> > (define-public espeak
> > @@ -119,6 +121,43 @@ I= t is based on the eSpeak engine and
> > supports spectral and Kl= att formant
> > synthesis, and the ability to use MBROLA voices.= ")
> > (license license:gpl3+)))
> > +(define-public ju= lius
> > + (package
> > + (name "julius")
> > = + (version "8c60cb8c")

Web mail must've wrapped the text.

&= gt; Package versions must be monotonically increasing over time so
>= ; Guix (and users) can determine which is newer. Git commits
> aren= 't.

> We also prefer to package upstream releases whenever poss= ible, and
> I see there's a 4.5 release on GitHub. Would that do?
> If not, can you use GIT-VERSION (with "4.5" as the first argum= ent)
> instead? Examples abound in (gnu packages).

> >= + (source
> > + (origin
> > + (method git-fetch)
&g= t; > + (uri
> > + (git-reference
> > + (url "https://github.com/julius-speech/julius")
> &= gt; + (commit version)))
> > + (file-name
> > + (git-fi= le-name name version))

> This can remain unchanged even if you'= d switch to GIT-VERSION.

Using git-version now, (git-version "4.5"= "1" commit). The commit is indeed version 4.5.

> > + (sha25= 6
> > + (base32
> > + "11qbp9kid251lx6li4fv1r6l0pixxcs1= m00sax1z057bhcv4jc7a"))))
> > + (build-system gnu-build-system)<= br>> > + (arguments
> > + `(#:phases
> > + (modif= y-phases %standard-phases
> > + (delete 'check))))
> > = + (inputs
> > + `(("alsa-lib" ,alsa-lib)
> > + ("zlib" = ,zlib)
> > + ("sdl2" ,sdl2)
> > + ("perl" ,perl)))
<= br>> Nitpick: might as wel sort these before they go in.

> &= gt; + (home-page "https://github.com/julius-speech")

> According to the README, the =C3=A2=E2=82=AC=CB=9Coffici= al=C3=A2=E2=82=AC=E2=84=A2 home page is just

> https://github.com/julius-speech/julius

> > + (= synopsis "Open-Source Large Vocabulary Continuous Speech
> > +Re= cognition Engine")

> Everything in Guix is =C3=A2=E2=82=AC=CB= =9COpen Source=C3=A2=E2=82=AC=E2=84=A2 (not a term we should be
> p= romoting anyway :-) so we don't mention it in synopses or
> descrip= tions.

> I don't think the capitalisation is helpful (even if = =C3=A2=E2=82=AC=CB=9CLVCSR=C3=A2=E2=82=AC=E2=84=A2 were
> a common = initialism, =C3=A2=E2=82=AC=CB=9CEngine=C3=A2=E2=82=AC=E2=84=A2 wouldn't = be capitalised).

> > + (description
> > + "Julius i= s a high-performance, small-footprint large
> > vocabulary conti= nuous
> > + speech recognition (LVCSR) decoder software for spee= ch-related
> > researchers and
> > +developers.")
> Here you can use @acronym{LVCSR, large vocabulary continuous
&g= t; speech recognition} if you like.

> This description is awful= ly short. Since you're familiar with the
> software, would you mind= expanding it? You can re-use the most
> relevant parts of the READ= ME or other documentation.

Synopsis is lowercase now, Added one mo= re sentence to description. Use
@(acronym ..) in description.

&= gt; > + (license
> > + (license:non-copyleft "http://julius.osdn.jp/LICENSE.txt"
> > + "Julius-Modifie= d-BSD-4Clause"))))

> Hmm. I'm not sure if clauses 3 and 5 could= be problematic. Has
> this licence been previously discussed elsew= here in the FSDG
> world?
>
> Thanks!

> T G-R=

Yes, Julius is free software as of Version 4.2.2. It's been discu= ssed at
Fedora project: https://fedor= aproject.org/wiki/Licensing/Julius

See attachment for patch. A= lternatively: http://nly.info.tm:9001/guix/gnu-add-julius.patch

Ch= eers,
Amar Singh<nly@disroot.org>
----=_RainLoop_283_120774218.1556239315-- ----=_RainLoop_654_718490006.1556239315 Content-Type: application/octet-stream; name="0001-gnu-Add-julius.patch" Content-Disposition: attachment; filename="0001-gnu-Add-julius.patch" Content-Transfer-Encoding: base64 RnJvbSAwMDc2ZDg0OTc5YmVkMzY2NmY2OGFkODgzZWUzNThiMTg1MTk0MTFlIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBbWFyIFNpbmdoIDxubHlAZGlzcm9vdC5vcmc+CkRh dGU6IFN1biwgMjEgQXByIDIwMTkgMTk6Mzc6MzcgKzA1MzAKU3ViamVjdDogW1BBVENIXSBn bnU6IEFkZCBqdWxpdXMuCgoqIGdudS9wYWNrYWdlcy9zcGVlY2guc2NtIChqdWxpdXMpOiBO ZXcgdmFyaWFibGUuCi0tLQogZ251L3BhY2thZ2VzL3NwZWVjaC5zY20gfCA0MyArKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDQz IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvc3BlZWNoLnNjbSBi L2dudS9wYWNrYWdlcy9zcGVlY2guc2NtCmluZGV4IDJkNmM2M2UzZjkuLjMxOTcxM2UyOWEg MTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy9zcGVlY2guc2NtCisrKyBiL2dudS9wYWNrYWdl cy9zcGVlY2guc2NtCkBAIC0zMyw5ICszMywxMSBAQAogICAjOnVzZS1tb2R1bGUgKGdudSBw YWNrYWdlcyBnY2MpCiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIGdsaWIpCiAgICM6 dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIGxpbnV4KQorICAjOnVzZS1tb2R1bGUgKGdudSBw YWNrYWdlcyBwZXJsKQogICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBwa2ctY29uZmln KQogICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBwdWxzZWF1ZGlvKQogICAjOnVzZS1t b2R1bGUgKGdudSBwYWNrYWdlcyBweXRob24pCisgICM6dXNlLW1vZHVsZSAoZ251IHBhY2th Z2VzIHNkbCkKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgdGV4dHV0aWxzKSkKIAog KGRlZmluZS1wdWJsaWMgZXNwZWFrCkBAIC0xMTksNiArMTIxLDQ3IEBAIEl0IGlzIGJhc2Vk IG9uIHRoZSBlU3BlYWsgZW5naW5lIGFuZCBzdXBwb3J0cyBzcGVjdHJhbCBhbmQgS2xhdHQg Zm9ybWFudAogc3ludGhlc2lzLCBhbmQgdGhlIGFiaWxpdHkgdG8gdXNlIE1CUk9MQSB2b2lj ZXMuIikKICAgICAobGljZW5zZSBsaWNlbnNlOmdwbDMrKSkpCiAKKyhkZWZpbmUtcHVibGlj IGp1bGl1cworICAobGV0ICgoY29tbWl0ICI4YzYwY2I4Yzk5OTk4YmFkOGMwNGU2ZTUwODEw NTk2YjgwMzA5ZWVhIikpCisgICAgKHBhY2thZ2UKKyAgICAgIChuYW1lICJqdWxpdXMiKQor ICAgICAgKHZlcnNpb24gKGdpdC12ZXJzaW9uICI0LjUiICIxIiBjb21taXQpKQorICAgICAg KHNvdXJjZQorICAgICAgIChvcmlnaW4KKyAgICAgICAgIChtZXRob2QgZ2l0LWZldGNoKQor ICAgICAgICAgKHVyaQorICAgICAgICAgIChnaXQtcmVmZXJlbmNlCisgICAgICAgICAgICh1 cmwgImh0dHBzOi8vZ2l0aHViLmNvbS9qdWxpdXMtc3BlZWNoL2p1bGl1cyIpCisgICAgICAg ICAgIChjb21taXQgY29tbWl0KSkpCisgICAgICAgICAoZmlsZS1uYW1lCisgICAgICAgICAg KGdpdC1maWxlLW5hbWUgbmFtZSB2ZXJzaW9uKSkKKyAgICAgICAgIChzaGEyNTYKKyAgICAg ICAgICAoYmFzZTMyCisgICAgICAgICAgICIxMXFicDlraWQyNTFseDZsaTRmdjFyNmwwcGl4 eGNzMW0wMHNheDF6MDU3YmhjdjRqYzdhIikpKSkKKyAgICAgIChidWlsZC1zeXN0ZW0gZ251 LWJ1aWxkLXN5c3RlbSkKKyAgICAgIChhcmd1bWVudHMKKyAgICAgICBgKCM6cGhhc2VzCisg ICAgICAgICAobW9kaWZ5LXBoYXNlcyAlc3RhbmRhcmQtcGhhc2VzCisgICAgICAgICAgIChk ZWxldGUgJ2NoZWNrKSkpKQorICAgICAgKGlucHV0cworICAgICAgIGAoKCJhbHNhLWxpYiIg LGFsc2EtbGliKQorICAgICAgICAgKCJ6bGliIiAsemxpYikKKyAgICAgICAgICgic2RsMiIg LHNkbDIpCisgICAgICAgICAoInBlcmwiICxwZXJsKSkpCisgICAgICAoaG9tZS1wYWdlICJo dHRwczovL2dpdGh1Yi5jb20vanVsaXVzLXNwZWVjaC9qdWxpdXMiKQorICAgICAgKHN5bm9w c2lzICJMYXJnZSB2b2NhYnVsYXJ5IGNvbnRpbnVvdXMgc3BlZWNoIHJlY29nbml0aW9uCitl bmdpbmUiKQorICAgICAgKGRlc2NyaXB0aW9uCisgICAgICAgIkp1bGl1cyBpcyBhIGhpZ2gt cGVyZm9ybWFuY2UsIHNtYWxsLWZvb3RwcmludCBsYXJnZSB2b2NhYnVsYXJ5Citjb250aW51 b3VzIHNwZWVjaCByZWNvZ25pdGlvbiBAYWNyb255bShMVkNTUiwgbGFyZ2Ugdm9jYWJ1bGFy eQorY29udGlub3VzIHNwZWVjaCByZWNvZ25pdGlvbikgZGVjb2RlciBzb2Z0d2FyZSBmb3Ig c3BlZWNoLXJlbGF0ZWQKK3Jlc2VhcmNoZXJzIGFuZCBkZXZlbG9wZXJzLiBCYXNlZCBvbiB3 b3JkIE4tZ3JhbSBhbmQgY29udGV4dC1kZXBlbmRlbnQKK0hNTSwgaXQgY2FuIHBlcmZvcm0g cmVhbC10aW1lIGRlY29kaW5nIG9uIHZhcmlvdXMgY29tcHV0ZXJzIGFuZAorZGV2aWNlcyBm cm9tIG1pY3JvLWNvbXB1dGVyIHRvIGNsb3VkIHNlcnZlci4iKQorICAgICAgKGxpY2Vuc2UK KyAgICAgICAobGljZW5zZTpub24tY29weWxlZnQgImh0dHA6Ly9qdWxpdXMub3Nkbi5qcC9M SUNFTlNFLnR4dCIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIkp1bGl1cy1Nb2Rp ZmllZC1CU0QtNENsYXVzZSIpKSkpKQorCiAoZGVmaW5lLXB1YmxpYyBtaXRsbQogICAocGFj a2FnZQogICAgIChuYW1lICJtaXRsbSIpCi0tIAoyLjIxLjAKCg== ----=_RainLoop_654_718490006.1556239315--