[PATCH] gnu: packages: Add ncdc-1.18.1.

[PATCH] gnu: packages: Add ncdc-1.18.1.

[Sree Harsha Totakura]

* gnu/packages/: Add new file dc.scm.
* gnu-system.am: Add file dc.scm.
* gnu/packages/dc.scm: Recipe for ncdc-1.18.1.
---
 gnu-system.am       |    1 +
 gnu/packages/dc.scm |   62 +++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 63 insertions(+)
 create mode 100644 gnu/packages/dc.scm

diff --git a/gnu-system.am b/gnu-system.am
index 31d664e..3112dc4 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -52,6 +52,7 @@ GNU_SYSTEM_MODULES =				\
   gnu/packages/cryptsetup.scm			\
   gnu/packages/curl.scm				\
   gnu/packages/cyrus-sasl.scm			\
+  gnu/packages/dc.scm				\
   gnu/packages/dejagnu.scm			\
   gnu/packages/ddrescue.scm			\
   gnu/packages/dictionaries.scm			\
diff --git a/gnu/packages/dc.scm b/gnu/packages/dc.scm
new file mode 100644
index 0000000..91e9d6e
--- /dev/null
+++ b/gnu/packages/dc.scm
@@ -0,0 +1,62 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2014 Sree Harsha Totakura <sreeharsha@totakura.in>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages dc)
+  #:use-module (gnu packages)
+  #:use-module (gnu packages compression)
+  #:use-module (gnu packages glib)
+  #:use-module (gnu packages gnutls)
+  #:use-module (gnu packages ncurses)
+  #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages sqlite)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix build-system gnu)
+  #:use-module ((guix licenses)
+                #:renamer (symbol-prefix-proc 'license:)))
+
+(define-public ncdc
+  (package
+    (name "ncdc")
+    (version "1.18.1")
+    (source
+     (origin 
+       (method url-fetch)
+       (uri (string-append "http://dev.yorhel.nl/download/ncdc-" version
+                           ".tar.gz"))
+       (sha256 (base32
+                "11c6z9c3vv2vg01q02r53m28q3cx6x66j1l63f1mbk1crlqpf9fc"))))
+    (build-system gnu-build-system)
+    (inputs 
+     `(("bzip2" ,bzip2)
+       ("glib" ,glib)
+       ("gnutls" ,gnutls)
+       ("ncurses" ,ncurses)
+       ("sqlite" ,sqlite)
+       ("zlib" ,zlib)))
+    (native-inputs
+     `(("pkg-config", pkg-config)))
+    (home-page "http://dev.yorhel.nl/ncdc")
+    (synopsis 
+     "moder and lightweight direct connect client with a friendly ncurses
+interface")
+    (description
+     "Ncdc is a Direct Connect protocol client implemented using ncurses known
+for its smaller footprint and ease of use.  Its features are on par with the
+existing DC clients.")
+    (license 'license:x11)))
-- 
1.7.10.4

Re: [PATCH] gnu: packages: Add ncdc-1.18.1.

[Ludovic Courtès]

Overall looks good to me.  Could you send an updated version that fixes
the details below?

Sree Harsha Totakura <sreeharsha@totakura.in> skribis:

> * gnu/packages/: Add new file dc.scm.
> * gnu-system.am: Add file dc.scm.
> * gnu/packages/dc.scm: Recipe for ncdc-1.18.1.

Please use the same format we normally use (see ‘git log’ for examples.)

> +  #:use-module ((guix licenses)
> +                #:renamer (symbol-prefix-proc 'license:)))

  #:use-module (guix licenses)

> +    (synopsis 
> +     "moder and lightweight direct connect client with a friendly ncurses
> +interface")

Could you start with a capital letter, and make it fit and one line?

> +    (description
> +     "Ncdc is a Direct Connect protocol client implemented using ncurses known

Perhaps something like: “is a client for the Direct Connect peer-to-peer
file sharing protocol” (yeah I just discovered what Direct Connect is,
so thanks ;-)).

> +    (license 'license:x11)))
                ^
There should be no quote here.

Thanks,
Ludo’.

Re: [PATCH] gnu: packages: Add ncdc-1.18.1.

[Sree Harsha Totakura]

On 01/24/2014 06:18 PM, Ludovic Courtès wrote:
>> > +  #:use-module ((guix licenses)
>> > +                #:renamer (symbol-prefix-proc 'license:)))
>   #:use-module (guix licenses)
> 

I had to use the renamer as the package depends on zlib and there is
also a license with the same name.

Sree

[PATCH] gnu: Add ncdc-1.18.1.

[Sree Harsha Totakura]

* gnu/packages/dc.scm : New module.
* gnu-system.am (GNU_SYSTEM_MODULES): Add module.
---
 gnu-system.am       |    1 +
 gnu/packages/dc.scm |   62 +++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 63 insertions(+)
 create mode 100644 gnu/packages/dc.scm

diff --git a/gnu-system.am b/gnu-system.am
index 31d664e..3112dc4 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -52,6 +52,7 @@ GNU_SYSTEM_MODULES =				\
   gnu/packages/cryptsetup.scm			\
   gnu/packages/curl.scm				\
   gnu/packages/cyrus-sasl.scm			\
+  gnu/packages/dc.scm				\
   gnu/packages/dejagnu.scm			\
   gnu/packages/ddrescue.scm			\
   gnu/packages/dictionaries.scm			\
diff --git a/gnu/packages/dc.scm b/gnu/packages/dc.scm
new file mode 100644
index 0000000..91e9d6e
--- /dev/null
+++ b/gnu/packages/dc.scm
@@ -0,0 +1,62 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2014 Sree Harsha Totakura <sreeharsha@totakura.in>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages dc)
+  #:use-module (gnu packages)
+  #:use-module (gnu packages compression)
+  #:use-module (gnu packages glib)
+  #:use-module (gnu packages gnutls)
+  #:use-module (gnu packages ncurses)
+  #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages sqlite)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix build-system gnu)
+  #:use-module ((guix licenses)
+                #:renamer (symbol-prefix-proc 'license:)))
+
+(define-public ncdc
+  (package
+    (name "ncdc")
+    (version "1.18.1")
+    (source
+     (origin 
+       (method url-fetch)
+       (uri (string-append "http://dev.yorhel.nl/download/ncdc-" version
+                           ".tar.gz"))
+       (sha256 (base32
+                "11c6z9c3vv2vg01q02r53m28q3cx6x66j1l63f1mbk1crlqpf9fc"))))
+    (build-system gnu-build-system)
+    (inputs 
+     `(("bzip2" ,bzip2)
+       ("glib" ,glib)
+       ("gnutls" ,gnutls)
+       ("ncurses" ,ncurses)
+       ("sqlite" ,sqlite)
+       ("zlib" ,zlib)))
+    (native-inputs
+     `(("pkg-config", pkg-config)))
+    (home-page "http://dev.yorhel.nl/ncdc")
+    (synopsis 
+     "Lightweight direct connect client with a friendly ncurses interface")
+    (description
+     "Ncdc is a client for the Direct Connect peer-to-peer protocol implemented
+using ncurses.  It is known for its smaller footprint and ease of use.")
+    (license 'license:x11)))
-- 
1.7.10.4

Re: [PATCH] gnu: Add ncdc-1.18.1.

[Ludovic Courtès]

Sree Harsha Totakura <sreeharsha@totakura.in> skribis:

> * gnu/packages/dc.scm : New module.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add module.

Applied, thanks!

> +    (license 'license:x11)))

I removed the quote.

Please make sure to use no tabs in .scm files and leave no trailing
white space (this should happen automatically with Emacs >= 23.)

Ludo’.

Re: [PATCH] gnu: packages: Add ncdc-1.18.1.

[Ludovic Courtès]

Sree Harsha Totakura <sreeharsha@totakura.in> skribis:

> On 01/24/2014 06:18 PM, Ludovic Courtès wrote:
>>> > +  #:use-module ((guix licenses)
>>> > +                #:renamer (symbol-prefix-proc 'license:)))
>>   #:use-module (guix licenses)
>> 
>
> I had to use the renamer as the package depends on zlib and there is
> also a license with the same name.

Right, sorry.

Ludo’.