Re: New package recipe: libopus-1.1

[Cyril Roelandt <tipecaml@gmail.com>]

On 01/22/2014 04:23 PM, Sree Harsha Totakura wrote:
> Hi,

Hello,

>
> Attached is a recipe for libopus-1.1.  Please include it.
>

Comments inlined.

> Thank you,
> Sree
>
>
> 0001-new-package-libopus-1.1.patch
>
>
>  From eafeaed576eccd20e108f62dc61d89d2c4be353b Mon Sep 17 00:00:00 2001
> From: Sree Harsha Totakura<sreeharsha@totakura.in>
> Date: Wed, 22 Jan 2014 16:17:18 +0100
> Subject: [PATCH] new package: libopus-1.1
>
>
> Signed-off-by: Sree Harsha Totakura<sreeharsha@totakura.in>
> ---
>   gnu/packages/opus.scm |   50 +++++++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 50 insertions(+)
>   create mode 100644 gnu/packages/opus.scm
>
> diff --git a/gnu/packages/opus.scm b/gnu/packages/opus.scm
> new file mode 100644
> index 0000000..2102b59
> --- /dev/null
> +++ b/gnu/packages/opus.scm
> @@ -0,0 +1,50 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2013 Andreas Enge<andreas@enge.fr>
> +;;;

Please use the right Copyright...

> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix.  If not, see<http://www.gnu.org/licenses/>.
> +
> +;; Author:  Sree Harsha Totakura<sreeharsha@totakura.in>
> +

... and remove this.

> +(define-module (gnu packages opus)
> +  #:use-module (gnu packages)
> +  #:use-module ((guix licenses)
> +                #:renamer (symbol-prefix-proc 'license:))

I do not think you need a #:renamer here.

> +  #:use-module (guix packages)
> +  #:use-module (guix download)
> +  #:use-module (guix build-system gnu))
> +
> +(define-public libopus
> +  (package
> +    (name "libopus")
> +    (version "1.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +"http://downloads.xiph.org/releases/opus/opus-"  version
> +                    ".tar.gz"))
> +              (sha256
> +               (base32
> +                "158xprn2086arvdib3vbbygz7z6jqkw2nci7nlywzzwallap0wmr"))))
> +    (build-system gnu-build-system)
> +    (synopsis "Libopus - hightly versatile audio codec")

s/hightly/highly/

> +    (description "Opus is a totally open, royalty-free, highly versatile audio
> +codec. Opus is unmatched for interactive speech and music transmission over
> +the Internet, but is also intended for storage and streaming applications. It
> +is standardized by the Internet Engineering Task Force (IETF) as RFC 6716
> +which incorporated technology from Skype's SILK codec and Xiph.Org's CELT
> +codec.")
> +    (license license:bsd-3)

'bsd-3' should be enough.
> +    (home-page"http://www.opus-codec.org/")))
> \ No newline at end of file
> -- 1.7.10.4


Also, please add the new file to gnu-system.am.


Thanks!
Cyril Roelandt.