From: Maxime Devos <maximedevos@telenet.be>
To: Sebastian Gibb <mail@sebastiangibb.de>, 47730@debbugs.gnu.org
Subject: [bug#47730] [PATCH 4/4] gnu: Add watson.
Date: Mon, 12 Apr 2021 21:42:08 +0200 [thread overview]
Message-ID: <527b2cd7e2b325ea88fe34ebed0e158e4a9fc518.camel@telenet.be> (raw)
In-Reply-To: <20210412154852.10255-4-mail@sebastiangibb.de>
[-- Attachment #1: Type: text/plain, Size: 703 bytes --]
On Mon, 2021-04-12 at 17:48 +0200, Sebastian Gibb via Guix-patches via wrote:
> [...]
> + `(#:phases (modify-phases %standard-phases
> + (replace 'check
> + (lambda _
> + (invoke "pytest")
> + #t)))))
Phases do not need to return #t anymore. The warning that results
if a phase doesn't return #t has been removed on the core-updates
branch, which will at some point in time be merged in master.
From a cursory look, I don't see any other problems, except perhaps ...
> + (synopsis
> + "Command-line time tracker")
I don't see a reason for a newline afer 'synopsis' here.
Thanks,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2021-04-12 19:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 15:45 [bug#47730] [PATCH 0/4] gnu: add watson Sebastian Gibb via Guix-patches via
2021-04-12 15:48 ` [bug#47730] [PATCH 1/4] gnu: python-arrow: Update to 1.0.3 Sebastian Gibb via Guix-patches via
2021-04-12 15:48 ` [bug#47730] [PATCH 2/4] gnu: Add python-click-didyoumean Sebastian Gibb via Guix-patches via
2021-04-12 15:48 ` [bug#47730] [PATCH 3/4] gnu: Add python-pytest-datafiles Sebastian Gibb via Guix-patches via
2021-04-12 15:48 ` [bug#47730] [PATCH 4/4] gnu: Add watson Sebastian Gibb via Guix-patches via
2021-04-12 19:42 ` Maxime Devos [this message]
2021-04-15 13:57 ` Sebastian Gibb via Guix-patches via
2024-08-26 23:37 ` bug#47730: [PATCH 0/4] gnu: add watson Sharlatan Hellseher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527b2cd7e2b325ea88fe34ebed0e158e4a9fc518.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=47730@debbugs.gnu.org \
--cc=mail@sebastiangibb.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.