Re: [PATCH] gnu: Add libmikmod

[David Thompson <dthompson2@worcester.edu>]

[-- Attachment #1: Type: text/plain, Size: 1342 bytes --]

On 10/25/2013 04:39 PM, Andreas Enge wrote:
> On Wed, Oct 23, 2013 at 06:14:17PM -0400, David Thompson wrote:
>> I will, but libmikmod is a library that is not directly associated
>> with SDL, so I made a separate module.
>
> Well, I am a bit wary about creating lots of files for small packages.
> If it occurs essentially as a dependency of sdl, I would be happy to
> package it inside the sdl module. But we do not have a coherent policy
> on packages vs. modules.

Okay, that sounds reasonable. I have renamed the module.

>
> Concerning style:
> In 'uri', the argument 'version' to 'string-append' should be aligned
> with the first argument of the line above, that is, "mirror...".

Silly mistake. Fixed.

> I am not sure what to do about the synopsis spanning two lines; I think
> we do not have a strict 80 column policy, so it could be put into one
> longer line.

Shortened the synopsis.

> After copyright, I have '??' instead of '©'; maybe the file is not
> in utf-8 format?

Mark Weaver pointed out that my attachment has no MIME type specifying 
it to be UTF-8 text. I have tweaked an Icedove setting, so hopefully 
things will be okay this time around. The patch *should* be inlined.

>
> In any case, it compiles well, and after addressing the small stylistic
> comments, I support pushing it.
>
> Andreas
>

Thanks.

- Dave


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-libmikmod.patch --]
[-- Type: text/x-patch; name="0001-gnu-Add-libmikmod.patch", Size: 3005 bytes --]

From a209fd040de0f026ddcd38d0c644517769b0802a Mon Sep 17 00:00:00 2001
From: David Thompson <dthompson2@worcester.edu>
Date: Mon, 21 Oct 2013 19:50:01 -0400
Subject: [PATCH] gnu: Add libmikmod.

* gnu/packages/sdl.scm: New file.
* gnu-system.am (GNU_SYSTEM_MODULES): Add it.
---
 gnu-system.am        |  1 +
 gnu/packages/sdl.scm | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 50 insertions(+)
 create mode 100644 gnu/packages/sdl.scm

diff --git a/gnu-system.am b/gnu-system.am
index 4ba1106..1c24607 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -159,6 +159,7 @@ GNU_SYSTEM_MODULES =				\
   gnu/packages/samba.scm			\
   gnu/packages/scheme.scm			\
   gnu/packages/screen.scm			\
+  gnu/packages/sdl.scm				\
   gnu/packages/shishi.scm			\
   gnu/packages/skribilo.scm			\
   gnu/packages/smalltalk.scm			\
diff --git a/gnu/packages/sdl.scm b/gnu/packages/sdl.scm
new file mode 100644
index 0000000..ceb2173
--- /dev/null
+++ b/gnu/packages/sdl.scm
@@ -0,0 +1,49 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2013 David Thompson <dthompson2@worcester.edu>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages sdl)
+  #:use-module (gnu packages)
+  #:use-module (guix licenses)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix build-system gnu)
+  #:use-module (gnu packages linux)
+  #:use-module (gnu packages xorg)
+  #:export (libmikmod))
+
+(define libmikmod
+  (package
+    (name "libmikmod")
+    (version "3.3.3")
+    (source (origin
+             (method url-fetch)
+             (uri (string-append "mirror://sourceforge/mikmod/libmikmod/"
+                                 version "/libmikmod-" version ".tar.gz"))
+             (sha256
+              (base32
+               "0dr4kgvhq9wf2riibh178c2al996spwwak6zffpv5n5bqmw29w3r"))))
+    (build-system gnu-build-system)
+    (inputs `(("alsa-lib" ,alsa-lib)
+              ("libx11" ,libx11)))
+    (synopsis "Library for module sound formats.")
+    (description
+     "MikMod is able to play a wide range of module formats, as well as
+digital sound files. It can take advantage of particular features of your
+system, such as sound redirection over the network.")
+    (license lgpl2.1)
+    (home-page "http://mikmod.sourceforge.net/")))
-- 
1.8.4.rc3