From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cyril Roelandt <tipecaml@gmail.com>
Subject: Re: [PATCH 0/2] Add tools for sysadmins: htop and dfc.
Date: Fri, 30 Aug 2013 22:37:40 +0200
Message-ID: <52210294.5060202@gmail.com>
References: <1377893316-5136-1-git-send-email-tipecaml@gmail.com>
	<877gf2nbej.fsf@karetnikov.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47762)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tipecaml@gmail.com>) id 1VFVlz-00074x-SQ
	for guix-devel@gnu.org; Fri, 30 Aug 2013 16:58:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tipecaml@gmail.com>) id 1VFVlr-00040x-Fj
	for guix-devel@gnu.org; Fri, 30 Aug 2013 16:58:27 -0400
Received: from mail-we0-x230.google.com ([2a00:1450:400c:c03::230]:34965)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tipecaml@gmail.com>) id 1VFVlr-0003zr-92
	for guix-devel@gnu.org; Fri, 30 Aug 2013 16:58:19 -0400
Received: by mail-we0-f176.google.com with SMTP id q56so2010103wes.35
	for <guix-devel@gnu.org>; Fri, 30 Aug 2013 13:58:17 -0700 (PDT)
In-Reply-To: <877gf2nbej.fsf@karetnikov.org>
List-Id: <guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Nikita Karetnikov <nikita@karetnikov.org>
Cc: guix-devel@gnu.org

On 08/30/2013 10:58 PM, Nikita Karetnikov wrote:
> More nitpicking…
>
>> +            (uri (string-append
>> +                  "mirror://sourceforge/htop/"
>> +                  version "/htop-" version ".tar.gz"))
>
> Could you place ‘string-append’ and "mirror://sourceforge/htop/" on
> the same line?
>

Yes. I never know what to do in such cases. Is there a document that 
contains these coding-style rules, such as the PEP8 for Python ?

>> +   (arguments '(#:tests? #f))
>
> Why did you disable tests?  Could you add a comment about that?
>

Sure. There are no tests :)

Cyril.