From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cyril Roelandt <tipecaml@gmail.com>
Subject: Re: [PATCH 1/2] gnu: Add datefudge.
Date: Sat, 17 Aug 2013 16:28:37 +0200
Message-ID: <520F8895.9090200@gmail.com>
References: <1376603907-4623-1-git-send-email-tipecaml@gmail.com>
	<1376603907-4623-2-git-send-email-tipecaml@gmail.com>
	<87y5814ji2.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36805)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tipecaml@gmail.com>) id 1VAhno-00085y-Pd
	for guix-devel@gnu.org; Sat, 17 Aug 2013 10:48:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tipecaml@gmail.com>) id 1VAhng-000268-7Z
	for guix-devel@gnu.org; Sat, 17 Aug 2013 10:48:28 -0400
In-Reply-To: <87y5814ji2.fsf@gnu.org>
List-Id: <guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?UTF-8?B?THVkb3ZpYyBDb3VydMOocw==?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

On 08/16/2013 07:45 PM, Ludovic Courtès wrote:
> Cyril Roelandt <tipecaml@gmail.com> skribis:
>
>> +        (alist-replace
>> +         'configure
>> +         (lambda* (#:key version outputs #:allow-other-keys #:rest args)
>> +          (pk version outputs)
>
> Leftover debugging statements, and ‘version’ doesn’t exist.
>
> What you can do is use:
>
>    (arguments
>      `( ...
>         ,version
>         ...
>        ))
>
> to paste the ‘version’ field of the package being defined in the
> quasiquote expression.
>

What kind of whitchcraft is this ? This works but I have no idea why. I 
don't think that Duckduckgoing "GNU Guile ," will give me any 
interesting results, so would you care to explain how this works, or 
redirect me to the appropriate documentation ?


>> +           (substitute* "Makefile"
>> +             (("^VERSION.*$") (string-append "VERSION=" version)))
>> +           ;; We do not need to pass these flags to "install".
>> +           (substitute* "Makefile"
>
> No need to repeat ‘substitute*’: there can be several substitutations in
> a substitute* form.
>
>> +           (substitute* "Makefile"
>> +             (("^prefix.*$") (string-append "prefix=" out "\n")))))
>
> Ditto.
>

OK.

>> +    (inputs `(("perl" ,perl))) ; Needed for the tests.
>
> ‘native-inputs’, probably (if it were being cross-compiled, you’d want
> to run the native Perl, right?).
>

Not sure about the difference between inputs and native-inputs. I think 
we may want to improve the documentation:

$ git grep native-inputs doc/
$


Cyril.