From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:49548) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1isE1c-0004Ho-1u for guix-patches@gnu.org; Thu, 16 Jan 2020 17:54:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1isE1a-0004sY-20 for guix-patches@gnu.org; Thu, 16 Jan 2020 17:54:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60834) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1isE1Z-0004sQ-Uh for guix-patches@gnu.org; Thu, 16 Jan 2020 17:54:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1isE1Z-0002V2-U3 for guix-patches@gnu.org; Thu, 16 Jan 2020 17:54:01 -0500 Subject: [bug#39086] [PATCH 3/5] gnu: Add unicode-cldr-common. Resent-Message-ID: Message-ID: <51f014f61bee4c453c50d954b501a3b1dc17370e.camel@student.tugraz.at> From: Leo Prikler Date: Thu, 16 Jan 2020 23:53:26 +0100 In-Reply-To: <87imlbxg7a.fsf@elephly.net> References: <20200111120829.29821-1-leo.prikler@student.tugraz.at> <20200111120829.29821-3-leo.prikler@student.tugraz.at> <87imlbxg7a.fsf@elephly.net> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ricardo Wurmus Cc: 39086@debbugs.gnu.org Am Donnerstag, den 16.01.2020, 22:08 +0100 schrieb Ricardo Wurmus: > Leo Prikler writes: > > > * gnu/packages/ibus (unicode-cldr-commmon): New package. > > This should be: > > * gnu/packages/ibus.scm (unicode-cldr-commmon): New variable. > > You know, I wonder if these things really belong to ibus.scm. I > remember a TODO somewhere in the code that bemoaned the lack of > versioned Unicode data files. Perhaps we should just add a new > module > (gnu packages unicode) — what do you think? I don't mind either way, but these packages don't fix the TODO. They add yet unseen features. > > +(define-public unicode-cldr-common > > + (package > > + (name "unicode-cldr-common") > > + (version "36") > > + (source > > + (origin (method url-fetch/zipbomb) > > + (uri " > > https://unicode.org/Public/cldr/36/cldr-common-36.0.zip") > > + (sha256 > > + (base32 > > + > > "0hxsc3j5zb32hmiaj0r3ajchmklx6zng6zlh1ca6s9plq5b9w9q7")))) > > The version should be “36.0”. The source URI should reference the > version field twice. The thing is, the Unicode people are really messy with their versioning, so I feel safer if I at least just use version once. Basically, they have 36/36.0, but 36.1/36.1, which makes no sense whatsoever. > > > + (description > > + "The Unicode Common Locale Data Repository (CLDR) is a large > > repository of > > +locale data, including among others > > +- patterns for formatting and parsing, > > +- name translations, > > +- and various informations on languages, scripts and country- > > specific > > +conventions.") > > + (license unicode))) > > Please use @enumerate or @itemize texinfo syntax here. Will do.