From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Pimentel Subject: Re: [PATCH] Update enlightenment.scm: Add Rage Player Date: Thu, 06 Aug 2015 11:33:15 -0300 Message-ID: <51c45e270bebd637d973b15aac200342@openmailbox.org> References: <87oailvn9g.fsf@elephly.net> <1d73da04df0affa581dbaeead8cb3f35@openmailbox.org> <87mvy5vmb0.fsf@elephly.net> <819f4e78a9c6821d32334d9e457aec33@openmailbox.org> <7c16d9a37b86038dfbb836b31bd7c8e6@openmailbox.org> <87pp30pka1.fsf@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49984) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNMEW-0006f2-NT for guix-devel@gnu.org; Thu, 06 Aug 2015 10:33:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZNMEQ-0006cR-Sb for guix-devel@gnu.org; Thu, 06 Aug 2015 10:33:24 -0400 Received: from smtp19.openmailbox.org ([62.4.1.53]:51663) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNMEQ-0006aD-Lu for guix-devel@gnu.org; Thu, 06 Aug 2015 10:33:18 -0400 In-Reply-To: <87pp30pka1.fsf@elephly.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel@gnu.org, guix-devel-bounces+d4n1=opmbx.org@gnu.org On 2015-08-06 11:24, Ricardo Wurmus wrote: > Thanks for the updated patch! >=20 >> * gnu/packages/enlightenment.scm: Add Rage. >=20 > This should really be: >=20 > * gnu/packages/enlightenment.scm (rage): New variable. >=20 > Other than that I have no important objections. I think this looks=20 > ugly > and could be improved, but I don=E2=80=99t think it=E2=80=99s very impo= rtant: >=20 >> + (uri >> + (string-append >> + =20 >> "http://download.enlightenment.org/rel/apps/rage/rage-" >> + version ".tar.gz")) >=20 > I=E2=80=99d put =E2=80=9C(uri (string-append ...=E2=80=9D on the same l= ine, pull part of the > string onto the same line and align the rest accordingly. >=20 > But I better leave the comments and the final decision to someone else. >=20 > ~~ Ricardo All right, I can change if necessary. I'll wait for it. Thanks, --=20 Daniel Pimentel (d4n1 3:)