From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id gHNBDMH++mbuSwEAe85BDQ:P1 (envelope-from ) for ; Mon, 30 Sep 2024 19:40:49 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id gHNBDMH++mbuSwEAe85BDQ (envelope-from ) for ; Mon, 30 Sep 2024 21:40:49 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=crRatbzL; dkim=none ("invalid DKIM record") header.d=freakingpenguin.com header.s=x header.b=UNg8Ec+0; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1727725249; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=1jo6+WF4bBGcbjmOBxVCfKIXyzA8vHW82dklTfIBMW4=; b=Oe0g7bpQ/DJdIg/h7oJcMUBkyQODOHV3fydW/yYs6bj6SHgt7+PzjuPbow3sCBeYxgTFAN u26b7jmuBhKjAAry5HQpb64NFdsXViKoZG3PTxwikbJKlbdkS/SshpHUr6wb3s++bmp4Cv PG7GG8b8alvKH1i6yeDhhJEduq6qtoc6oqaH/4z8JCGFNwKf9XWUBz2Eqfsx6nakNVbmJC Ew4M6zD3GlumFJBcLSBEwl+4YihdtvHt0P7HkjFWNEJ/4A6n6OVID59uQnAe1LtWkY7dbm i6k5M31TStdIJGeyEveb5ioAVp1SPTRGKfmeq4hs2Me/RwgXxT6JVJTo+HmOtw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=crRatbzL; dkim=none ("invalid DKIM record") header.d=freakingpenguin.com header.s=x header.b=UNg8Ec+0; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1727725249; a=rsa-sha256; cv=none; b=kSDfkJniLkV0QN+YLhPfNwGrlAZhKRqbmw2vuNpl99pj9FhJgYsHAlxdheh9iwqVLJ0aRH gL9Nc+3fzNRPK8BGYyBJxNCHbBIVwiaFLGWPzLpcBKaQD/bgv/DcTnJHe+Jai+jCcrKD2r S7ncGnEK9QvQGPVnBh6XlO93gd98eRAIz/uX8HEzWISdNK3AE8atcQ/2lFzORDTuiEwZqk R6zvrr5/hiYKGZ0wSWPN5banSYJK0NE+FPKMtmwiKHRhHT60ZzDf6sKZxvF/cSyftxy+sS aXyzmqBqL5YXF+os123mlanUyORlGFgwhgEZkK5D1cu8rESq4NuByXGPLNcqtw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BF4EB32C6F for ; Mon, 30 Sep 2024 21:40:48 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1svMG7-0006hf-TQ; Mon, 30 Sep 2024 15:40:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svMFx-0006gS-O6 for guix-patches@gnu.org; Mon, 30 Sep 2024 15:40:30 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1svMFx-0001zK-FN for guix-patches@gnu.org; Mon, 30 Sep 2024 15:40:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=1jo6+WF4bBGcbjmOBxVCfKIXyzA8vHW82dklTfIBMW4=; b=crRatbzLJRh1iw9HVgmyPJIZb/wKTlbI9bXxKsCkXWeIqlAOL1iMTmrptyeeYvUdU/29LFeGl7Fra6RyGgTNj/4FAYKZX8+wTWfz8FDv0Jp0YFb7PvZh48YeoUFEfU4oEoOIbksu212V1TKJaycg1guh2c5LKiYd7V5qAS8zsXw90dxk0sZEPvdUw9VeKTEJu7iMiSNdr2HA0PQxgdfhOX2MT+p+vLHRLXY+yEUhXTdOHQ2C1shT8JIUnzE+qUeIKQGz9Gna5y0gZJ8RzoUQkh9DSlO11H0c+1E4J8KZl9sgh/8PBpFwaXtJjo5yLrGDePO8iomG7TpjkvJfePE7bw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1svMGU-0003oE-6W for guix-patches@gnu.org; Mon, 30 Sep 2024 15:41:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#73570] [PATCH] gnu: ngspice: Preserve libngspice inputs. Resent-From: Richard Sent Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 30 Sep 2024 19:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 73570 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 73570@debbugs.gnu.org Cc: Richard Sent X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.172772522214111 (code B ref -1); Mon, 30 Sep 2024 19:41:01 +0000 Received: (at submit) by debbugs.gnu.org; 30 Sep 2024 19:40:22 +0000 Received: from localhost ([127.0.0.1]:46571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svMFp-0003fV-F2 for submit@debbugs.gnu.org; Mon, 30 Sep 2024 15:40:22 -0400 Received: from lists.gnu.org ([209.51.188.17]:44134) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svMFn-0003fP-1W for submit@debbugs.gnu.org; Mon, 30 Sep 2024 15:40:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svMFF-0006UB-Ml for guix-patches@gnu.org; Mon, 30 Sep 2024 15:39:45 -0400 Received: from mail-108-mta74.mxroute.com ([136.175.108.74]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1svMFE-0001l7-3V for guix-patches@gnu.org; Mon, 30 Sep 2024 15:39:45 -0400 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta74.mxroute.com (ZoneMTA) with ESMTPSA id 19244720c770003e01.001 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Mon, 30 Sep 2024 19:39:37 +0000 X-Zone-Loop: dd5fb042d9d2d391e967b597631d6e9ced9c6ca7c663 X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freakingpenguin.com; s=x; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1jo6+WF4bBGcbjmOBxVCfKIXyzA8vHW82dklTfIBMW4=; b=UNg8Ec+0RbS86lsBMohOJHKUuH SDUjUwGOFvQTriBijfIXaapjE3+JQFr1Cyt+bGh2lsH1vN3r+LUiC81L6dyTPyLXi5hKJL5DXzuUV abed3QtxzeIPhcpPEjmNGUn/B4CflBimq1ZtZbee/gnzgyKSMKLKqYKblJO8dmsJMvnc4cmHupVOP UihqC/SMqcuVnbvG5SEg81km+SxHLg05zm3a7V7FWiaRsLcmLGs/MStFL9JUIl2W99DvMcaC5TmbL jJHkF6bw2PJ/S0lQJWvtUOVZJg0RNmYEEqXGoFhep4pjgZAtzn+/kgu3KJ1HsdmhhHIHm+HY3HIzi Y5YEtdVQ==; From: Richard Sent Date: Mon, 30 Sep 2024 15:38:57 -0400 Message-ID: <51aa2d68e01d38caf5fe7652c6c4a6a204beab19.1727725137.git.richard@freakingpenguin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Authenticated-Id: richard@freakingpenguin.com Received-SPF: pass client-ip=136.175.108.74; envelope-from=richard@freakingpenguin.com; helo=mail-108-mta74.mxroute.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -5.32 X-Spam-Score: -5.32 X-Migadu-Queue-Id: BF4EB32C6F X-TUID: FZ16VOejYPj9 If inputs are lost between libngspice and ngspice, the configure script will emit warnings (e.g. bison) or disable functionality (libxaw and X11) in the executable. * gnu/packages/engineering.scm (ngspice): Modify libngspice inputs instead of replacing them. Change-Id: Ia66fcffba3032b0a37289c60ced12c98b705b548 --- Hi all, This fixes an issue where functionality in ngspice that should be enabled would be disabled, most notably X11 support. To test this, you can use this file: > .title dual rc ladder > * file name rcrcac.cir > R1 int in 10k > V1 in 0 dc 0 ac 1 PULSE (0 5 1u 1u 1u 1 1) > R2 out int 1k > C1 int 0 1u > C2 out 0 100n > > .control > ac dec 10 1 100k > # "Interactive" X11 output. > plot vdb(out) > plot ph(out) > .endc > > .end Without this patch, "$ guix shell ngspice -- ngspice file.cir" fails to display graphs, printing "Can't open viewport for graphics." This also fixes a couple warnings logged during the configure phase, e.g. bison not found. gnu/packages/engineering.scm | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm index db35c2532c..e046b6de07 100644 --- a/gnu/packages/engineering.scm +++ b/gnu/packages/engineering.scm @@ -41,6 +41,7 @@ ;;; Copyright © 2023 pinoaffe ;;; Copyright © 2024 Juliana Sims ;;; Copyright © 2024 Nguyễn Gia Phong +;;; Copyright © 2024 Richard Sent ;;; ;;; This file is part of GNU Guix. ;;; @@ -2095,8 +2096,14 @@ (define-public ngspice ((#:phases phases) #~(modify-phases #$phases (delete 'delete-scripts))))) - (native-inputs (list perl)) - (inputs (list libngspice readline)))) + (native-inputs (modify-inputs (package-native-inputs libngspice) + (prepend perl))) + (inputs (modify-inputs (package-inputs libngspice) + ;; Make sure libngspice inputs are preserved. The configure + ;; script will complain and potentially disable functionality if + ;; inputs are not found when the executable and library are + ;; built in separate steps. e.g. libxaw and X11 support. + (prepend libngspice readline))))) (define trilinos-serial-xyce ;; Note: This is a Trilinos containing only the packages Xyce needs, so we base-commit: ee64bcfb796ef36db4b63f79540627fb25f3320a -- 2.46.0