From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8EU+BMypgWArGwAAgWs5BA (envelope-from ) for ; Thu, 22 Apr 2021 18:52:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id QGAKAMypgWA3XwAAB5/wlQ (envelope-from ) for ; Thu, 22 Apr 2021 16:52:28 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 968431D0C5 for ; Thu, 22 Apr 2021 18:52:27 +0200 (CEST) Received: from localhost ([::1]:45612 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZcZ0-0001eP-8L for larch@yhetil.org; Thu, 22 Apr 2021 12:52:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57510) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZcOR-0001F0-Rr for guix-devel@gnu.org; Thu, 22 Apr 2021 12:41:31 -0400 Received: from laurent.telenet-ops.be ([2a02:1800:110:4::f00:19]:37308) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lZcON-0000D1-SR for guix-devel@gnu.org; Thu, 22 Apr 2021 12:41:31 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by laurent.telenet-ops.be with bizsmtp id vshR240060mfAB401shRhl; Thu, 22 Apr 2021 18:41:26 +0200 Message-ID: <5191616abad3114735ab49cc450299ee7603234b.camel@telenet.be> Subject: Re: [bug#47615] [PATCH v2 09/12] gnu: mercurial: Skip tests on powerpc-linux. From: Maxime Devos To: Efraim Flashner , 47615@debbugs.gnu.org, guix-devel@gnu.org Date: Thu, 22 Apr 2021 18:41:24 +0200 In-Reply-To: References: Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-qqYf5jMY5UJudis95kHN" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1619109686; bh=maSRFbpaJz7MIdlzCrvjBd3eFe7j831X14/gkTiLrTI=; h=Subject:From:To:Date:In-Reply-To:References; b=X2uRlNHHye3nICVeBIs9kckRCJV/lB7omS4XiiKwd1YgU71uwYacrDp1F1GglKliw WEjwvKC/oZnOOBHcm9shb84Gf2gnG0z8mQtloGHBIhjEfmmtrSiNydm+baI6GjkvWr PxdEn8fZ6u9O7N9AF+cM+thbcQj2y30rtdbxns5XHuNeCuLMKCBG3CAFNRt0Zo8Ciq c9XlbHtDVHA9JTJFuY5jMBEaSBRwux4neV+L2UsaX9JFWaBYxEQ55qNKOhSj0RjyCS sMtdRe5kLvrzXw+6ZO21Nu49VFzTNe6DdNM/CCf+7B7HRcZeNXTqvZ0T1KGKHUShOJ 0cGBvcaXGMspA== Received-SPF: pass client-ip=2a02:1800:110:4::f00:19; envelope-from=maximedevos@telenet.be; helo=laurent.telenet-ops.be X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619110347; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=maSRFbpaJz7MIdlzCrvjBd3eFe7j831X14/gkTiLrTI=; b=bjvdq+3Vw0fgnVpnF4HBKor5uEphbdESs1MveovQrPqat1jfYeGLcwPrNYe0d8yBfGtIRk ghnfA0GwN1dN/91sUwB+JdhPHG/ozBKWqnPz0lx/cKpJCj6AI1B3r3Jj+/laCnmg2k4L3J tv0iq32EHs9ToaCVoWl6Qe43HEXIGPq6+6yM0fRk1twQdRlXCLwUhFKcQASaguo5DDC5CT WBYlsrLLoLr+PEpu189ZXL4SNesKYkzao1OKzfdIb2laphNjkDGzG6EHuAZyRs/2Vh1T8g Kz/gBoZatYLq+rI8evdhS4tX08eYXlxEQYZf7c0s9EMTUSa00zut7rACOVxKeg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619110347; a=rsa-sha256; cv=none; b=CMYMdpOdXeybPGF5xwla4gyda5R/UyU9OLtG8ZoeYdGG8rcIBhw30Jcr/FmW4hgQSAtTMb wq8/b3J0VBmlZY0Z/RLYHznueQPEgF69yZFs2j9TskWWGBz/1+Z/H0Ass0ItN0TirK/M6S GUscyCrs9cDOuIdhunfqs2mimvOTHDODok7yL5IcpGoT+e6XghyESFrZZ9lMzcrNcdd7n3 AEvuNfQHgR60CsJ9a56+1cMZ3L/gfU0mg4VKf8+xmTeVU3IiKFmtlVen07hBCa6/x0v22X BDGY/DXUnlni+FfQNRpLcmkCUcGOLTqI5MrrLcRb1KsM3hwlG5oSEYoP2X3DTQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=telenet.be header.s=r21 header.b=X2uRlNHH; dmarc=pass (policy=none) header.from=telenet.be; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -5.24 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=telenet.be header.s=r21 header.b=X2uRlNHH; dmarc=pass (policy=none) header.from=telenet.be; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 968431D0C5 X-Spam-Score: -5.24 X-Migadu-Scanner: scn0.migadu.com X-TUID: YOxoYKbzFNgB --=-qqYf5jMY5UJudis95kHN Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Efraim Flashner schreef op do 22-04-2021 om 10:59 [+0300]: > * gnu/packages/version-control.scm (mercurial)[arguments]: Skip tests on > powerpc-linux. > --- > gnu/packages/version-control.scm | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) >=20 > Unchanged since last patchset, IMO not ready for upstreaming. >=20 > diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-cont= rol.scm > index 4d4b276a10..13e2ccd400 100644 > --- a/gnu/packages/version-control.scm > +++ b/gnu/packages/version-control.scm > @@ -1688,7 +1688,11 @@ execution of any hook written in any language befo= re every commit.") > "--slowtimeout" "86400" > ;; The test suite takes a long time and produce= s little > ;; output by default. Prevent timeouts due to = silence. > - "-v")))))))) > + "-v")))))) > + ;; Tests on powerpc-linux take more than 10 hours. > + #:tests? ,(if (string=3D? "powerpc-linux" (or (%current-system) > + (%current-target-syst= em))) > + '#f '#t))) You can remove ' in '#f and '#t here. That shouldn't cause a derivation change. Keeping ' is harmless though, it's just superfluous. Likewise for some other commits. I'm not really familiar with powerpc and the packages you modified, so I'm just looking at style, and cross-compilation issues (which you seem to have covered). Greetings, Maxime. --=-qqYf5jMY5UJudis95kHN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYIGnNRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7kzYAPwO0oVLatupc7GLouz0M5vbcZcO 6JeLKRu0eAINpZUsWQD9Eqw49oxr5oCjVVKI2918GHTXFdh5sO4fkHvZPkIFUw8= =gA75 -----END PGP SIGNATURE----- --=-qqYf5jMY5UJudis95kHN--