From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cyril Roelandt <tipecaml@gmail.com>
Subject: Re: [PATCH] gnu: Add dwm.
Date: Wed, 03 Apr 2013 23:41:55 +0200
Message-ID: <515CA223.5020408@gmail.com>
References: <1364769060-31557-1-git-send-email-tipecaml@gmail.com>
	<87wqskrpnq.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:59955)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tipecaml@gmail.com>) id 1UNVdd-0006jr-KP
	for bug-guix@gnu.org; Wed, 03 Apr 2013 17:54:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tipecaml@gmail.com>) id 1UNVdc-0008Cb-Bl
	for bug-guix@gnu.org; Wed, 03 Apr 2013 17:54:37 -0400
In-Reply-To: <87wqskrpnq.fsf@gnu.org>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
To: =?UTF-8?B?THVkb3ZpYyBDb3VydMOocw==?= <ludo@gnu.org>
Cc: bug-guix@gnu.org

On 04/03/2013 10:20 AM, Ludovic Courtès wrote:
>
> Cyril Roelandt<tipecaml@gmail.com>  skribis:
>
>> I had to turn '${CC}' into 'gcc' in the Makefile, because ${CC} was 'cc', and
>> there was no 'cc' command available. Would it make sense to create a symlink
>> when installing gcc ?
>
> Dunno.  It’s the first time we see this, no?
>

I think so. I'm not even sure why ${CC} is expanded to 'cc'.

>> +         (lambda* (#:key outputs #:allow-other-keys)
>> +          (let ((out (assoc-ref outputs "out")))
>> +           (zero?
>> +            (system* "make" "install"
>> +             (string-append "DESTDIR=" out) "PREFIX="))))
>
> “(string-append” should be aligned with "make".
>
> Is it really DESTDIR and not PREFIX that must be set?
>

I don't know. Usually, packages use either 'prefix' (as in "./configure 
--prefix=...") or 'destdir' (as in "make install DESTIR=...), but not 
both. What's the fundamental difference between them ?

>> +    (license "x11")))
>
> Typo: should be ‘x11’ (the variable).

Good catch!

Thanks for your review.


Cyril.