From: Cyril Roelandt <tipecaml@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: bug-guix@gnu.org
Subject: Re: [PATCH] gnu: Add dwm.
Date: Wed, 03 Apr 2013 23:41:55 +0200 [thread overview]
Message-ID: <515CA223.5020408@gmail.com> (raw)
In-Reply-To: <87wqskrpnq.fsf@gnu.org>
On 04/03/2013 10:20 AM, Ludovic Courtès wrote:
>
> Cyril Roelandt<tipecaml@gmail.com> skribis:
>
>> I had to turn '${CC}' into 'gcc' in the Makefile, because ${CC} was 'cc', and
>> there was no 'cc' command available. Would it make sense to create a symlink
>> when installing gcc ?
>
> Dunno. It’s the first time we see this, no?
>
I think so. I'm not even sure why ${CC} is expanded to 'cc'.
>> + (lambda* (#:key outputs #:allow-other-keys)
>> + (let ((out (assoc-ref outputs "out")))
>> + (zero?
>> + (system* "make" "install"
>> + (string-append "DESTDIR=" out) "PREFIX="))))
>
> “(string-append” should be aligned with "make".
>
> Is it really DESTDIR and not PREFIX that must be set?
>
I don't know. Usually, packages use either 'prefix' (as in "./configure
--prefix=...") or 'destdir' (as in "make install DESTIR=...), but not
both. What's the fundamental difference between them ?
>> + (license "x11")))
>
> Typo: should be ‘x11’ (the variable).
Good catch!
Thanks for your review.
Cyril.
prev parent reply other threads:[~2013-04-03 21:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-31 22:31 [PATCH] gnu: Add dwm Cyril Roelandt
2013-03-31 22:39 ` Cyril Roelandt
2013-04-03 8:22 ` Ludovic Courtès
2013-04-03 11:01 ` Nikita Karetnikov
2013-04-03 12:00 ` Ludovic Courtès
2013-04-03 20:34 ` Nikita Karetnikov
2013-04-04 16:49 ` Nikita Karetnikov
2013-04-03 8:20 ` Ludovic Courtès
2013-04-03 21:41 ` Cyril Roelandt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515CA223.5020408@gmail.com \
--to=tipecaml@gmail.com \
--cc=bug-guix@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.