From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cyril Roelandt <tipecaml@gmail.com>
Subject: Re: [PATCH] gnu: Add cmake.
Date: Fri, 15 Mar 2013 03:12:19 +0100
Message-ID: <51428383.90407@gmail.com>
References: <1363060349-19250-1-git-send-email-tipecaml@gmail.com>
	<87k3p9q3sx.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:48191)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tipecaml@gmail.com>) id 1UGKJt-0006LW-IT
	for bug-guix@gnu.org; Thu, 14 Mar 2013 22:24:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tipecaml@gmail.com>) id 1UGKJs-0008Ny-6p
	for bug-guix@gnu.org; Thu, 14 Mar 2013 22:24:33 -0400
In-Reply-To: <87k3p9q3sx.fsf@gnu.org>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
To: =?UTF-8?B?THVkb3ZpYyBDb3VydMOocw==?= <ludo@gnu.org>
Cc: bug-guix@gnu.org

On 03/14/2013 06:39 PM, Ludovic Courtès wrote:
> Cyril Roelandt<tipecaml@gmail.com>  skribis:
>
>> * gnu/packages/cmake.scm: New file.
>> * gnu/packages/patches/cmake-fix-tests.patch: New file.
>> * Makefile.am: Add them.
>
> Thanks!  Can you add a comment at the top of the patch saying what it
> does, why, with a pointer to any relevant mailing list discussion or
> documentation?
>

Sure.

> Ideally all patches should eventually be submitted upstream, but
> sometimes it’s not desirable, because the changes would too specific or
> intrusive.  State it in the patch if that is the case.
>

Here, these tests require network connectivity, so I don't think 
upstream will accept the patches.

> Other than that, looks good to me, so feel free to push then.
>
> It would be great to have a ‘cmake-build-system’, which would be based
> on ‘gnu-build-system’ but with specific ‘configure’ and ‘test’ phases.
> See guix/build-system/perl.scm and related files for an example.  :-)
>

I'll have to try and package a piece of software requiring cmake, then :)

Cyril.