From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:34546) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTF2Z-0007KC-5f for guix-patches@gnu.org; Mon, 27 Apr 2020 21:28:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTF2Y-0005MO-J5 for guix-patches@gnu.org; Mon, 27 Apr 2020 21:28:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55131) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jTF2Y-0005MJ-6g for guix-patches@gnu.org; Mon, 27 Apr 2020 21:28:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jTF2Y-000394-3A for guix-patches@gnu.org; Mon, 27 Apr 2020 21:28:02 -0400 Subject: [bug#40918] [PATCH] openjdk 14 package Resent-Message-ID: Received: from eggs.gnu.org ([2001:470:142:3::10]:34448) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTF1b-0007I2-41 for guix-patches@gnu.org; Mon, 27 Apr 2020 21:27:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTF1Z-00051Z-Qk for guix-patches@gnu.org; Mon, 27 Apr 2020 21:27:02 -0400 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]:54293) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jTF1Z-00051M-Ay for guix-patches@gnu.org; Mon, 27 Apr 2020 21:27:01 -0400 Received: by mail-pj1-x1034.google.com with SMTP id y6so403018pjc.4 for ; Mon, 27 Apr 2020 18:27:00 -0700 (PDT) Received: from ?IPv6:2001:44b8:203:1200:be5f:f4ff:fef7:7bdc? (2001-44b8-0203-1200-be5f-f4ff-fef7-7bdc.static.ipv6.internode.on.net. [2001:44b8:203:1200:be5f:f4ff:fef7:7bdc]) by smtp.googlemail.com with ESMTPSA id i9sm13485671pfk.199.2020.04.27.18.26.57 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Apr 2020 18:26:58 -0700 (PDT) From: Michael Zucchi Message-ID: <50eb5354-39d1-ee49-6f4e-78dd26862aa1@gmail.com> Date: Tue, 28 Apr 2020 10:56:55 +0930 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------8F6112D69ACE10A54DFDF439" Content-Language: en-AU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 40918@debbugs.gnu.org This is a multi-part message in MIME format. --------------8F6112D69ACE10A54DFDF439 Content-Type: multipart/alternative; boundary="------------C0A4686308900235DD54ADFB" --------------C0A4686308900235DD54ADFB Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit This mostly is just a simple copy of openjdk12 with changed links. openjdk13 is also included as it must be used to bootstrap openjdk14. openjdk14 uses "help" as a rather poor choice of autoconf test for the availability of a shell builtin and this isn't available in bash-minimal, so a small patch is needed to make configure complete. I've contacted the openjdk developers with a suggested change but so far have had no response after a couple of business days. --------------C0A4686308900235DD54ADFB Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit
This mostly is just a simple copy of openjdk12 with changed links. openjdk13 is also included as it must be used to bootstrap openjdk14.

openjdk14 uses "help" as a rather poor choice of autoconf test for the availability of a shell builtin and this isn't available in bash-minimal, so a small patch is needed to make configure complete. I've contacted the openjdk developers with a suggested change but so far have had no response after a couple of business days.

--------------C0A4686308900235DD54ADFB-- --------------8F6112D69ACE10A54DFDF439 Content-Type: text/x-patch; name="0001-gnu-packages-java.scm-openjdk13-opnejdk14.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-gnu-packages-java.scm-openjdk13-opnejdk14.patch" RnJvbSA3ZjhmOTBlZWE4YzNlYjlkMTA0ZTdkOWE4NjU4OTdmMjQ1NmQxNGEzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBOb3QgWmVkIDxub3R6ZWRAZ21haWwuY29tPgpEYXRl OiBUdWUsIDI4IEFwciAyMDIwIDEwOjMzOjQ2ICswOTMwClN1YmplY3Q6IFtQQVRDSF0gICAg ICAgICAqIGdudS9wYWNrYWdlcy9qYXZhLnNjbSAob3BlbmpkazEzLCBvcG5lamRrMTQpICAg ICAgIAogICogZ251L3BhY2thZ2VzL3BhdGNoZXMvb3Blbmpkay0xNC1idWlsdGlucy5wYXRj aDogQWRkZWQgb3BlbmpkayAxMyBhbmQgICAgICAKICAgMTQuCgotLS0KIGdudS9wYWNrYWdl cy9qYXZhLnNjbSAgICAgICAgICAgICAgICAgICAgICAgICB8IDkzICsrKysrKysrKysrKysr KysrKysKIC4uLi9wYXRjaGVzL29wZW5qZGstMTQtYnVpbHRpbnMucGF0Y2ggICAgICAgICB8 IDExICsrKwogMiBmaWxlcyBjaGFuZ2VkLCAxMDQgaW5zZXJ0aW9ucygrKQogY3JlYXRlIG1v ZGUgMTAwNjQ0IGdudS9wYWNrYWdlcy9wYXRjaGVzL29wZW5qZGstMTQtYnVpbHRpbnMucGF0 Y2gKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvamF2YS5zY20gYi9nbnUvcGFja2FnZXMv amF2YS5zY20KaW5kZXggY2FiOTBmYjRlNy4uNDFjMmUzYzU0NyAxMDA2NDQKLS0tIGEvZ251 L3BhY2thZ2VzL2phdmEuc2NtCisrKyBiL2dudS9wYWNrYWdlcy9qYXZhLnNjbQpAQCAtMjI1 MCw2ICsyMjUwLDk5IEBAIG5ldyBEYXRlKCk7IikpCiAgICAgICAgKCJ6aXAiICx6aXApKSkK ICAgICAoaG9tZS1wYWdlICJodHRwczovL29wZW5qZGsuamF2YS5uZXQvcHJvamVjdHMvamRr LzEyIikpKQogCisoZGVmaW5lLXB1YmxpYyBvcGVuamRrMTMKKyAgKHBhY2thZ2UKKyAgICAo aW5oZXJpdCBvcGVuamRrMTEpCisgICAgKG5hbWUgIm9wZW5qZGsiKQorICAgICh2ZXJzaW9u ICIxMy4wIikKKyAgICAoc291cmNlIChvcmlnaW4KKwkgICAgIChtZXRob2QgdXJsLWZldGNo KQorCSAgICAgKHVyaSAiaHR0cDovL2hnLm9wZW5qZGsuamF2YS5uZXQvamRrL2pkazEzL2Fy Y2hpdmUvOWMyNTBhNzYwMGUxLnRhci5iejIiKQorCSAgICAgKGZpbGUtbmFtZSAoc3RyaW5n LWFwcGVuZCBuYW1lICItIiB2ZXJzaW9uICIudGFyLmJ6MiIpKQorCSAgICAgKHNoYTI1Ngor CSAgICAgIChiYXNlMzIKKwkgICAgICAgIjB2MGxqdng1ZHl6cDk2ZHc0ejRrc3czcHZhc2ls Nzc4M21nbm1kMXdrOWdhZHM1YWI4aXEiKSkKKwkgICAgIChtb2R1bGVzICcoKGd1aXggYnVp bGQgdXRpbHMpKSkKKwkgICAgIChzbmlwcGV0CisJICAgICAgYChiZWdpbgorCQkgKGZvci1l YWNoIGRlbGV0ZS1maWxlIChmaW5kLWZpbGVzICIuIiAiLiouYmluJCIpKQorCQkgKGZvci1l YWNoIGRlbGV0ZS1maWxlIChmaW5kLWZpbGVzICIuIiAiLiouZXhlJCIpKQorCQkgKGZvci1l YWNoIGRlbGV0ZS1maWxlIChmaW5kLWZpbGVzICIuIiAiLiouamFyJCIpKQorCQkgI3QpKSkp CisgICAgKGlucHV0cworICAgICBgKCgiYWxzYS1saWIiICxhbHNhLWxpYikKKyAgICAgICAo ImN1cHMiICxjdXBzKQorICAgICAgICgiZm9udGNvbmZpZyIgLGZvbnRjb25maWcpCisgICAg ICAgKCJmcmVldHlwZSIgLGZyZWV0eXBlKQorICAgICAgICgiZ2lmbGliIiAsZ2lmbGliKQor ICAgICAgICgibGNtcyIgLGxjbXMpCisgICAgICAgKCJsaWJqcGVnIiAsbGlianBlZykKKyAg ICAgICAoImxpYnBuZyIgLGxpYnBuZykKKyAgICAgICAoImxpYngxMSIgLGxpYngxMSkKKyAg ICAgICAoImxpYnhleHQiICxsaWJ4ZXh0KQorICAgICAgICgibGlieHJhbmRyIiAsbGlieHJh bmRyKQorICAgICAgICgibGlieHJlbmRlciIgLGxpYnhyZW5kZXIpCisgICAgICAgKCJsaWJ4 dCIgLGxpYnh0KQorICAgICAgICgibGlieHRzdCIgLGxpYnh0c3QpKSkKKyAgICA7OyBvcGVu amRrMTMgbXVzdCBiZSBib290c3RyYXBwZWQgd2l0aCBqYXZhIDEyIG9yIDEzCisgICAgKG5h dGl2ZS1pbnB1dHMKKyAgICAgYCgoImF1dG9jb25mIiAsYXV0b2NvbmYpCisgICAgICAgKCJv cGVuamRrMTIiICxvcGVuamRrMTEpCisgICAgICAgKCJvcGVuamRrMTI6amRrIiAsb3Blbmpk azEyICJqZGsiKQorICAgICAgICgicGtnLWNvbmZpZyIgLHBrZy1jb25maWcpCisgICAgICAg KCJ1bnppcCIgLHVuemlwKQorICAgICAgICgid2hpY2giICx3aGljaCkKKyAgICAgICAoInpp cCIgLHppcCkpKQorICAgIChob21lLXBhZ2UgImh0dHBzOi8vb3Blbmpkay5qYXZhLm5ldC9w cm9qZWN0cy9qZGsvMTMiKSkpCisKKyhkZWZpbmUtcHVibGljIG9wZW5qZGsxNAorICAocGFj a2FnZQorICAgIChpbmhlcml0IG9wZW5qZGsxMSkKKyAgICAobmFtZSAib3BlbmpkayIpCisg ICAgKHZlcnNpb24gIjE0LjAiKQorICAgIChzb3VyY2UgKG9yaWdpbgorCSAgICAgKG1ldGhv ZCB1cmwtZmV0Y2gpCisJICAgICAodXJpICJodHRwOi8vaGcub3Blbmpkay5qYXZhLm5ldC9q ZGsvamRrMTQvYXJjaGl2ZS9iYzU0NjIwYTM4NDgudGFyLmJ6MiIpCisJICAgICAoZmlsZS1u YW1lIChzdHJpbmctYXBwZW5kIG5hbWUgIi0iIHZlcnNpb24gIi50YXIuYnoyIikpCisJICAg ICAoc2hhMjU2CisJICAgICAgKGJhc2UzMgorCSAgICAgICAiMHo0ODVwazdyMXhwdzgwMDRn NG5yd3J6ajE3c2FiZ3g4eWZkYnh3ZnZ6a2pwOHF5YWpjaCIpKQorCSAgICAgOzsgb3Blbmpk azE0IGF1dG9jb25mIHVzZXMgJ2hlbHAnIHRvIHNlYXJjaCBmb3IgYnVpbHRpbnMsIG5vdCBh dmFpbGFibGUgaW4gYmFzaC1taW5pbWFsCisJICAgICAocGF0Y2hlcworCSAgICAgIChzZWFy Y2gtcGF0Y2hlcyAib3Blbmpkay0xNC1idWlsdGlucy5wYXRjaCIpKQorCSAgICAgKG1vZHVs ZXMgJygoZ3VpeCBidWlsZCB1dGlscykpKQorCSAgICAgKHNuaXBwZXQKKwkgICAgICBgKGJl Z2luCisJCSAoZm9yLWVhY2ggZGVsZXRlLWZpbGUgKGZpbmQtZmlsZXMgIi4iICIuKi5iaW4k IikpCisJCSAoZm9yLWVhY2ggZGVsZXRlLWZpbGUgKGZpbmQtZmlsZXMgIi4iICIuKi5leGUk IikpCisJCSAoZm9yLWVhY2ggZGVsZXRlLWZpbGUgKGZpbmQtZmlsZXMgIi4iICIuKi5qYXIk IikpCisJCSAjdCkpKSkKKyAgICAoaW5wdXRzCisgICAgIGAoKCJhbHNhLWxpYiIgLGFsc2Et bGliKQorICAgICAgICgiY3VwcyIgLGN1cHMpCisgICAgICAgKCJmb250Y29uZmlnIiAsZm9u dGNvbmZpZykKKyAgICAgICAoImZyZWV0eXBlIiAsZnJlZXR5cGUpCisgICAgICAgKCJnaWZs aWIiICxnaWZsaWIpCisgICAgICAgKCJsY21zIiAsbGNtcykKKyAgICAgICAoImxpYmpwZWci ICxsaWJqcGVnKQorICAgICAgICgibGlicG5nIiAsbGlicG5nKQorICAgICAgICgibGlieDEx IiAsbGlieDExKQorICAgICAgICgibGlieGV4dCIgLGxpYnhleHQpCisgICAgICAgKCJsaWJ4 cmFuZHIiICxsaWJ4cmFuZHIpCisgICAgICAgKCJsaWJ4cmVuZGVyIiAsbGlieHJlbmRlcikK KyAgICAgICAoImxpYnh0IiAsbGlieHQpCisgICAgICAgKCJsaWJ4dHN0IiAsbGlieHRzdCkp KQorICAgIDs7IG9wZW5qZGsxNCBtdXN0IGJlIGJvb3RzdHJhcHBlZCB3aXRoIGphdmEgMTMg b3IgMTQKKyAgICAobmF0aXZlLWlucHV0cworICAgICBgKCgiYXV0b2NvbmYiICxhdXRvY29u ZikKKyAgICAgICAoIm9wZW5qZGsxMyIgLG9wZW5qZGsxMSkKKyAgICAgICAoIm9wZW5qZGsx MzpqZGsiICxvcGVuamRrMTMgImpkayIpCisgICAgICAgKCJwa2ctY29uZmlnIiAscGtnLWNv bmZpZykKKyAgICAgICAoInVuemlwIiAsdW56aXApCisgICAgICAgKCJ3aGljaCIgLHdoaWNo KQorICAgICAgICgiemlwIiAsemlwKSkpCisgICAgKGhvbWUtcGFnZSAiaHR0cHM6Ly9vcGVu amRrLmphdmEubmV0L3Byb2plY3RzL2pkay8xNCIpKSkKKwogKGRlZmluZS1wdWJsaWMgaWNl ZHRlYSBpY2VkdGVhLTgpCiAKIAwKZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9wYXRjaGVz L29wZW5qZGstMTQtYnVpbHRpbnMucGF0Y2ggYi9nbnUvcGFja2FnZXMvcGF0Y2hlcy9vcGVu amRrLTE0LWJ1aWx0aW5zLnBhdGNoCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAuLjBlN2UzZGNhYTkKLS0tIC9kZXYvbnVsbAorKysgYi9nbnUvcGFja2FnZXMvcGF0 Y2hlcy9vcGVuamRrLTE0LWJ1aWx0aW5zLnBhdGNoCkBAIC0wLDAgKzEsMTEgQEAKKy0tLSBq ZGsxNC1iYzU0NjIwYTM4NDgvbWFrZS9hdXRvY29uZi9iYXNpY3MubTQJMjAyMC0wMi0wNyAw NDo0MDo1NC4wMDAwMDAwMDAgKzEwMzAKKysrKyBqZGsxNC1iYzU0NjIwYTM4NDgtbmV3L21h a2UvYXV0b2NvbmYvYmFzaWNzLm00CTIwMjAtMDQtMjQgMTA6NTk6MzMuMDU2MDk4NTA2ICsw OTMwCitAQCAtNTgzLDcgKzU4Myw3IEBACisgICBCQVNJQ19TRVRVUF9UT09MKCQxLCBbQUNf UEFUSF9QUk9HUygkMSwgJDIsICwgJDMpXSkKKyAgIGlmIHRlc3QgInhbJF0kMSIgPSB4OyB0 aGVuCisgICAgIEFDX01TR19OT1RJQ0UoW1JlcXVpcmVkIHRvb2wgJDIgbm90IGZvdW5kIGlu IFBBVEgsIGNoZWNraW5nIGJ1aWx0LWluXSkKKy0gICAgaWYgaGVscCAkMiA+IC9kZXYvbnVs bCAyPiYxOyB0aGVuCisrICAgIGlmIGNvbW1hbmQgLXYgJDIgPiAvZGV2L251bGwgMj4mMTsg dGhlbgorICAgICAgIEFDX01TR19OT1RJQ0UoW0ZvdW5kICQyIGFzIHNoZWxsIGJ1aWx0LWlu LiBVc2luZyBpdF0pCisgICAgICAgJDE9IiQyIgorICAgICBlbHNlCi0tIAoyLjI2LjIKCg== --------------8F6112D69ACE10A54DFDF439-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:35012) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTF9L-0004zL-93 for guix-patches@gnu.org; Mon, 27 Apr 2020 21:35:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTF9K-000717-S8 for guix-patches@gnu.org; Mon, 27 Apr 2020 21:35:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55137) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jTF9K-000710-FM for guix-patches@gnu.org; Mon, 27 Apr 2020 21:35:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jTF9K-0003L6-Be for guix-patches@gnu.org; Mon, 27 Apr 2020 21:35:02 -0400 Subject: [bug#40918] update References: <50eb5354-39d1-ee49-6f4e-78dd26862aa1@gmail.com> In-Reply-To: <50eb5354-39d1-ee49-6f4e-78dd26862aa1@gmail.com> Resent-Message-ID: From: Michael Zucchi Message-ID: Date: Tue, 28 Apr 2020 11:04:05 +0930 MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="------------FE2A47467E653AD05C797913" Content-Language: en-AU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 40918@debbugs.gnu.org This is a multi-part message in MIME format. --------------FE2A47467E653AD05C797913 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sorry I missed a response from openjdk about the requested config change so I will follow that up and create another patch once it has filtered through their system since that shouldn't need a config patch to work. --------------FE2A47467E653AD05C797913 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit

Sorry I missed a response from openjdk about the requested config change so I will follow that up and create another patch once it has filtered through their system since that shouldn't need a config patch to work.

--------------FE2A47467E653AD05C797913-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:56040) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTYtX-0007N6-RT for guix-patches@gnu.org; Tue, 28 Apr 2020 18:40:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTYtX-0004jv-5Q for guix-patches@gnu.org; Tue, 28 Apr 2020 18:40:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58517) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jTYtW-0004iO-Or for guix-patches@gnu.org; Tue, 28 Apr 2020 18:40:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jTYtW-00078N-MR for guix-patches@gnu.org; Tue, 28 Apr 2020 18:40:02 -0400 Subject: [bug#40918] [PATCH] openjdk 14 package Resent-Message-ID: Date: Wed, 29 Apr 2020 00:38:59 +0200 From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Message-ID: <20200429003859.3abd5a7a@alma-ubu> In-Reply-To: <50eb5354-39d1-ee49-6f4e-78dd26862aa1@gmail.com> References: <50eb5354-39d1-ee49-6f4e-78dd26862aa1@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/Lr/A6N2ltIoyZKr0mjciHrb"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Michael Zucchi Cc: 40918@debbugs.gnu.org --Sig_/Lr/A6N2ltIoyZKr0mjciHrb Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, 28 Apr 2020 10:56:55 +0930 Michael Zucchi wrote: >=20 > This mostly is just a simple copy of openjdk12 with changed links.=C2=A0= =20 > openjdk13 is also included as it must be used to bootstrap openjdk14. >=20 > openjdk14 uses "help" as a rather poor choice of autoconf test for > the availability of a shell builtin and this isn't available in=20 > bash-minimal, so a small patch is needed to make configure complete.=C2= =A0=20 > I've contacted the openjdk developers with a suggested change but so > far have had no response after a couple of business days. >=20 >=20 Hi Michael, thank you for your patch. When sending in the second version of your patch, could you please split up the commits, having one distinct commit per added/changed package. Please update your commit message according to the Changelog-style. You will find examples in the old commit logs, for example for how to add the patch-file. Excited to see your second version, Bj=C3=B6rn --Sig_/Lr/A6N2ltIoyZKr0mjciHrb Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQQiGUP0np8nb5SZM4K/KGy2WT5f/QUCXqiwhAAKCRC/KGy2WT5f /SWpAKC7FtMhlT7o8UFPWPS/zFR4DoSekwCfVf7ellcu5tA+C0yAyec2VS+OAE4= =+a/0 -----END PGP SIGNATURE----- --Sig_/Lr/A6N2ltIoyZKr0mjciHrb-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:34888) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTZxL-0006YN-8Y for guix-patches@gnu.org; Tue, 28 Apr 2020 19:48:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTZxK-0001SP-Nv for guix-patches@gnu.org; Tue, 28 Apr 2020 19:48:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58569) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jTZxK-0001SK-C2 for guix-patches@gnu.org; Tue, 28 Apr 2020 19:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jTZxK-0000LB-9K for guix-patches@gnu.org; Tue, 28 Apr 2020 19:48:02 -0400 Subject: [bug#40918] [PATCH] openjdk 14 package Resent-Message-ID: References: <50eb5354-39d1-ee49-6f4e-78dd26862aa1@gmail.com> <20200429003859.3abd5a7a@alma-ubu> From: Michael Zucchi Message-ID: Date: Wed, 29 Apr 2020 09:17:22 +0930 MIME-Version: 1.0 In-Reply-To: <20200429003859.3abd5a7a@alma-ubu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-AU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Cc: 40918@debbugs.gnu.org On 29/4/20 8:08 am, Björn Höfling wrote: > On Tue, 28 Apr 2020 10:56:55 +0930 > Michael Zucchi wrote: > >> This mostly is just a simple copy of openjdk12 with changed links. >> openjdk13 is also included as it must be used to bootstrap openjdk14. >> >> openjdk14 uses "help" as a rather poor choice of autoconf test for >> the availability of a shell builtin and this isn't available in >> bash-minimal, so a small patch is needed to make configure complete. >> I've contacted the openjdk developers with a suggested change but so >> far have had no response after a couple of business days. >> >> > Hi Michael, > > thank you for your patch. > > When sending in the second version of your > patch, could you please split up the commits, having one distinct > commit per added/changed package. > > Please update your commit message according to the Changelog-style. You > will find examples in the old commit logs, for example for how to add > the patch-file. > > Excited to see your second version, > > Björn > I'm sorry i don't understand your second point, i used emacs changelog mode to create the commit message. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id iKi4NIjrqV7yCAAA0tVLHw (envelope-from ) for ; Wed, 29 Apr 2020 21:03:04 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id kGtGCZHrqV64ZgAAB5/wlQ (envelope-from ) for ; Wed, 29 Apr 2020 21:03:13 +0000 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:470:142::17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5C53B9408BA for ; Wed, 29 Apr 2020 21:03:12 +0000 (UTC) Received: from localhost ([::1]:38418 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTtrL-0004Iu-Vs for larch@yhetil.org; Wed, 29 Apr 2020 17:03:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57324) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTtrG-0004GK-5R for guix-patches@gnu.org; Wed, 29 Apr 2020 17:03:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTtrD-0000k5-6y for guix-patches@gnu.org; Wed, 29 Apr 2020 17:03:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33254) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jTtrC-0000jy-Qn for guix-patches@gnu.org; Wed, 29 Apr 2020 17:03:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jTtrC-0007AZ-FC for guix-patches@gnu.org; Wed, 29 Apr 2020 17:03:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#40918] [PATCH] openjdk 14 package Resent-From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 29 Apr 2020 21:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40918 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Michael Zucchi Cc: 40918@debbugs.gnu.org Received: via spool by 40918-submit@debbugs.gnu.org id=B40918.158819413727505 (code B ref 40918); Wed, 29 Apr 2020 21:03:02 +0000 Received: (at 40918) by debbugs.gnu.org; 29 Apr 2020 21:02:17 +0000 Received: from localhost ([127.0.0.1]:44800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTtqF-00079M-NK for submit@debbugs.gnu.org; Wed, 29 Apr 2020 17:02:16 -0400 Received: from m4s11.vlinux.de ([83.151.27.109]:59064 helo=bjoernhoefling.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTtqA-00078t-Fh for 40918@debbugs.gnu.org; Wed, 29 Apr 2020 17:02:02 -0400 Received: from alma-ubu (p508ACF57.dip0.t-ipconnect.de [80.138.207.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bjoernhoefling.de (Postfix) with ESMTPSA id 74C0D3F886; Wed, 29 Apr 2020 23:01:56 +0200 (CEST) Date: Wed, 29 Apr 2020 23:01:55 +0200 From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Message-ID: <20200429230155.0e4f53d9@alma-ubu> In-Reply-To: References: <50eb5354-39d1-ee49-6f4e-78dd26862aa1@gmail.com> <20200429003859.3abd5a7a@alma-ubu> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/5/s_lp=5QHS/KFhQZzJMNMm"; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 X-Spam-Score: 0.64 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 2001:470:142::17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Scan-Result: default: False [0.64 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.49348679104521]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:142::/48:c]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.17), country: US(-0.00), ip: 2001:470:142::17(-0.49)]; DWL_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; RCPT_COUNT_TWO(0.00)[2]; MAILLIST(-0.20)[mailman]; FREEMAIL_TO(0.00)[gmail.com]; RCVD_IN_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; MIME_TRACE(0.00)[0:+,1:+,2:~]; R_MIXED_CHARSET(1.25)[subject]; ASN(0.00)[asn:22989, ipnet:2001:470:142::/48, country:US]; R_DKIM_NA(0.00)[]; TAGGED_FROM(0.00)[larch=yhetil.org]; ARC_NA(0.00)[]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; FROM_NEQ_ENVFROM(0.00)[bjoern.hoefling@bjoernhoefling.de,guix-patches-bounces@gnu.org]; FROM_HAS_DN(0.00)[]; URIBL_BLOCKED(0.00)[gnu.org:url]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[bjoernhoefling.de]; HAS_LIST_UNSUB(-0.01)[]; RECEIVED_SPAMHAUS_PBL(0.00)[80.138.207.87:received]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_COUNT_SEVEN(0.00)[9]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: vdA3GyIpG4xf --Sig_/5/s_lp=5QHS/KFhQZzJMNMm Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Michael, On Wed, 29 Apr 2020 09:17:22 +0930 Michael Zucchi wrote: > > Please update your commit message according to the Changelog-style. > > You will find examples in the old commit logs, for example for how > > to add the patch-file. > I'm sorry i don't understand your second point, i used emacs > changelog mode to create the commit message. Let me try to explain that in more details. Guix is the pickiest project I came along when it comes to commit messages. It took me a while to get used to it. So please this shouldn't be a show-stopper for you :-) In the end, a commiter can/will correct it. Your git log consists of only one line: * gnu/packages/java.scm (openjdk13, opnejdk14) * gnu/packages/patches/openj= dk-14-builtins.patch: Added openjdk 13 and 14. I would have expected something like: ----BEGIN EXAMPLE--- gnu: Add openjdk14. * gnu/packages/java.scm (openjdk14): New variable. * gnu/packages/patches/openjdk...patch: New file. * gnu/local.mk (dist_patch_DATA): Add it. ----END EXAMPLE--- So you really document every file you add, every variable/location where you change something. It is somewhat explained here, but at best look through older commits: https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html#Submitting= -Patches https://www.gnu.org/prep/standards/html_node/Change-Logs.html#Change-Logs Hope this explains it better, Bj=C3=B6rn --Sig_/5/s_lp=5QHS/KFhQZzJMNMm Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQQiGUP0np8nb5SZM4K/KGy2WT5f/QUCXqnrQwAKCRC/KGy2WT5f /c/zAKC4cWym22SW9/KCknlAKmt0L1nNYgCbBi9nsLCHmR3ou+CDrxjrUYW7I3M= =ii1c -----END PGP SIGNATURE----- --Sig_/5/s_lp=5QHS/KFhQZzJMNMm-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 7OwsMXy4v159TAAA0tVLHw (envelope-from ) for ; Sat, 16 May 2020 09:55:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id GPWELHy4v16lEAAAB5/wlQ (envelope-from ) for ; Sat, 16 May 2020 09:55:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AB2D5940B30 for ; Sat, 16 May 2020 09:55:07 +0000 (UTC) Received: from localhost ([::1]:56776 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZtX7-0007Dh-Gk for larch@yhetil.org; Sat, 16 May 2020 05:55:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59456) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZtX4-0007DT-F0 for guix-patches@gnu.org; Sat, 16 May 2020 05:55:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56475) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jZtX4-0007Af-61 for guix-patches@gnu.org; Sat, 16 May 2020 05:55:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jZtX3-0005Rh-U4 for guix-patches@gnu.org; Sat, 16 May 2020 05:55:01 -0400 Subject: bug#40918: [PATCH] openjdk 14 package Resent-From: Ricardo Wurmus Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Sat, 16 May 2020 09:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 40918 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Michael Zucchi , 40918-done@debbugs.gnu.org Cc: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Mail-Followup-To: 40918@debbugs.gnu.org, rekado@elephly.net, notzed@gmail.com Received: via spool by 40918-done@debbugs.gnu.org id=D40918.158962285220860 (code D ref 40918); Sat, 16 May 2020 09:55:01 +0000 Received: (at 40918-done) by debbugs.gnu.org; 16 May 2020 09:54:12 +0000 Received: from localhost ([127.0.0.1]:39788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZtWF-0005QO-Nb for submit@debbugs.gnu.org; Sat, 16 May 2020 05:54:11 -0400 Received: from sender4-of-o53.zoho.com ([136.143.188.53]:21327) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZtWD-0005QG-O0 for 40918-done@debbugs.gnu.org; Sat, 16 May 2020 05:54:10 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1589622846; cv=none; d=zohomail.com; s=zohoarc; b=nSefX/9M8YBnKGYoouyq7xMkTPIAup6OWF8kso5BZT2euK9942TrarbUaSIL2JfdCBpnV6BLEwCjulFYqJAj8A5aR+g3Sxd5qcJwKXC3piT526fgQdLR4GV12Kro0CAVOZ5drC5K6ssKv3pzUfNAdgIZiCkf8VWi8oMViH/tv8Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1589622846; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=P1+yE2f3jhWGqqd6FlY4NbzDLbiVzvVCaWu9LJfiRnw=; b=MdShrcaZpXOJ6z8tIXIO1Jy6PmqWRCzwMNmpVYQpUhtgF8JYvRkANmsFqQLcGQwYGJv/5+NOWE1G/EaVaPnJB9gDqdHd8DY/6c4zOtShGxAESh1GfaN/SIYYAxiufT9cHB93i7ixd9I6S8jogstUDX1OtUGdHK5jhYWsM/WVgIg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1589622846; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=P1+yE2f3jhWGqqd6FlY4NbzDLbiVzvVCaWu9LJfiRnw=; b=LoIJI6IHWQzp4UmNHEluS2G0O7rFHVYCnqSAuUUV25loj6RMIxIHVF5QV+E/RoJy uDGzfycsJKFXhiYP+XWDiaLvR7+KLbwcuJ3xkxszRppZmZOmOYtWfhJ9fTUZCqybx0w +F/DNDrLIGYUYLYsjD9xHeKZhjO68LqwFO2e8B6Y= Received: from localhost (p4fd5a867.dip0.t-ipconnect.de [79.213.168.103]) by mx.zohomail.com with SMTPS id 1589622845153862.7954734762994; Sat, 16 May 2020 02:54:05 -0700 (PDT) References: <50eb5354-39d1-ee49-6f4e-78dd26862aa1@gmail.com> <20200429003859.3abd5a7a@alma-ubu> <20200429230155.0e4f53d9@alma-ubu> User-agent: mu4e 1.4.4; emacs 26.3 From: Ricardo Wurmus In-reply-to: <20200429230155.0e4f53d9@alma-ubu> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Sat, 16 May 2020 11:54:01 +0200 Message-ID: <87wo5cgq86.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=elephly.net header.s=zoho header.b=LoIJI6IH; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 1.99 X-TUID: l0cKfq3fLuOt Hi Michael, thank you for your contribution! I=E2=80=99ve split the commit into two (one for each package addition), rep= laced the patch with a substitution, simplified the snippet, removed unused inputs, used libjpeg-turbo instead of libjpeg, and corrected the commit message. I=E2=80=99ve pushed the two commits to the master branch: --8<---------------cut here---------------start------------->8--- commit 65a11a59de86fa759f2ffbb7db53430a6727c2ea Author: Not Zed gnu: Add openjdk14. =20=20=20=20 * gnu/packages/java.scm (openjdk14): New variable. =20=20=20=20 Signed-off-by: Ricardo Wurmus commit c4618174ecb6375849529f1d1026585817bb139e Author: Not Zed gnu: Add openjdk13. =20=20=20=20 * gnu/packages/java.scm (openjdk13): New variable. =20=20=20=20 Signed-off-by: Ricardo Wurmus --8<---------------cut here---------------end--------------->8--- Thanks again! --=20 Ricardo