From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56955)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dW65K-00087A-5i
	for guix-patches@gnu.org; Fri, 14 Jul 2017 15:17:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dW65H-0006XB-26
	for guix-patches@gnu.org; Fri, 14 Jul 2017 15:17:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:36641)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dW65G-0006VY-ME
	for guix-patches@gnu.org; Fri, 14 Jul 2017 15:17:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dW65G-00068I-B2
	for guix-patches@gnu.org; Fri, 14 Jul 2017 15:17:02 -0400
Subject: [bug#27657] [PATCH 3/3] gnu: wayland: Add workaround for graphviz
	2.40.1.
Resent-Message-ID: <handler.27657.B27657.150005978823527@debbugs.gnu.org>
Message-Id: <4f721a8c.ADkAACRbFWkAAAAAAAAAAAPUoLsAAAACwQwAAAAAAAW9WABZaRiI@mailjet.com>
MIME-Version: 1.0
From: Arun Isaac <arunisaac@systemreboot.net>
Date: Sat, 15 Jul 2017 00:46:12 +0530
In-reply-to: <8760evj6zm.fsf@fastmail.com>
References: <20170712142556.3350-1-arunisaac@systemreboot.net>
	<abfa18f4.AEEANOsGRuMAAAAAAAAAAAPUoLsAAAACwQwAAAAAAAW9WABZZjGb@mailjet.com>
	<8760evj6zm.fsf@fastmail.com>
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 27657@debbugs.gnu.org


Marius Bakke writes:

> Arun Isaac <arunisaac@systemreboot.net> writes:
>
>> * gnu/packages/freedesktop.scm (wayland)[arguments]: Add fix-graphviz ph=
ase.
>
> Thanks!

Oops! I just got this mail, and have already pushed this patch to
staging. I'll have to make these changes a separate commit. Sorry about
the communication gap.

> [...]
>
>> +       (modify-phases %standard-phases
>> +         ;; Remove record shapes to workaround graphviz 2.40.1 problems
>> +         ;; http://www.graphviz.org/content/i-havent-been-able-render-t=
hese-files-graphviz-226
>> +         ;; This will likely be fixed upstream in the next release
>
> Please add punctuations here. Why is it likely fixed next release, is
> there a patch or bug report upstream? If so, please add them here.

I thought it will likely be fixed next release because of the following
thread:
https://lists.freedesktop.org/archives/wayland-devel/2017-June/034218.html

I'll replace this sentence with another one saying that this is a known
upstream bug.

>
>> +         (add-before 'build 'fix-graphviz
>> +           (lambda _
>> +             (substitute* "doc/doxygen/dot/x-architecture.gv"
>> +               (("Mrecord") "none")))))))
>
> And make sure this phase ends on #t.

Will do. I keep forgetting to return #t from phases. Can't Guix error
out if #t is not returned from the phase?
=