From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iBvUFHt1LGI04QAAgWs5BA (envelope-from ) for ; Sat, 12 Mar 2022 11:27:07 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id SN6FDXt1LGJVdwEAG6o9tA (envelope-from ) for ; Sat, 12 Mar 2022 11:27:07 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E7BCC40F15 for ; Sat, 12 Mar 2022 11:27:06 +0100 (CET) Received: from localhost ([::1]:52048 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nSyxm-0004FJ-7A for larch@yhetil.org; Sat, 12 Mar 2022 05:27:06 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34116) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSyxi-0004FB-59 for guix-patches@gnu.org; Sat, 12 Mar 2022 05:27:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:45259) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nSyxh-00055P-QW for guix-patches@gnu.org; Sat, 12 Mar 2022 05:27:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nSyxh-0002rn-Lh for guix-patches@gnu.org; Sat, 12 Mar 2022 05:27:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#54293] [PATCH v2] home: Add home-git-service-type. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 12 Mar 2022 10:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54293 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: iyzsong@outlook.com, 54293@debbugs.gnu.org Cc: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Received: via spool by 54293-submit@debbugs.gnu.org id=B54293.164708082111016 (code B ref 54293); Sat, 12 Mar 2022 10:27:01 +0000 Received: (at 54293) by debbugs.gnu.org; 12 Mar 2022 10:27:01 +0000 Received: from localhost ([127.0.0.1]:39156 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSyxg-0002rZ-Ug for submit@debbugs.gnu.org; Sat, 12 Mar 2022 05:27:01 -0500 Received: from michel.telenet-ops.be ([195.130.137.88]:40978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSyxf-0002rR-L2 for 54293@debbugs.gnu.org; Sat, 12 Mar 2022 05:27:00 -0500 Received: from [172.20.10.9] ([188.189.165.207]) by michel.telenet-ops.be with bizsmtp id 5NSx2700U4UoT8k06NSxbC; Sat, 12 Mar 2022 11:26:58 +0100 Message-ID: <4e1d4b59b1ceae89aeb0f66268cec966a4a98476.camel@telenet.be> From: Maxime Devos Date: Sat, 12 Mar 2022 11:26:57 +0100 In-Reply-To: References: Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-fL4IsuWvZiiNsRiPafBS" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1647080818; bh=/eMxEW1z/XMPKntNW23qXRBGWUEbRX2weSyx1hu0x+s=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=m3jJXu4hrQilGSiRCbQvGhapxtUuYjnfllMBEZgDDPPJtWSqB4ZZrY/CCiyFyKy5/ kbMF7rgRFLhnpLYkPJMbakUN370DhCcrt/l+moYAJ8lv3IqgReDPc+w6rOq+/CjwYv HkRIph9C8B89bY54190ETZXlkuVKlM/aX9tIE06nuf+LypwH20LS4IF2bM8VPT4MUp JcEmKNm4wGcb6nKHSqr6Nh5wBsq6F+srbLdnAXxZaSilw35x5QHMmgTvlRFBjZ5OdT Dm+KlZheP5Db9qkFpXUYAFK4/pXFviSXpAVLjxfiUQQnM+eFt0ztiI3HekoY8lCkRv y/K2t3+GB3xLA== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647080827; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=/eMxEW1z/XMPKntNW23qXRBGWUEbRX2weSyx1hu0x+s=; b=p5QvG2X2GY/IEuYsQvUthk66cVVwB/eg3bZZfXU63RUo3sGuHlqINt6mr7KIwKhykd03qe Kf3XIPmeEeJpCKXt3irkxCAUMVHS2As6jaoi/jCuyNvxxs0eiB1WBg9ZCNr/clP5+p64fK lghIQnyIABis9u1BOk7F4UbsBJiCn3nT/L5ltwrMmyTkNkpaVeS41Iaty3Wl8hV4r2x+2s p4CNJJ2q7fs7RlEH6SIwFyMwOWAq2E7+kFxRxu03U4Hgu+Ua4i7eVZYXkiqfMSQbqwdtWm j2gG4n4jk0cC6BzLpTCYaa3fyl8dt9XA1mELZVffW6uOHWubkU38fvFo4IZ61g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647080827; a=rsa-sha256; cv=none; b=RU9VVNdjoZ6bk+KlN0Ui9pyT8j+Xsy63zlWo8kRClHqJIO3flrhZktIOFhAurVgYlgdmHr WN2+WDmjjxls+fc2xjuBaLlLz/5eb0IAFG+sArLlTvvaUNDbiYkz/g4fPi1ReYOOoWSN2r Bq4hHDdlfncFuIrnd8cIV96kJtjD5oNdEdxS7e/ZaNbv5AaetoB1oF1JZdKJ8gKGgRmqV9 Vs79j7ZClkaDQy0BUyA0/amk5VJJbN+QEbvtAp0wzh4Jgo4hCK3XLIuyRuW33f+TzvClt3 ZMFDQq0vaLtLwxCUwNAneajX3ZF7q27MmORPkoZ+Gkf8m7uYgLqG9rwRP0vM8w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=m3jJXu4h; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.03 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=m3jJXu4h; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E7BCC40F15 X-Spam-Score: 3.03 X-Migadu-Scanner: scn1.migadu.com X-TUID: Nu5GsaCwUzOp --=-fL4IsuWvZiiNsRiPafBS Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable iyzsong@outlook.com schreef op za 12-03-2022 om 10:22 [+0800]: > +=C2=A0=C2=A0 "Specify the encryption to use, either @code{ssl} or @code{= tls}.=C2=A0 Any other > +value reverts to plain SMTP.") This seems easy to go wrong, e.g. what if I accidentally pass a value in uppercase, e.g. "SSL" or "TLS"? I recommend validating this value instead of silently not encrypting. Also, does this need to be a symbol, or a string? Looking at the documentation, I would expect a symbol, but looking at the implementation, it seems to have to be a string. Greetings, Maxime. --=-fL4IsuWvZiiNsRiPafBS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYix1cRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7iu2AQDeKjqL6ZcYcRnojboFXsaQXzZ5 szKAYO+6HiUeVPoH6QEA1EYhzmiXrvQMIciplG/gNgHJLijJ0U+/nUtEyD3GKw4= =vY5V -----END PGP SIGNATURE----- --=-fL4IsuWvZiiNsRiPafBS--