[bug#27643] [PATCH] gnu: Add simplescreenrecorder.

[bug#27643] [PATCH] gnu: Add simplescreenrecorder.

[Alex Vong]

[-- Attachment #1.1: Type: text/plain, Size: 201 bytes --]

Hello,

This patch adds simplescreenrecorder which is a software for screen
recording (with easy-to-figure-out UI). README.md suggests compiling
with Qt 4 instead of Qt 5 because of stability issues.


[-- Attachment #1.2: 0001-gnu-Add-simplescreenrecorder.patch --]
[-- Type: text/x-diff, Size: 2915 bytes --]

From 240add550a1818f6a1d8089e5e4fb2dac704cee0 Mon Sep 17 00:00:00 2001
From: Alex Vong <alexvong1995@gmail.com>
Date: Mon, 10 Jul 2017 23:25:26 +0800
Subject: [PATCH] gnu: Add simplescreenrecorder.

* gnu/packages/video.scm (simplescreenrecorder): New variable.
---
 gnu/packages/video.scm | 37 ++++++++++++++++++++++++++++++++++++-
 1 file changed, 36 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 5338d375e..e5e6b434e 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -6,7 +6,7 @@
 ;;; Copyright © 2015, 2016, 2017 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2015 Andy Patterson <ajpatter@uwaterloo.ca>
 ;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
-;;; Copyright © 2015, 2016 Alex Vong <alexvong1995@gmail.com>
+;;; Copyright © 2015, 2016, 2017 Alex Vong <alexvong1995@gmail.com>
 ;;; Copyright © 2016, 2017 Alex Griffin <a@ajgrf.com>
 ;;; Copyright © 2016 Kei Kebreau <kei@openmailbox.org>
 ;;; Copyright © 2016 Dmitry Nikolaev <cameltheman@gmail.com>
@@ -1888,6 +1888,41 @@ your graphical desktop and encodes it as a video.  This is a useful tool for
 making @dfn{screencasts}.")
     (license license:gpl2+)))
 
+(define-public simplescreenrecorder
+  (package
+    (name "simplescreenrecorder")
+    (version "0.3.8")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://github.com/MaartenBaert/ssr/"
+                                  "archive/" version ".tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "0v8w35n8w772s08w7k0icynqdsdakbrcanbgx6j847bfqfsg21gg"))))
+    (build-system gnu-build-system)
+    (inputs `(("pkg-config" ,pkg-config)
+              ("qt" ,qt-4) ; README.md: using Qt 5 causes some stability issues
+              ("ffmpeg" ,ffmpeg)
+              ("alsa-lib" ,alsa-lib)
+              ("pulseaudio" ,pulseaudio)
+              ("jack" ,jack-1)
+              ("glu" ,glu)
+              ("libx11" ,libx11)
+              ("libxfixes" ,libxfixes)
+              ("libxext" ,libxext)
+              ("libxi" ,libxi)))
+    ;; Using HTTPS causes part of the page displayed improperly.
+    (home-page "http://www.maartenbaert.be/simplescreenrecorder/")
+    (synopsis "a screen recorder")
+    (description "SimpleScreenRecorder is a screen recorder.  Despite the name,
+this program is actually quite complex.  It's 'simple' in the sense that it's
+easier to use than ffmpeg/avconv or VLC.")
+    (license (list license:gpl3+ ; most files
+                   license:zlib ; glinject/elfhacks.*
+                   license:isc ; glinject/*
+                   license:x11)))) ; build-aux/install-sh
+
 (define-public libsmpeg
   (package
     (name "libsmpeg")
-- 
2.13.2


[-- Attachment #1.3: Type: text/plain, Size: 14 bytes --]


Cheers,
Alex

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#27643] [PATCH] gnu: Add simplescreenrecorder.

[Arun Isaac]

Thanks for the patch!

> +    (inputs `(("pkg-config" ,pkg-config)

pkg-config should be a native input.

> +              ("qt" ,qt-4) ; README.md: using Qt 5 causes some stability issues
> +              ("ffmpeg" ,ffmpeg)
> +              ("alsa-lib" ,alsa-lib)
> +              ("pulseaudio" ,pulseaudio)
> +              ("jack" ,jack-1)
> +              ("glu" ,glu)
> +              ("libx11" ,libx11)
> +              ("libxfixes" ,libxfixes)
> +              ("libxext" ,libxext)

The package builds successfully without libx11, libxfixes and libxext
included as inputs. Are you sure they are needed? Could you check again?

> +              ("libxi" ,libxi)))

Also, could you sort all the inputs in alphabetical order, just for the
aesthetic appeal? :-)

> +    ;; Using HTTPS causes part of the page displayed improperly.
> +    (home-page "http://www.maartenbaert.be/simplescreenrecorder/")

We'll go with the HTTP URL for now. But, do report this issue upstream
as well.

[bug#27643] [PATCH] gnu: Add simplescreenrecorder.

[Alex Vong]

[-- Attachment #1: Type: text/plain, Size: 1358 bytes --]

Arun Isaac <arunisaac@systemreboot.net> writes:

> Thanks for the patch!
>
>> +    (inputs `(("pkg-config" ,pkg-config)
>
> pkg-config should be a native input.
>
I forget to run lint before submitting the patch... I have fixed this
issue and other formatting issues reported by lint.

>> + ("qt" ,qt-4) ; README.md: using Qt 5 causes some stability issues
>> +              ("ffmpeg" ,ffmpeg)
>> +              ("alsa-lib" ,alsa-lib)
>> +              ("pulseaudio" ,pulseaudio)
>> +              ("jack" ,jack-1)
>> +              ("glu" ,glu)
>> +              ("libx11" ,libx11)
>> +              ("libxfixes" ,libxfixes)
>> +              ("libxext" ,libxext)
>
> The package builds successfully without libx11, libxfixes and libxext
> included as inputs. Are you sure they are needed? Could you check again?
>
>> +              ("libxi" ,libxi)))
>
These packages are listed as Build dependencies in README[0]. What do
you think?

> Also, could you sort all the inputs in alphabetical order, just for the
> aesthetic appeal? :-)
>
>> +    ;; Using HTTPS causes part of the page displayed improperly.
>> +    (home-page "http://www.maartenbaert.be/simplescreenrecorder/")
>
> We'll go with the HTTP URL for now. But, do report this issue upstream
> as well.

Yeah, I'll report it later.

Thanks for the review!

[0]: https://github.com/MaartenBaert/ssr

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#27643] [PATCH] gnu: Add simplescreenrecorder.

[Alex Vong]

[-- Attachment #1.1: Type: text/plain, Size: 28 bytes --]

I forget attach the patch:


[-- Attachment #1.2: 0001-gnu-Add-simplescreenrecorder.patch --]
[-- Type: text/x-diff, Size: 2968 bytes --]

From 55795231a1b2a72804485ca9a989e3399e76493a Mon Sep 17 00:00:00 2001
From: Alex Vong <alexvong1995@gmail.com>
Date: Mon, 10 Jul 2017 23:25:26 +0800
Subject: [PATCH] gnu: Add simplescreenrecorder.

* gnu/packages/video.scm (simplescreenrecorder): New variable.
---
 gnu/packages/video.scm | 38 +++++++++++++++++++++++++++++++++++++-
 1 file changed, 37 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 5338d375e..7541d9e59 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -6,7 +6,7 @@
 ;;; Copyright © 2015, 2016, 2017 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2015 Andy Patterson <ajpatter@uwaterloo.ca>
 ;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
-;;; Copyright © 2015, 2016 Alex Vong <alexvong1995@gmail.com>
+;;; Copyright © 2015, 2016, 2017 Alex Vong <alexvong1995@gmail.com>
 ;;; Copyright © 2016, 2017 Alex Griffin <a@ajgrf.com>
 ;;; Copyright © 2016 Kei Kebreau <kei@openmailbox.org>
 ;;; Copyright © 2016 Dmitry Nikolaev <cameltheman@gmail.com>
@@ -1888,6 +1888,42 @@ your graphical desktop and encodes it as a video.  This is a useful tool for
 making @dfn{screencasts}.")
     (license license:gpl2+)))
 
+(define-public simplescreenrecorder
+  (package
+    (name "simplescreenrecorder")
+    (version "0.3.8")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://github.com/MaartenBaert/ssr/"
+                                  "archive/" version ".tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "0v8w35n8w772s08w7k0icynqdsdakbrcanbgx6j847bfqfsg21gg"))))
+    (build-system gnu-build-system)
+    ;; See Build dependencies in README.
+    (native-inputs `(("pkg-config" ,pkg-config)))
+    (inputs `(("alsa-lib" ,alsa-lib)
+              ("ffmpeg" ,ffmpeg)
+              ("glu" ,glu)
+              ("jack" ,jack-1)
+              ("libx11" ,libx11)
+              ("libxext" ,libxext)
+              ("libxfixes" ,libxfixes)
+              ("libxi" ,libxi)
+              ("pulseaudio" ,pulseaudio)
+              ("qt" ,qt-4))) ; README: using Qt 5 causes some stability issues
+    ;; Using HTTPS causes part of the page displayed improperly.
+    (home-page "http://www.maartenbaert.be/simplescreenrecorder/")
+    (synopsis "Screen recorder")
+    (description "SimpleScreenRecorder is a screen recorder.  Despite the name,
+this program is actually quite complex.  It's @emph{simple} in the sense that
+it's easier to use than ffmpeg/avconv or VLC.")
+    (license (list license:gpl3+ ; most files
+                   license:zlib ; glinject/elfhacks.*
+                   license:isc ; glinject/*
+                   license:x11)))) ; build-aux/install-sh
+
 (define-public libsmpeg
   (package
     (name "libsmpeg")
-- 
2.13.2


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#27643] [PATCH] gnu: Add simplescreenrecorder.

[Arun Isaac]

>>> + ("qt" ,qt-4) ; README.md: using Qt 5 causes some stability issues
>>> +              ("ffmpeg" ,ffmpeg)
>>> +              ("alsa-lib" ,alsa-lib)
>>> +              ("pulseaudio" ,pulseaudio)
>>> +              ("jack" ,jack-1)
>>> +              ("glu" ,glu)
>>> +              ("libx11" ,libx11)
>>> +              ("libxfixes" ,libxfixes)
>>> +              ("libxext" ,libxext)
>>
>> The package builds successfully without libx11, libxfixes and libxext
>> included as inputs. Are you sure they are needed? Could you check again?
>>
>>> +              ("libxi" ,libxi)))
>>
> These packages are listed as Build dependencies in README[0]. What do
> you think?

I think we should not include them as dependencies. We can always
include them later if we have problems.

I did start the application built without these packages, and it started
successfully. If you are a user of this package, you could test it more
extensively.

WDYT?

[bug#27643] [PATCH] gnu: Add simplescreenrecorder.

[Alex Vong]

[-- Attachment #1.1: Type: text/plain, Size: 1160 bytes --]

Arun Isaac <arunisaac@systemreboot.net> writes:

>>>> + ("qt" ,qt-4) ; README.md: using Qt 5 causes some stability issues
>>>> +              ("ffmpeg" ,ffmpeg)
>>>> +              ("alsa-lib" ,alsa-lib)
>>>> +              ("pulseaudio" ,pulseaudio)
>>>> +              ("jack" ,jack-1)
>>>> +              ("glu" ,glu)
>>>> +              ("libx11" ,libx11)
>>>> +              ("libxfixes" ,libxfixes)
>>>> +              ("libxext" ,libxext)
>>>
>>> The package builds successfully without libx11, libxfixes and libxext
>>> included as inputs. Are you sure they are needed? Could you check again?
>>>
>>>> +              ("libxi" ,libxi)))
>>>
>> These packages are listed as Build dependencies in README[0]. What do
>> you think?
>
> I think we should not include them as dependencies. We can always
> include them later if we have problems.
>
> I did start the application built without these packages, and it started
> successfully. If you are a user of this package, you could test it more
> extensively.
>
> WDYT?

I have tested it just now. Indeed, it works without those packages. (I
recorded a 10s video.) So I remove them.

Here is the new patch:

[-- Attachment #1.2: 0001-gnu-Add-simplescreenrecorder.patch --]
[-- Type: text/x-diff, Size: 3044 bytes --]

From 3ca05bb6f3a9c6097c72681734f1fcf754cee424 Mon Sep 17 00:00:00 2001
From: Alex Vong <alexvong1995@gmail.com>
Date: Mon, 10 Jul 2017 23:25:26 +0800
Subject: [PATCH] gnu: Add simplescreenrecorder.

* gnu/packages/video.scm (simplescreenrecorder): New variable.
---
 gnu/packages/video.scm | 37 ++++++++++++++++++++++++++++++++++++-
 1 file changed, 36 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 5338d375e..dc73114e4 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -6,7 +6,7 @@
 ;;; Copyright © 2015, 2016, 2017 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2015 Andy Patterson <ajpatter@uwaterloo.ca>
 ;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
-;;; Copyright © 2015, 2016 Alex Vong <alexvong1995@gmail.com>
+;;; Copyright © 2015, 2016, 2017 Alex Vong <alexvong1995@gmail.com>
 ;;; Copyright © 2016, 2017 Alex Griffin <a@ajgrf.com>
 ;;; Copyright © 2016 Kei Kebreau <kei@openmailbox.org>
 ;;; Copyright © 2016 Dmitry Nikolaev <cameltheman@gmail.com>
@@ -1888,6 +1888,41 @@ your graphical desktop and encodes it as a video.  This is a useful tool for
 making @dfn{screencasts}.")
     (license license:gpl2+)))
 
+(define-public simplescreenrecorder
+  (package
+    (name "simplescreenrecorder")
+    (version "0.3.8")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://github.com/MaartenBaert/ssr/"
+                                  "archive/" version ".tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "0v8w35n8w772s08w7k0icynqdsdakbrcanbgx6j847bfqfsg21gg"))))
+    (build-system gnu-build-system)
+    (native-inputs `(("pkg-config" ,pkg-config)))
+    ;; Although libx11, libxfixes, libxext are listed as build dependencies in
+    ;; README. The program builds and functions properly without it.
+    ;; As a result, they are omitted. Please add them back if problems appear.
+    (inputs `(("alsa-lib" ,alsa-lib)
+              ("ffmpeg" ,ffmpeg)
+              ("glu" ,glu)
+              ("jack" ,jack-1)
+              ("libxi" ,libxi)
+              ("pulseaudio" ,pulseaudio)
+              ("qt" ,qt-4))) ; README: using Qt 5 causes some stability issues
+    ;; Using HTTPS causes part of the page displayed improperly.
+    (home-page "http://www.maartenbaert.be/simplescreenrecorder/")
+    (synopsis "Screen recorder")
+    (description "SimpleScreenRecorder is a screen recorder.  Despite the name,
+this program is actually quite complex.  It's @emph{simple} in the sense that
+it's easier to use than ffmpeg/avconv or VLC.")
+    (license (list license:gpl3+ ; most files
+                   license:zlib ; glinject/elfhacks.*
+                   license:isc ; glinject/*
+                   license:x11)))) ; build-aux/install-sh
+
 (define-public libsmpeg
   (package
     (name "libsmpeg")
-- 
2.13.2


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#27643] [PATCH] gnu: Add simplescreenrecorder.

[Arun Isaac]

Everything LGTM. Before pushing, I'd like to update the description as
follows. I believe this is more descriptive of the package. WDYT?

(description "SimpleScreenRecorder is an easy to use screen recorder with
a graphical user interface.  It supports recording the entire screen, or a
part of it, and allows encoding in many different codecs and file formats.
Other features include a live preview and live streaming.")

bug#27643: [PATCH] gnu: Add simplescreenrecorder.

[Arun Isaac]

Pushed, thanks!

[bug#27643] [PATCH] gnu: Add simplescreenrecorder.

[Alex Vong]

[-- Attachment #1: Type: text/plain, Size: 117 bytes --]

Arun Isaac <arunisaac@systemreboot.net> writes:

> Pushed, thanks!

Thanks for updating the description and pushing!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]