From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id qMBENL2VsmWvUAEAqHPOHw:P1 (envelope-from ) for ; Thu, 25 Jan 2024 18:09:18 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id qMBENL2VsmWvUAEAqHPOHw (envelope-from ) for ; Thu, 25 Jan 2024 18:09:17 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=planete-kraus.eu header.s=albinoniA header.b=GM9r5a0y; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1706202557; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=4kWGd2sYci+6v81TmRKikElw492pqZBwxG3zG8elW4c=; b=e03Ptf0bRFlVpI2l1JYL5k1mED5sbHI3oEy36Hk+8SVJRvLNjX8/pkPUHKE5GtDKuPnPk1 uNHbBfLUrV7IPL0Rvg2SYPpSYvMsVErBPZo5IsHiolI0LZJs3hl/EkZ8nPryFnEZ3JJjU4 etFHOYf7HpSytMPJQyq0RX2tgklqGAdAcesSdleth/WDVlDV4a+UDhko8G3g7SFUkShOMP +OGfYQyNBSCaNRUAAfEwbeyuvOHJIr4wD8a5l6Ub3y+VTGRnuClEJqev2OEsUio1Jg8XDm o5ldMlxZSRBDhnqvPYhDBBc2sVWfXeGVn5CqBGo5zRl9bzh0ptLQmeTdK+uOKg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=planete-kraus.eu header.s=albinoniA header.b=GM9r5a0y; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1706202557; a=rsa-sha256; cv=none; b=a1jaFqNQ3xVPW1fZeDS40T0HQfHqLsCLq8XyFg1Hz+zmI1ShSBIskdgdBkkphzogW8185i 7KJp2mru1sPDFQ0JzkyYlJICvS4QzCjH3DlpUVshS1O3CEO4sZ0LhfJIjmg/z25pV98R2C 0Yn4NCMDeJveLx5JBgRY7vVSUvwRleGRwTSybZyfxVOJzlRnFp/GmOuUA7WEs52cMHXoFW WXV2Hf9GGhYmy18AlYzX9oE5h9lT5ojX/WTtVziQ1GCg3aM7bvohtLVfhpM6kZQPfcKbEI irKExCtinZeRYA3ll1MRbCJACl2OyLhtxW49JNE3RFMcwWnSUUq9D0n3H2Ul2w== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A5A1A3CB39 for ; Thu, 25 Jan 2024 18:09:17 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rT3Dn-0003jz-2P; Thu, 25 Jan 2024 12:08:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rT3Dl-0003jM-5I for guix-patches@gnu.org; Thu, 25 Jan 2024 12:08:57 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rT3Dk-0000co-Qw for guix-patches@gnu.org; Thu, 25 Jan 2024 12:08:56 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rT3Dq-0003JD-Bt for guix-patches@gnu.org; Thu, 25 Jan 2024 12:09:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68716] [PATCH gnome-team RFC 1/3] services: Modularise gnome-desktop-configuration. Resent-From: Vivien Kraus Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 25 Jan 2024 17:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68716 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler , 68716@debbugs.gnu.org Cc: rg@raghavgururajan.name, maxim.cournoyer@gmail.com Received: via spool by 68716-submit@debbugs.gnu.org id=B68716.170620254112710 (code B ref 68716); Thu, 25 Jan 2024 17:09:02 +0000 Received: (at 68716) by debbugs.gnu.org; 25 Jan 2024 17:09:01 +0000 Received: from localhost ([127.0.0.1]:49086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rT3Dp-0003Iw-1i for submit@debbugs.gnu.org; Thu, 25 Jan 2024 12:09:01 -0500 Received: from planete-kraus.eu ([89.234.140.182]:36722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rT3Dl-0003If-Qz for 68716@debbugs.gnu.org; Thu, 25 Jan 2024 12:08:59 -0500 Received: from planete-kraus.eu (localhost [127.0.0.1]) by planete-kraus.eu (OpenSMTPD) with ESMTP id f415cc7c; Thu, 25 Jan 2024 17:08:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=planete-kraus.eu; h= message-id:subject:from:to:cc:date:in-reply-to:references :content-type:content-transfer-encoding:mime-version; s= albinoniA; bh=QPRScurqpZNRGiFrHI8mqAF4Lzs=; b=GM9r5a0yPWSS0M6CZn YL/vvCQvDTtJg3GEeioKPt7Gv5gLOi9ane65oVwiD3/qkuKRrCFs4x/G25G5wzla ssSbLYgC46y29ktV7pX/L90uOo+Y4M8C2vot9kCA93hIcvTH5kPHmOXO/7kheFS/ /0TTBovywqGIAbKTTvRY/lsVUjnT/RcnH8Pya3m+H2rfM8x+ur5+bKSEOsVhNfV2 qZ2j3HQLNfUCZHLbh3SlnmTyWVvlpPITwjfBKRdgxqmbGRrgRSgW8tU1VKn3XPGM Mco6HWTfwQCmFm4PLkE7GOMJJ11wC6XrzcJQ6Wy8+ZViXtFamYGcCilHy5VQ09Db WuJQ== Received: by planete-kraus.eu (OpenSMTPD) with ESMTPSA id 36904fcc (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Thu, 25 Jan 2024 17:08:44 +0000 (UTC) Message-ID: <4d7b7ed7da044d557271f02b3d90ba87ce12ccf0.camel@planete-kraus.eu> Date: Thu, 25 Jan 2024 18:12:09 +0100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Vivien Kraus X-ACL-Warn: , Vivien Kraus via Guix-patches From: Vivien Kraus via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.66 X-Migadu-Queue-Id: A5A1A3CB39 X-Spam-Score: -5.66 X-Migadu-Scanner: mx11.migadu.com X-TUID: bK1rYMZiM8GD Hello! Thank you for this series. Le jeudi 25 janvier 2024 =C3=A0 16:35 +0100, Liliana Marie Prikler a =C3=A9= crit=C2=A0: > =C2=A0(define (gnome-udev-rules config) > =C2=A0=C2=A0 "Return the list of GNOME dependencies that provide udev rul= es." > -=C2=A0 (let ((gnome (gnome-desktop-configuration-gnome config))) > -=C2=A0=C2=A0=C2=A0 (gnome-packages gnome '("gnome-settings-daemon")))) > +=C2=A0 (let* ((gnome (gnome-desktop-configuration-gnome config)) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (shell (gnome-desktop-c= onfiguration-shell config))) > +=C2=A0=C2=A0=C2=A0 (or (any (match-lambda > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 ((and pkg (=3D package-name "gnome-settings-daemon")) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 (list pkg)) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 (_ #f)) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= shell) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (and (maybe-value-set? gnome) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= (gnome-packages gnome '("gnome-settings-daemon"))) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (raise > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (condition > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (&error-location > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (location (= gnome-desktop-configuration-source-location > config))) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (&message (messag= e (G_ "Missing gnome-settings- > daemon")))))))) > =C2=A0 Is there a reason why we can=E2=80=99t just add everything (like what your = new gnome-profile function does)? As far as I understand, the user doesn=E2=80=99t have a say over which individual rules will be used, among the rules that come from the same package. So if we want the user to have full control over the rules that are picked, then the current configuration record does not allow sufficient precision. Also, we now have udev hardware files. I=E2=80=99m not sure we have any GNO= ME packages that install hardware files, but the user might have some. The gnome-udev-rules function name is misleading now (sorry, my bad, I should have renamed it when the udev service changed), because every package listed here will also have its hardware files installed, not just rules. If you want to pick rules separately from hardware files, you have to use file->udev-rule, file->udev-hardware (or udev-rule and udev-hardware) from (gnu services base). > @@ -1422,7 +1566,7 @@ (define gnome-desktop-service-type > (service-extension polkit-service-type > gnome-polkit-settings) > (service-extension profile-service-type > - (compose list gnome-desktop- > configuration-gnome)))) > + gnome-profile))) > (default-value (gnome-desktop-configuration)) > (description "Run the GNOME desktop environment."))) I think the gnome-desktop-service-type could be easily made extensible, so that e.g a gnome-circle-service-type could add all the circles applications in their respective sections. Maybe it could be extended with other instances of gnome-desktop- configuration? It looks to me that merging multiple instances is quite easy, as you could just merge the lists for each category, and the "gnome" field of the extension could simply be ignored. There are still issues, such as: how can a service extension replace a package with a conflicting one. Maybe that case is too far out of scope. That being said, the extensibility of the gnome-desktop-service-type is not very much needed, because we can also extend the udev, polkit and profile services directly. Other than that, the series looks great to me! Vivien