From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51480) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cz1Gh-0003b2-32 for guix-patches@gnu.org; Fri, 14 Apr 2017 09:28:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cz1Gc-0003FD-PV for guix-patches@gnu.org; Fri, 14 Apr 2017 09:28:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:48427) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cz1Gc-0003F7-DZ for guix-patches@gnu.org; Fri, 14 Apr 2017 09:28:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cz1Gc-00010y-7F for guix-patches@gnu.org; Fri, 14 Apr 2017 09:28:02 -0400 Subject: bug#26454: [PATCH 2/2] gnu: add emacs-exwm Resent-Message-ID: Message-Id: <4d35676d.AEUAI-hEBJAAAAAAAAAAAAO0QTIAAAACwQwAAAAAAAW9WABY8M5G@mailjet.com> MIME-Version: 1.0 From: Arun Isaac Date: Fri, 14 Apr 2017 18:57:21 +0530 In-reply-to: <87mvbj6w72.fsf@163.com> References: <20170411225803.2420-1-tumashu@163.com> <20170411225803.2420-2-tumashu@163.com> <87inm9sdcs.fsf@gmail.com> <60b3e50e.AEEAJadpHi4AAAAAAAAAAAO0QTIAAAACwQwAAAAAAAW9WABY7oh5@mailjet.com> <67fed3f6.1a3b.15b64e00dfd.Coremail.tumashu@163.com> <87mvbj6w72.fsf@163.com> Content-Type: text/plain Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 26454@debbugs.gnu.org Thanks for the patches. > +(define-public emacs-xelb > + (package > + (name "emacs-xelb") > + (version "0.12.d1d6b6c") > + (home-page "https://github.com/ch11ng/xelb") Could you put the home-page just before the synopsis as commonly done in other package definitions? > + (synopsis "X protocol Emacs Lisp Binding") > + (description "XELB (X protocol Emacs Lisp Binding) is a pure Elisp Please make this "@code{emacs-xelb} is a pure Emacs Lisp implementation of ...". No need to repeat "X protocol Emacs Lisp Binding" as it is already mentioned in the synopsis. Expand Elisp -> Emacs Lisp. > +implementation of X11 protocol based on the XML description files from *the* X11 protocol > +XCB project. It features an object-oriented API and permits a certain *the* XCB project > +degree of concurrency. It should enable you to implement some low-level Remove "some". It makes the whole sentence sound vague. > +X11 applications.") > +(define-public emacs-exwm > + (package > + (name "emacs-exwm") > + (home-page "https://github.com/ch11ng/exwm") Same about home-page. > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url home-page) > + (commit "7a5bb1156d07848e465f55fd31f8ec755b52aa01"))= ) > + (file-name (string-append name "-" version)) Append "-checkout" at the end of file-name just like you did for emacs-xelb. LGTM, otherwise! >> In your new patch, could you add a phase for generating this code from >> the xcb-proto xml files as well? Thanks! > I don't think it it a good idea, xcb-xproto.el provided by repo is > tested by developer. if we regenerate it, i don't know whether it > work or not. @Ludo: Could you please comment on this? =