From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:55380) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWez6-0005sp-7B for guix-patches@gnu.org; Fri, 31 May 2019 06:42:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hWez4-0005xG-KQ for guix-patches@gnu.org; Fri, 31 May 2019 06:42:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49556) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hWez4-0005wb-BP for guix-patches@gnu.org; Fri, 31 May 2019 06:42:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hWez4-00035T-8j for guix-patches@gnu.org; Fri, 31 May 2019 06:42:02 -0400 Subject: [bug#36021] [PATCH] search-paths: 'environment-variable-definition' output for fish Resent-Message-ID: References: <20190531103630.6739-1-dfrumin@cs.ru.nl> From: Dan Frumin Message-ID: <4c3d1d91-18ae-954f-2f0f-a979a974fb2c@cs.ru.nl> Date: Fri, 31 May 2019 12:41:10 +0200 MIME-Version: 1.0 In-Reply-To: <20190531103630.6739-1-dfrumin@cs.ru.nl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 36021@debbugs.gnu.org Hi Guix! Some background on this patch: Right now whenever I do any Guix operation that requires me to modify environment variables (e.g. installing a Guile library requires me to update $GUILE_LOAD_PATH afterwards), Guix helpful tells me what commands I have to run to update the variables. However, those commands are currently in bash/POSIX(?) format `export VAR=VALUE`. I've modified the `environment-variable-definition` function to support the syntax for Fish shell as well. I don't know if this method of looking at the $SHELL variable is sound, but it works on my machine. Documentation for the `set' function in Fish: https://fishshell.com/docs/current/commands.html#set PS: this is my first non-package patch for Guix so I apologize if there is something wrong with the patch Best regards, -Dan