all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Robert Vollmert <rob@vllmrt.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 35944@debbugs.gnu.org
Subject: [bug#35944] [PATCH] gnu: packages: haskell: happy: Disable tests
Date: Sat, 1 Jun 2019 16:40:31 +0200	[thread overview]
Message-ID: <4BD76A21-D533-4B60-9A24-6855225D354E@vllmrt.net> (raw)
In-Reply-To: <A84C7AE6-3BAD-4E9D-BE2A-FE1C8B409071@vllmrt.net>



> On 1. Jun 2019, at 14:56, Robert Vollmert <rob@vllmrt.net> wrote:
>> On 1. Jun 2019, at 14:55, Ludovic Courtès <ludo@gnu.org> wrote:
>> They fail because they run out of memory?
> 
> Indeed, the OOM killer strikes.
> 
>> What would it take to skip just these two tests instead of skipping all
>> the tests?
> 
> I’ll look into it.

Below is a patch that does that. I’m now running into similar issues when
compiling ghc-scientific; should OOM test failures at 2G of memory generally
be considered worth fixing? As an alternative, would it be feasible to
implement a --skip-tests flag for guix build?

From 7b7029d99df7df2ccdbfb4026edd91daa2a5763e Mon Sep 17 00:00:00 2001
From: Robert Vollmert <rob@vllmrt.net>
Date: Tue, 28 May 2019 21:10:24 +0200
Subject: [PATCH] gnu: ghc-happy: Skip memory-hungry tests.

Tests fail reliably for me on a system with 2GB of available RAM, in
`issue93.a.hs` and `issue93.n.hs`.

* gnu/packages/haskell.scm (ghc-happy): Skip test "issue93".
---
 gnu/packages/haskell.scm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
index 33c9c6484d..be9ab00bfd 100644
--- a/gnu/packages/haskell.scm
+++ b/gnu/packages/haskell.scm
@@ -1325,6 +1325,14 @@ postfix notation.  For more information on stack based languages, see
         (base32
          "138xpxdb7x62lpmgmb6b3v3vgdqqvqn4273jaap3mjmc2gla709y"))))
     (build-system haskell-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'skip-test-issue93
+           (lambda _
+             (substitute* "tests/Makefile"
+               ((" issue93.y ") " "))
+             #t)))))
     (home-page "https://hackage.haskell.org/package/happy")
     (synopsis "Parser generator for Haskell")
     (description "Happy is a parser generator for Haskell.  Given a grammar
-- 
2.20.1 (Apple Git-117)

  parent reply	other threads:[~2019-06-01 14:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-28 12:41 [bug#35944] [PATCH] gnu: packages: haskell: happy: Disable tests Robert Vollmert
2019-06-01 12:55 ` Ludovic Courtès
     [not found]   ` <A84C7AE6-3BAD-4E9D-BE2A-FE1C8B409071@vllmrt.net>
2019-06-01 14:40     ` Robert Vollmert [this message]
2019-06-01 21:30       ` bug#35944: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BD76A21-D533-4B60-9A24-6855225D354E@vllmrt.net \
    --to=rob@vllmrt.net \
    --cc=35944@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.