[bug#57021] [PATCH] gnu: packages: Add nmail.

[bug#57021] [PATCH] gnu: packages: Add nmail.

[M]

* gnu/packages/nmail.scm: Reorder module imports. Remove
  duplicate imports.
(nmail): New variable. Fix style.
---
 gnu/packages/mail.scm | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index 0bc6519dd2..24730d5eb3 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -456,19 +456,20 @@ (define-public nmail
                 "07lkl5syx3l37dhsl41nhmjknhxqgmvwc4il4gygsnr333qk75c9"))))
     (build-system cmake-build-system)
     (arguments
-     (list #:phases #~(modify-phases %standard-phases
+     (list #:phases
+           #~(modify-phases %standard-phases
                         (replace 'check
-                          (lambda*
-                              (#:key tests? #:allow-other-keys)
+                          (lambda* (#:key tests? #:allow-other-keys)
                               (when tests? (invoke "ctest" "--output-on-failure")))))))
-    (inputs (list libetpan
-                  xapian
-                  sqlite
-                  cyrus-sasl
-                  ncurses
-                  openssl
-                  file
-                  (list util-linux "lib")))
+    (inputs
+     (list cyrus-sasl
+           file
+           libetpan
+           ncurses
+           openssl
+           sqlite
+           (list util-linux "lib")
+           xapian))
     (native-inputs (list pkg-config))
     (home-page "https://github.com/d99kris/nmail")
     (synopsis "Terminal-based email client")
-- 
2.34.0

[bug#57021] [PATCH] gnu: packages: Add nmail.

[Mathieu Othacehe]

Hello,

> * gnu/packages/nmail.scm: Reorder module imports. Remove
>   duplicate imports.
> (nmail): New variable. Fix style.

Thanks for this first contribution. As you are adding a new package, the
preferred way to proceed is to amend your first patch with those changes
and submit a new revision (v2).

The module re-ordering stuff should also be part of a new patch. In
short, we would expect something like:

* gnu: Reorder mail module imports.
* gnu: nmail: New variable.

Do you think you could send those two patches in a v3? Don't hesitate to
ask for guidance here or on IRC if I'm unclear.

Mathieu

[bug#57021] [PATCH] gnu: packages: Add nmail.

[Mathieu]

Thanks, I'll try to do that. However I see that the nmail dev is currently fixing multiple bugs that were reported lately, so I think it would be best if I wait until the next release.  

Thanks for your help!

M

On 2022-08-12 10:53 Mathieu Othacehe <othacehe@gnu.org> wrote:

>  
> Hello,
>  
>> * gnu/packages/nmail.scm: Reorder module imports. Remove
>> duplicate imports.
>> (nmail): New variable. Fix style.
>  
> Thanks for this first contribution. As you are adding a new package,
> the
> preferred way to proceed is to amend your first patch with those
> changes
> and submit a new revision (v2).
>  
> The module re-ordering stuff should also be part of a new patch. In
> short, we would expect something like:
>  
> * gnu: Reorder mail module imports.
> * gnu: nmail: New variable.
>  
> Do you think you could send those two patches in a v3? Don't hesitate
> to
> ask for guidance here or on IRC if I'm unclear.
>  
> Mathieu

[bug#57021] [PATCH v3] gnu: Add nmail.

[M]

* gnu/packages/mail.scm (nmail): New variable.
---
 gnu/packages/mail.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index 65d8060862..0526ccb521 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -50,6 +50,7 @@
 ;;; Copyright © 2022 Guillaume Le Vaillant <glv@posteo.net>
 ;;; Copyright © 2022 muradm <mail@muradm.net>
 ;;; Copyright © 2022 jgart <jgart@dismail.de>
+;;; Copyright © 2022 Mathieu Laparie <mlaparie@disr.it>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -405,6 +406,42 @@ (define-public mailutils
      ;; Libraries are under LGPLv3+, and programs under GPLv3+.
      (list license:gpl3+ license:lgpl3+))))
 
+(define-public nmail
+  (package
+    (name "nmail")
+    (version "3.74")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/d99kris/nmail/")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "07lkl5syx3l37dhsl41nhmjknhxqgmvwc4il4gygsnr333qk75c9"))))
+    (build-system cmake-build-system)
+    (arguments
+     (list #:phases #~(modify-phases %standard-phases
+                        (replace 'check
+                          (lambda*
+                              (#:key tests? #:allow-other-keys)
+                              (when tests? (invoke "ctest" "--output-on-failure")))))))
+    (inputs (list libetpan
+                  xapian
+                  sqlite
+                  cyrus-sasl
+                  ncurses
+                  openssl
+                  file
+                  (list util-linux "lib")))
+    (native-inputs (list pkg-config))
+    (home-page "https://github.com/d99kris/nmail")
+    (synopsis "Terminal-based email client")
+    (description
+     "@command{nmail} is a terminal-based email client with a
+@code{ncurses} user interface similar to @code{alpine} and @code{pine}.")
+    (license license:expat)))
+
 (define-public go-gitlab.com-shackra-goimapnotify
   (package
     (name "go-gitlab.com-shackra-goimapnotify")
-- 
2.37.2

[bug#57021] [PATCH v3] gnu: Add nmail.

[Mathieu]

I am sending a v3 patch even though a new version of nmail has not been released upstream, but will try to update it when a new version is available.

As far as I understand, the imports are no longer necessary with master, I think all required modules are already in mail.scm now, and properly sorted in alphabetic order (so that should not be necessary either). Please let me know if I got something wrong.

[bug#57021] [PATCH v3] gnu: Add nmail.

[Mathieu]

And I'll be sending a v4 very soon because I see that the v3 above doesn't take into account the latest changesi from the v2, I reused an outdated version of the patch. My bad.

[bug#57021] [PATCH v4] gnu: Add nmail.

[M]

* gnu/packages/mail.scm (nmail): New variable.
---
 gnu/packages/mail.scm | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index 65d8060862..8f2452a61f 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -50,6 +50,7 @@
 ;;; Copyright © 2022 Guillaume Le Vaillant <glv@posteo.net>
 ;;; Copyright © 2022 muradm <mail@muradm.net>
 ;;; Copyright © 2022 jgart <jgart@dismail.de>
+;;; Copyright © 2022 Mathieu Laparie <mlaparie@disr.it>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -405,6 +406,43 @@ (define-public mailutils
      ;; Libraries are under LGPLv3+, and programs under GPLv3+.
      (list license:gpl3+ license:lgpl3+))))
 
+(define-public nmail
+  (package
+    (name "nmail")
+    (version "3.74")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/d99kris/nmail/")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+                (base32
+                "07lkl5syx3l37dhsl41nhmjknhxqgmvwc4il4gygsnr333qk75c9"))))
+    (build-system cmake-build-system)
+    (arguments
+      (list #:phases
+            #~(modify-phases %standard-phases
+                (replace 'check
+                  (lambda* (#:key tests? #:allow-other-keys)
+                    (when tests? (invoke "ctest" "--output-on-failure")))))))
+    (inputs
+     (list cyrus-sasl
+           file
+           libetpan
+           ncurses
+           openssl
+           sqlite
+           (list util-linux "lib")
+           xapian))
+    (native-inputs (list pkg-config))
+    (home-page "https://github.com/d99kris/nmail")
+    (synopsis "Terminal-based email client")
+    (description
+     "@command{nmail} is an easily configurable terminal-based email client with
+a @code{ncurses} user interface similar to @code{alpine} and @code{pine}.")
+    (license license:expat)))
+
 (define-public go-gitlab.com-shackra-goimapnotify
   (package
     (name "go-gitlab.com-shackra-goimapnotify")
-- 
2.37.2

[bug#57021] [PATCH v5] gnu: Add nmail.

[M]

* gnu/packages/mail.scm (nmail): New variable.
---
 gnu/packages/mail.scm | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index 65d8060862..8f2452a61f 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -50,6 +50,7 @@
 ;;; Copyright © 2022 Guillaume Le Vaillant <glv@posteo.net>
 ;;; Copyright © 2022 muradm <mail@muradm.net>
 ;;; Copyright © 2022 jgart <jgart@dismail.de>
+;;; Copyright © 2022 Mathieu Laparie <mlaparie@disr.it>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -405,6 +406,43 @@ (define-public mailutils
      ;; Libraries are under LGPLv3+, and programs under GPLv3+.
      (list license:gpl3+ license:lgpl3+))))
 
+(define-public nmail
+  (package
+    (name "nmail")
+    (version "3.74")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/d99kris/nmail/")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+                (base32
+                "07lkl5syx3l37dhsl41nhmjknhxqgmvwc4il4gygsnr333qk75c9"))))
+    (build-system cmake-build-system)
+    (arguments
+      (list #:phases
+            #~(modify-phases %standard-phases
+                (replace 'check
+                  (lambda* (#:key tests? #:allow-other-keys)
+                    (when tests? (invoke "ctest" "--output-on-failure")))))))
+    (inputs
+     (list cyrus-sasl
+           file
+           libetpan
+           ncurses
+           openssl
+           sqlite
+           (list util-linux "lib")
+           xapian))
+    (native-inputs (list pkg-config))
+    (home-page "https://github.com/d99kris/nmail")
+    (synopsis "Terminal-based email client")
+    (description
+     "@command{nmail} is an easily configurable terminal-based email client with
+a @code{ncurses} user interface similar to @code{alpine} and @code{pine}.")
+    (license license:expat)))
+
 (define-public go-gitlab.com-shackra-goimapnotify
   (package
     (name "go-gitlab.com-shackra-goimapnotify")
-- 
2.37.2

[bug#57021] [PATCH v6] Enable login in cyrus-sasl, as Exchange servers expect it

[M]

---
 gnu/packages/cyrus-sasl.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/cyrus-sasl.scm b/gnu/packages/cyrus-sasl.scm
index 2cd18f3e5e..4e23bd5fe0 100644
--- a/gnu/packages/cyrus-sasl.scm
+++ b/gnu/packages/cyrus-sasl.scm
@@ -3,6 +3,7 @@
 ;;; Copyright © 2013 Andreas Enge <andreas@enge.fr>
 ;;; Copyright © 2016 Leo Famulari <leo@famulari.name>
 ;;; Copyright © 2019 Mathieu Othacehe <m.othacehe@gmail.com>
+;;; Copyright © 2022 Mathieu Laparie <mlaparie@disr.it>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -54,7 +55,8 @@ (define-public cyrus-sasl
     (list ;; cyrus-sasl.pc refers to -lkrb5, so propagate it.
           mit-krb5))
    (arguments
-    '(#:configure-flags (list (string-append "--with-plugindir="
+    '(#:configure-flags (list (string-append "--enable-login"
+                                             "--with-plugindir="
                                              (assoc-ref %outputs "out")
                                              "/lib/sasl2"))
 
-- 
2.37.2

[bug#57021] [PATCH v7] gnu: cyrus-sasl: Enable login.

[M]

* gnu/packages/cyrus-sasl.scm (cyrus-sasl)[arguments]: Enable login.

  Exchange servers require login for e-mail clients that use cyrus-sasl.
---
 gnu/packages/cyrus-sasl.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/cyrus-sasl.scm b/gnu/packages/cyrus-sasl.scm
index 2cd18f3e5e..4e23bd5fe0 100644
--- a/gnu/packages/cyrus-sasl.scm
+++ b/gnu/packages/cyrus-sasl.scm
@@ -3,6 +3,7 @@
 ;;; Copyright © 2013 Andreas Enge <andreas@enge.fr>
 ;;; Copyright © 2016 Leo Famulari <leo@famulari.name>
 ;;; Copyright © 2019 Mathieu Othacehe <m.othacehe@gmail.com>
+;;; Copyright © 2022 Mathieu Laparie <mlaparie@disr.it>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -54,7 +55,8 @@ (define-public cyrus-sasl
     (list ;; cyrus-sasl.pc refers to -lkrb5, so propagate it.
           mit-krb5))
    (arguments
-    '(#:configure-flags (list (string-append "--with-plugindir="
+    '(#:configure-flags (list (string-append "--enable-login"
+                                             "--with-plugindir="
                                              (assoc-ref %outputs "out")
                                              "/lib/sasl2"))
 
-- 
2.37.2

[bug#57021] [PATCH v7 1/2] gnu: Add nmail.

[M]

* gnu/packages/mail.scm (nmail): New variable.
---
 gnu/packages/mail.scm | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index 65d8060862..8f2452a61f 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -50,6 +50,7 @@
 ;;; Copyright © 2022 Guillaume Le Vaillant <glv@posteo.net>
 ;;; Copyright © 2022 muradm <mail@muradm.net>
 ;;; Copyright © 2022 jgart <jgart@dismail.de>
+;;; Copyright © 2022 Mathieu Laparie <mlaparie@disr.it>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -405,6 +406,43 @@ (define-public mailutils
      ;; Libraries are under LGPLv3+, and programs under GPLv3+.
      (list license:gpl3+ license:lgpl3+))))
 
+(define-public nmail
+  (package
+    (name "nmail")
+    (version "3.74")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/d99kris/nmail/")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+                (base32
+                "07lkl5syx3l37dhsl41nhmjknhxqgmvwc4il4gygsnr333qk75c9"))))
+    (build-system cmake-build-system)
+    (arguments
+      (list #:phases
+            #~(modify-phases %standard-phases
+                (replace 'check
+                  (lambda* (#:key tests? #:allow-other-keys)
+                    (when tests? (invoke "ctest" "--output-on-failure")))))))
+    (inputs
+     (list cyrus-sasl
+           file
+           libetpan
+           ncurses
+           openssl
+           sqlite
+           (list util-linux "lib")
+           xapian))
+    (native-inputs (list pkg-config))
+    (home-page "https://github.com/d99kris/nmail")
+    (synopsis "Terminal-based email client")
+    (description
+     "@command{nmail} is an easily configurable terminal-based email client with
+a @code{ncurses} user interface similar to @code{alpine} and @code{pine}.")
+    (license license:expat)))
+
 (define-public go-gitlab.com-shackra-goimapnotify
   (package
     (name "go-gitlab.com-shackra-goimapnotify")
-- 
2.37.2

[bug#57021] [PATCH v7 2/2] gnu: cyrus-sasl: Enable login.

[M]

* gnu/packages/cyrus-sasl.scm (cyrus-sasl)[arguments]: Enable login.

  Exchange servers require login for e-mail clients that use cyrus-sasl.
---
 gnu/packages/cyrus-sasl.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/cyrus-sasl.scm b/gnu/packages/cyrus-sasl.scm
index 2cd18f3e5e..edeb2dded2 100644
--- a/gnu/packages/cyrus-sasl.scm
+++ b/gnu/packages/cyrus-sasl.scm
@@ -3,6 +3,7 @@
 ;;; Copyright © 2013 Andreas Enge <andreas@enge.fr>
 ;;; Copyright © 2016 Leo Famulari <leo@famulari.name>
 ;;; Copyright © 2019 Mathieu Othacehe <m.othacehe@gmail.com>
+;;; Copyright © 2022 Mathieu Laparie <mlaparie@disr.it>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -54,10 +55,11 @@ (define-public cyrus-sasl
     (list ;; cyrus-sasl.pc refers to -lkrb5, so propagate it.
           mit-krb5))
    (arguments
-    '(#:configure-flags (list (string-append "--with-plugindir="
+    '(#:configure-flags (list "--enable-login" 
+                              (string-append "--with-plugindir="
                                              (assoc-ref %outputs "out")
                                              "/lib/sasl2"))
-
+                        
       ;; The 'plugins' directory has shared source files, such as
       ;; 'plugin_common.c'.  When building the shared libraries there, libtool
       ;; ends up doing "ln -s plugin_common.lo plugin_common.o", which can
-- 
2.37.2

[bug#57021] [PATCH v8 1/2] gnu: Add nmail.

[M]

* gnu/packages/mail.scm (nmail): New variable.
---
 gnu/packages/mail.scm | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index 65d8060862..8f2452a61f 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -50,6 +50,7 @@
 ;;; Copyright © 2022 Guillaume Le Vaillant <glv@posteo.net>
 ;;; Copyright © 2022 muradm <mail@muradm.net>
 ;;; Copyright © 2022 jgart <jgart@dismail.de>
+;;; Copyright © 2022 Mathieu Laparie <mlaparie@disr.it>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -405,6 +406,43 @@ (define-public mailutils
      ;; Libraries are under LGPLv3+, and programs under GPLv3+.
      (list license:gpl3+ license:lgpl3+))))
 
+(define-public nmail
+  (package
+    (name "nmail")
+    (version "3.74")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/d99kris/nmail/")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+                (base32
+                "07lkl5syx3l37dhsl41nhmjknhxqgmvwc4il4gygsnr333qk75c9"))))
+    (build-system cmake-build-system)
+    (arguments
+      (list #:phases
+            #~(modify-phases %standard-phases
+                (replace 'check
+                  (lambda* (#:key tests? #:allow-other-keys)
+                    (when tests? (invoke "ctest" "--output-on-failure")))))))
+    (inputs
+     (list cyrus-sasl
+           file
+           libetpan
+           ncurses
+           openssl
+           sqlite
+           (list util-linux "lib")
+           xapian))
+    (native-inputs (list pkg-config))
+    (home-page "https://github.com/d99kris/nmail")
+    (synopsis "Terminal-based email client")
+    (description
+     "@command{nmail} is an easily configurable terminal-based email client with
+a @code{ncurses} user interface similar to @code{alpine} and @code{pine}.")
+    (license license:expat)))
+
 (define-public go-gitlab.com-shackra-goimapnotify
   (package
     (name "go-gitlab.com-shackra-goimapnotify")
-- 
2.37.2

[bug#57021] [PATCH v8 2/2] gnu: cyrus-sasl: Enable login.

[M]

* gnu/packages/cyrus-sasl.scm (cyrus-sasl)[arguments]: Enable login.

  Exchange servers require login for e-mail clients that use cyrus-sasl.
---
 gnu/packages/cyrus-sasl.scm | 6 ++++--
 gnu/packages/mail.scm       | 4 ++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/cyrus-sasl.scm b/gnu/packages/cyrus-sasl.scm
index 2cd18f3e5e..edeb2dded2 100644
--- a/gnu/packages/cyrus-sasl.scm
+++ b/gnu/packages/cyrus-sasl.scm
@@ -3,6 +3,7 @@
 ;;; Copyright © 2013 Andreas Enge <andreas@enge.fr>
 ;;; Copyright © 2016 Leo Famulari <leo@famulari.name>
 ;;; Copyright © 2019 Mathieu Othacehe <m.othacehe@gmail.com>
+;;; Copyright © 2022 Mathieu Laparie <mlaparie@disr.it>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -54,10 +55,11 @@ (define-public cyrus-sasl
     (list ;; cyrus-sasl.pc refers to -lkrb5, so propagate it.
           mit-krb5))
    (arguments
-    '(#:configure-flags (list (string-append "--with-plugindir="
+    '(#:configure-flags (list "--enable-login" 
+                              (string-append "--with-plugindir="
                                              (assoc-ref %outputs "out")
                                              "/lib/sasl2"))
-
+                        
       ;; The 'plugins' directory has shared source files, such as
       ;; 'plugin_common.c'.  When building the shared libraries there, libtool
       ;; ends up doing "ln -s plugin_common.lo plugin_common.o", which can
diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index 8f2452a61f..f127772a92 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -409,7 +409,7 @@ (define-public mailutils
 (define-public nmail
   (package
     (name "nmail")
-    (version "3.74")
+    (version "3.89")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -418,7 +418,7 @@ (define-public nmail
               (file-name (git-file-name name version))
               (sha256
                 (base32
-                "07lkl5syx3l37dhsl41nhmjknhxqgmvwc4il4gygsnr333qk75c9"))))
+                "1ris5fijmk41279hm9kp1v0niiq83a2lk2mmq1r9z31k7n2yg2v2"))))
     (build-system cmake-build-system)
     (arguments
       (list #:phases
-- 
2.37.2

[bug#57021] [PATCH v9] gnu: Add nmail.

[Christina O'Donnell]

From: M <matf@disr.it>

* gnu/packages/mail.scm (nmail): New variable.

Reviewed-by: Christina O'Donnell <cdo@mutix.org>
Change-Id: I850ac3a1b6e6db6d1869bb3fe8ff9d3a9e71cc86
---
 gnu/packages/mail.scm | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index e0fbd0a5ff3..3eb4f57e67e 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -51,6 +51,7 @@
 ;;; Copyright © 2022 muradm <mail@muradm.net>
 ;;; Copyright © 2022 jgart <jgart@dismail.de>
 ;;; Copyright © 2022 ( <paren@disroot.org>
+;;; Copyright © 2022 Mathieu Laparie <mlaparie@disr.it>
 ;;; Copyright © 2023 Timo Wilken <guix@twilken.net>
 ;;; Copyright © 2023 Arjan Adriaanse <arjan@adriaan.se>
 ;;; Copyright © 2023 Wilko Meyer <w@wmeyer.eu>
@@ -455,6 +456,43 @@ (define-public mairix
 Maildir, MH, MMDF or mbox folders.")
       (license license:gpl2))))
 
+(define-public nmail
+  (package
+    (name "nmail")
+    (version "4.54")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/d99kris/nmail/")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0bk2kq0pk1r4w5xv94yh37vrwxs8lczjg11gfraxh9cxyjigwsrp"))))
+    (build-system cmake-build-system)
+    (arguments
+     (list
+      #:phases #~(modify-phases %standard-phases
+                   (replace 'check
+                     (lambda* (#:key tests? #:allow-other-keys)
+                       (when tests?
+                         (invoke "ctest" "--output-on-failure")))))))
+    (inputs (list cyrus-sasl
+                  file
+                  libetpan
+                  ncurses
+                  openssl
+                  sqlite
+                  (list util-linux "lib")
+                  xapian))
+    (native-inputs (list pkg-config))
+    (home-page "https://github.com/d99kris/nmail")
+    (synopsis "Terminal-based email client")
+    (description
+     "@command{nmail} is an easily configurable terminal-based email client with
+a @code{ncurses} user interface similar to @code{alpine} and @code{pine}.")
+    (license license:expat)))
+
 (define-public go-gitlab.com-shackra-goimapnotify
   (package
     (name "go-gitlab.com-shackra-goimapnotify")

base-commit: ba52975ea91af49e8e6a436438a578589a209ecc
-- 
2.41.0

[bug#57021] [PATCH] gnu: packages: Add nmail.

[Christina O'Donnell]

Hi Mathieu Laparie,

Thank you for your patch. Sorry it has taken so long to get to it.

This patch looks good. It applies and runs and lints with few issues.

I've re-rolled a version 9 patch on the latest master branch, updating 
the version and changing the formatting slightly.

Regarding the second diff, I'm not sure what the justification is for 
changing cyrus-sasl in the same patch, so I've removed that part. If 
that change needs to happen then I would think it would make more sense 
as a separate patch.

Kind regards,
Christina

[bug#57021] [PATCH] gnu: packages: Add nmail.

[Mathieu]

Awesome news, thanks a ton Christina!

Have you tried sending emails without the `cyrus-sasl` patch? Unless the package changed since I submitted this patch, sending emails may fail because `cyrus-sasl` needs to be compiled with the `--enable-login` flag, which I think was not default. I haven't tested lately though because I was running `nmail` and `cyrus-sasl` from my private channel since a long time.

Mathieu

On 2024-04-21 16:03 Christina O'Donnell <cdo@mutix.org> wrote:

> Hi Mathieu Laparie,
>  
> Thank you for your patch. Sorry it has taken so long to get to it.
>  
> This patch looks good. It applies and runs and lints with few issues.
>  
> I've re-rolled a version 9 patch on the latest master branch,
> updating the version and changing the formatting slightly.
>  
> Regarding the second diff, I'm not sure what the justification is for
> changing cyrus-sasl in the same patch, so I've removed that part. If
> that change needs to happen then I would think it would make more
> sense as a separate patch.
>  
> Kind regards, Christina
>

[bug#57021] [PATCH] gnu: packages: Add nmail.

[Christina]

Hi Mathieu,

I'm testing it right now connecting to my server on IMAP STARTTLS.

It's working fine for me over IMAP and works over on SMTP over SSL if you receive this message.

Is --enable-login required for OAUTH?

I did notice it failed to build a second time due to missing dependencies which is odd. I'll send an update patch to fix that shortly.

Kind regards,
Christina  

On 2024-04-22 10:21 Mathieu <mlaparie@disr.it> wrote:

> Awesome news, thanks a ton Christina!
>  
> Have you tried sending emails without the `cyrus-sasl` patch? Unless
> the package changed since I submitted this patch, sending emails may
> fail because `cyrus-sasl` needs to be compiled with the
> `--enable-login` flag, which I think was not default. I haven't
> tested lately though because I was running `nmail` and `cyrus-sasl`
> from my private channel since a long time.
>  
> Mathieu
>  
> On 2024-04-21 16:03 Christina O'Donnell <cdo@mutix.org> wrote:
>  
>> Hi Mathieu Laparie,
>>  
>> Thank you for your patch. Sorry it has taken so long to get to it.
>>  
>> This patch looks good. It applies and runs and lints with few
>> issues.
>>  
>> I've re-rolled a version 9 patch on the latest master branch,
>> updating the version and changing the formatting slightly.
>>  
>> Regarding the second diff, I'm not sure what the justification is
>> for
>> changing cyrus-sasl in the same patch, so I've removed that part.
>> If
>> that change needs to happen then I would think it would make more
>> sense as a separate patch.
>>  
>> Kind regards, Christina
>>

[bug#57021] [PATCH v10] gnu: Add nmail.

[Christina O'Donnell]

From: M <matf@disr.it>

* gnu/packages/mail.scm (nmail): New variable.

Reviewed-by: Christina O'Donnell <cdo@mutix.org>
Change-Id: I850ac3a1b6e6db6d1869bb3fe8ff9d3a9e71cc86
---
 gnu/packages/mail.scm | 41 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index 6d5deca741b..139150224a5 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -51,6 +51,7 @@
 ;;; Copyright © 2022 muradm <mail@muradm.net>
 ;;; Copyright © 2022 jgart <jgart@dismail.de>
 ;;; Copyright © 2022 ( <paren@disroot.org>
+;;; Copyright © 2022 Mathieu Laparie <mlaparie@disr.it>
 ;;; Copyright © 2023 Timo Wilken <guix@twilken.net>
 ;;; Copyright © 2023 Arjan Adriaanse <arjan@adriaan.se>
 ;;; Copyright © 2023 Wilko Meyer <w@wmeyer.eu>
@@ -455,6 +456,46 @@ (define-public mairix
 Maildir, MH, MMDF or mbox folders.")
       (license license:gpl2))))
 
+(define-public nmail
+  (package
+    (name "nmail")
+    (version "4.54")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/d99kris/nmail/")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0bk2kq0pk1r4w5xv94yh37vrwxs8lczjg11gfraxh9cxyjigwsrp"))))
+    (build-system cmake-build-system)
+    (arguments
+     (list
+      #:phases #~(modify-phases %standard-phases
+                   (replace 'check
+                     (lambda* (#:key tests? #:allow-other-keys)
+                       (when tests?
+                         (invoke "ctest" "--output-on-failure")))))))
+    (inputs (list curl
+                  cyrus-sasl
+                  expat
+                  file
+                  libetpan
+                  ncurses
+                  openssl
+                  sqlite
+                  (list util-linux "lib")
+                  xapian
+                  zlib))
+    (native-inputs (list pkg-config))
+    (home-page "https://github.com/d99kris/nmail")
+    (synopsis "Terminal-based email client")
+    (description
+     "@command{nmail} is an easily configurable terminal-based email client with
+a @code{ncurses} user interface similar to @code{alpine} and @code{pine}.")
+    (license license:expat)))
+
 (define-public go-gitlab.com-shackra-goimapnotify
   (package
     (name "go-gitlab.com-shackra-goimapnotify")

base-commit: 28e41dc3bcb37bfe0dffb118d1b60b6df98a49e2
-- 
2.41.0

[bug#57021] [PATCH] gnu: packages: Add nmail.

[Christopher Baines]

[-- Attachment #1: Type: text/plain, Size: 656 bytes --]

Mathieu <mlaparie@disr.it> writes:

> Awesome news, thanks a ton Christina!
>
> Have you tried sending emails without the `cyrus-sasl` patch? Unless
> the package changed since I submitted this patch, sending emails may
> fail because `cyrus-sasl` needs to be compiled with the
> `--enable-login` flag, which I think was not default. I haven't tested
> lately though because I was running `nmail` and `cyrus-sasl` from my
> private channel since a long time.

Given cyrus-sasl has a lot of dependencies (as reported by guix refresh
-l), it would be good to submit this patch separately, even though that
change is required for some functionality in nmail.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

bug#57021: [PATCH v10] gnu: Add nmail.

[Christopher Baines]

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

Christina O'Donnell <cdo@mutix.org> writes:

> From: M <matf@disr.it>
>
> * gnu/packages/mail.scm (nmail): New variable.
>
> Reviewed-by: Christina O'Donnell <cdo@mutix.org>
> Change-Id: I850ac3a1b6e6db6d1869bb3fe8ff9d3a9e71cc86
> ---
>  gnu/packages/mail.scm | 41 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 41 insertions(+)

Thanks all, I've pushed this to master now as
8dbe101b3049e6159afaab1df38354b7bd657733.

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]