all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Troy Figiel <troy@troyfigiel.com>
To: 69608@debbugs.gnu.org
Cc: Sharlatan Hellseher <sharlatanus@gmail.com>
Subject: [bug#69608] [PATCH 7/7] gnu: kubo: Unbundle more packages.
Date: Thu, 7 Mar 2024 16:57:13 +0100	[thread overview]
Message-ID: <48d77090-85b6-4f25-b306-e9ead3dbd898@troyfigiel.com> (raw)
In-Reply-To: <2e89095c79519b44e0bec91c6d61454bc19817e0.1709812934.git.sharlatanus@gmail.com>

Hi Oleg,

Quick note for the future, not a review.

On 2024-03-07 13:18, Sharlatan Hellseher wrote:
>         (snippet '(for-each delete-file-recursively
>                             ;; TODO: unbundle the rest as well
>                             '("vendor/github.com/alecthomas"
> -                             ;; "vendor/github.com/blang"
> +                             "vendor/github.com/benbjohnson/clock"
> +                             "vendor/github.com/beorn7/perks"
> +                             "vendor/github.com/blang"
>                               "vendor/github.com/cespare"
> -                             ;; TODO: Go files not found
> -                             ;; "vendor/github.com/cheggaaa"
> +                             ;; TODO: kubo depends on v1.0.29 which is way too
> +                             ;; hard to back port.
> +                             ; "vendor/github.com/cheggaaa/pb"
>                               "vendor/github.com/davecgh"
>                               "vendor/github.com/dustin"
>                               "vendor/github.com/flynn"
> @@ -261,8 +264,6 @@ (define-public kubo
>                               ;; "vendor/github.com/ipld"
>                               "vendor/github.com/jackpal"
>                               "vendor/github.com/klauspost"
> -                             ;; TODO: Go files not found
> -                             ;; "vendor/github.com/lucas-clemente"
>                               "vendor/github.com/mattn"
>                               "vendor/github.com/mgutz"
>                               "vendor/github.com/minio"

A phase that removes the "vendor" directory (if it exists), would be
nice. "vendor" is the standard location Go uses to bundle all
dependencies, so it would be a simple way to get rid of most/all bundled
dependencies of a package. I noticed Nix indeed uses a similar step in
their build process.

Best wishes,

Troy




  reply	other threads:[~2024-03-07 15:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-07 12:17 [bug#69608] [PATCH 0/7] gnu: kubo: Unbundle more packages Sharlatan Hellseher
2024-03-07 12:18 ` [bug#69608] [PATCH 1/7] gnu: go-github-com-blang-semver: Update to 3.8.0 Sharlatan Hellseher
2024-03-07 12:18 ` [bug#69608] [PATCH 2/7] gnu: go-github-com-blang-semver: Fix indentation Sharlatan Hellseher
2024-03-07 12:18 ` [bug#69608] [PATCH 3/7] gnu: Add go-github-com-blang-semver-v4 Sharlatan Hellseher
2024-03-07 12:18 ` [bug#69608] [PATCH 4/7] gnu: kubo: Sort inputs alphabetically Sharlatan Hellseher
2024-03-07 12:18 ` [bug#69608] [PATCH 5/7] gnu: go-github-com-beorn7-perks-quantile: Update to 1.0.1 Sharlatan Hellseher
2024-03-07 12:18 ` [bug#69608] [PATCH 6/7] gnu: go-github-com-beorn7-perks-quantile: Fix indentation Sharlatan Hellseher
2024-03-07 12:18 ` [bug#69608] [PATCH 7/7] gnu: kubo: Unbundle more packages Sharlatan Hellseher
2024-03-07 15:57   ` Troy Figiel [this message]
2024-03-16  0:04 ` bug#69608: [PATCH 0/7] " Sharlatan Hellseher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48d77090-85b6-4f25-b306-e9ead3dbd898@troyfigiel.com \
    --to=troy@troyfigiel.com \
    --cc=69608@debbugs.gnu.org \
    --cc=sharlatanus@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.