From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id l2r4EDooCGF6KgEAgWs5BA (envelope-from ) for ; Mon, 02 Aug 2021 19:15:38 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 0P0MDDooCGEeAgAAbx9fmQ (envelope-from ) for ; Mon, 02 Aug 2021 17:15:38 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BC4892EDC7 for ; Mon, 2 Aug 2021 19:15:37 +0200 (CEST) Received: from localhost ([::1]:44878 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mAbXM-0005lM-Rh for larch@yhetil.org; Mon, 02 Aug 2021 13:15:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34174) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mAbWo-0005OL-Vh for guix-patches@gnu.org; Mon, 02 Aug 2021 13:15:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55861) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mAbWo-00068u-Np for guix-patches@gnu.org; Mon, 02 Aug 2021 13:15:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mAbWo-0007Eu-Ko for guix-patches@gnu.org; Mon, 02 Aug 2021 13:15:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49828] [PATCH 01/20] gnu: minetest: Respect --without-tests. Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 02 Aug 2021 17:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49828 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos , 49828@debbugs.gnu.org Received: via spool by 49828-submit@debbugs.gnu.org id=B49828.162792447627757 (code B ref 49828); Mon, 02 Aug 2021 17:15:02 +0000 Received: (at 49828) by debbugs.gnu.org; 2 Aug 2021 17:14:36 +0000 Received: from localhost ([127.0.0.1]:39170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mAbWN-0007Dd-VA for submit@debbugs.gnu.org; Mon, 02 Aug 2021 13:14:36 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:33914) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mAbWL-0007DU-FP for 49828@debbugs.gnu.org; Mon, 02 Aug 2021 13:14:34 -0400 Received: from [10.0.0.4] (194-118-35-216.adsl.highway.telekom.at [194.118.35.216]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4Gdl3p24lNz3xPN; Mon, 2 Aug 2021 19:14:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1627924470; bh=FY0VZQ1ePBRvMDjbGlYPVSNcH004w3BDQSnITsbvjwo=; h=Subject:From:To:Date:In-Reply-To:References; b=pQ0LH0GnkzdpVfL0bielD6WcpiTYQresE1FzS0A0fCTXKwp7nmWU9XMa7A8iRD44v Mj+xn0dbSoj/gWu+tlwu6U8iLY4K+TOLHfhGrRxwS0SfVEST2KGepWS0xf8ps6Ppp6 0+aEL1DZ7jA9aZDsM9RHbYw+t8RekTXuLRzopnoM= Message-ID: <48cb75464f69573a09652853fff2581618b4f83a.camel@student.tugraz.at> From: Leo Prikler Date: Mon, 02 Aug 2021 19:14:04 +0200 In-Reply-To: <20210802155019.6122-1-maximedevos@telenet.be> References: <20210802155019.6122-1-maximedevos@telenet.be> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1627924537; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=FY0VZQ1ePBRvMDjbGlYPVSNcH004w3BDQSnITsbvjwo=; b=PFY/FY1xeAHlI8O9KzuaR0R/UI4BiPxXAvkt2VYC+c0RLaM5GtFmNBVBJIuN6a05cjj+KH lzhiFsVq+8kqz2ew6BpWfI1KGRdwbFkexngiacCEnKoEeKP7T7YDSoqOiyFYCIb46tVyTD MBQHWiGip5Ad3i0pT7ijFVHVVlgEjYaG4IRZwulo6hnmiB7VnRlIbUFEl15aJcjrOxonDC E8HuO0NKxch1Tarma1nP/phdHkZgMRQ2ADHTtF+ng0h9gvOogJkHQzwKIpV51Yhr5RBXv1 5dJ0YgGGQt7oLhGJtJkHuuzKWlzt0j34K8U9zNHjIYJ2t4XQjDbt+q9gPt4Bvw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1627924537; a=rsa-sha256; cv=none; b=Wg5orqn+qcWjC1Nyr21pcDJMmYWP7JLn56xtpJJITPKX4by0MFBS+NEOyqatRj+MMN5QkC GQiTkUTXiWmPNAQMGI5O/w5nKGuWqwjRYomRHDR8guCDEWHc4uhw4YggqGUo3LAROUTG9f x4NNo6GGwIDblJKIgoQCfFnCR16HXRAByCh8z3IKAfz/1kt9QBpIWJW/3HOSlfdQ0bXyoo DodZ90RfZzW/qziysy79qYWt9GTCV5YcRkZgOtd09MzAtcRStKed1qZwZDcwHkW/VHWTLz gWCeSoWLQgQ4v1L3a6hfQHZ8A3+IwMgpiaj6sDaPcl1IfTomUCyyA4z0Ewa9GQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=pQ0LH0Gn; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=pQ0LH0Gn; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: BC4892EDC7 X-Spam-Score: -1.32 X-Migadu-Scanner: scn1.migadu.com X-TUID: YbnhpC9HwF13 Hi Maxime, Am Montag, den 02.08.2021, 17:50 +0200 schrieb Maxime Devos: > * gnu/packages/games.scm > (minetest)[arguments]<#:phases>{check}: Use 'tests?' instead > of ',(%current-target-system)'. Remove trailing #t. For context, (%current-target-system) is used because tests only work in native builds. If this can't be reflected in the value of tests?, we should have both checks, imo. > --- > gnu/packages/games.scm | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm > index 8c6b5523f1..3e7086b398 100644 > --- a/gnu/packages/games.scm > +++ b/gnu/packages/games.scm > @@ -3590,13 +3590,12 @@ match, cannon keep, and grave-itation pit.") > (string-append (getcwd) "/games")) ; for check > #t)) > (replace 'check > - (lambda _ > + (lambda* (#:key tests? #:allow-other-keys) > ;; Thanks to our substitutions, the tests should also > run > ;; when invoked on the target outside of `guix build'. > - (unless ,(%current-target-system) > + (when tests? > (setenv "HOME" "/tmp") > - (invoke "src/minetest" "--run-unittests")) > - #t))))) > + (invoke "src/minetest" "--run-unittests"))))))) > (native-search-paths > (list (search-path-specification > (variable "MINETEST_SUBGAME_PATH")