all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Bruno Victal <mirai@makinata.eu>
To: Unstable Horse <stable.master@unstable.horse>
Cc: 64443@debbugs.gnu.org
Subject: [bug#64443] [PATCH v1] gnu: Add gp-saml-gui
Date: Wed, 5 Jul 2023 15:22:09 +0100	[thread overview]
Message-ID: <48a62d97-d0a1-6ec6-9d92-f0c9941880c8@makinata.eu> (raw)
In-Reply-To: <8d71ec46a7d06cecf6a5d8afb2585277980b3a73.camel@unstable.horse>

Hi,

On 2023-07-04 11:58, Unstable Horse wrote:
> +      (arguments
> +       `(#:phases
> +         (modify-phases %standard-phases
> +           (add-after 'install 'wrap-program
> +             (lambda* (#:key outputs #:allow-other-keys)
> +               (wrap-program
> +                   (string-append (assoc-ref outputs "out") "/bin/gp-saml-gui")
> +                 `("GUIX_PYTHONPATH" ":" prefix
> +                   (,(getenv "GUIX_PYTHONPATH")))
> +                 `("GI_TYPELIB_PATH" ":" prefix
> +                   (,(getenv "GI_TYPELIB_PATH")))))))))

I'd use G-Expressions and write this part as:

--8<---------------cut here---------------start------------->8---
(list
 #:phases
 #~(modify-phases %standard-phases
     (add-after 'install 'wrap-program
       (lambda _
         (let ((prog (string-append #$output "/bin/gp-saml-gui")))
           (wrap-program prog
             `("GUIX_PYTHONPATH" = (,(getenv "GUIX_PYTHONPATH")))
             `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH")))))))))
--8<---------------cut here---------------end--------------->8---

Another thing, your email client mangled this patch since I had to do
some sed magic to remove the Unicode non-breaking spaces.
Please use 'git send-email' as it doesn't exhibit this behavior.


-- 
Furthermore, I consider that nonfree software must be eradicated.

Cheers,
Bruno.





  reply	other threads:[~2023-07-05 14:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-03 15:59 [bug#64443] [PATCH] gnu: Add gp-saml-gui Unstable Horse
2023-07-04 10:58 ` [bug#64443] [PATCH v1] " Unstable Horse
2023-07-05 14:22   ` Bruno Victal [this message]
2023-07-05 15:49     ` Unstable Horse
2023-07-05 16:50 ` [bug#64443] [PATCH v2] " Unstable Horse
2023-08-08 14:47   ` bug#64443: [PATCH] " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48a62d97-d0a1-6ec6-9d92-f0c9941880c8@makinata.eu \
    --to=mirai@makinata.eu \
    --cc=64443@debbugs.gnu.org \
    --cc=stable.master@unstable.horse \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.